Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller
@ 2019-02-02 15:06 Carlo Caione
  2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Carlo Caione @ 2019-02-02 15:06 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	linux-imx, l.stach, devicetree, linux-arm-kernel
  Cc: Carlo Caione

Add a new node to enable the On-Chip OTP controller and add the new 
binding in the documentation.

Carlo Caione (2):
  arm64: dts: imx8mq: Add on-chip OTP controller node
  dt-bindings: imx-ocotp: Add i.MX8MQ compatible

 Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
 arch/arm64/boot/dts/freescale/imx8mq.dtsi             | 8 ++++++++
 2 files changed, 9 insertions(+)

-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
  2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
@ 2019-02-02 15:06 ` Carlo Caione
  2019-02-04 10:26   ` Lucas Stach
  2019-02-11 12:03   ` Lucas Stach
  2019-02-02 15:06 ` [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Carlo Caione
  2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
  2 siblings, 2 replies; 10+ messages in thread
From: Carlo Caione @ 2019-02-02 15:06 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	linux-imx, l.stach, devicetree, linux-arm-kernel
  Cc: Carlo Caione

Add the node for the OTP controller. The IP is the same as on the imx7d.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index c34cabe9b356..f37f17b71151 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -241,6 +241,14 @@
 				reg = <0x30340000 0x10000>;
 			};
 
+			ocotp: ocotp-ctrl@30350000 {
+				compatible = "fsl,imx8mq-ocotp", "fsl,imx7d-ocotp", "syscon";
+				reg = <0x30350000 0x10000>;
+				clocks = <&clk IMX8MQ_CLK_OCOTP_ROOT>;
+				#address-cells = <1>;
+				#size-cells = <1>;
+			};
+
 			anatop: syscon@30360000 {
 				compatible = "fsl,imx8mq-anatop", "syscon";
 				reg = <0x30360000 0x10000>;
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible
  2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
  2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
@ 2019-02-02 15:06 ` Carlo Caione
  2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
  2 siblings, 0 replies; 10+ messages in thread
From: Carlo Caione @ 2019-02-02 15:06 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
	linux-imx, l.stach, devicetree, linux-arm-kernel
  Cc: Carlo Caione

Document the new compatible for the i.MX8MQ SoC.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
 Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
index 7a999a135e56..fec66e3b45c3 100644
--- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
+++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.txt
@@ -13,6 +13,7 @@ Required properties:
 	"fsl,imx7d-ocotp" (i.MX7D/S),
 	"fsl,imx6sll-ocotp" (i.MX6SLL),
 	"fsl,imx7ulp-ocotp" (i.MX7ULP),
+	"fsl,imx8mq-ocotp" (i.MX8MQ),
 	followed by "syscon".
 - #address-cells : Should be 1
 - #size-cells : Should be 1
-- 
2.19.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
  2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
@ 2019-02-04 10:26   ` Lucas Stach
  2019-02-11 12:03   ` Lucas Stach
  1 sibling, 0 replies; 10+ messages in thread
From: Lucas Stach @ 2019-02-04 10:26 UTC (permalink / raw)
  To: Carlo Caione, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, linux-imx, devicetree, linux-arm-kernel

Am Samstag, den 02.02.2019, 15:06 +0000 schrieb Carlo Caione:
> Add the node for the OTP controller. The IP is the same as on the imx7d.
> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index c34cabe9b356..f37f17b71151 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -241,6 +241,14 @@
>  				reg = <0x30340000 0x10000>;
>  			};
>  
> +			ocotp: ocotp-ctrl@30350000 {
> +				compatible = "fsl,imx8mq-ocotp", "fsl,imx7d-ocotp", "syscon";
> +				reg = <0x30350000 0x10000>;
> +				clocks = <&clk IMX8MQ_CLK_OCOTP_ROOT>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +			};
> +
>  			anatop: syscon@30360000 {
>  				compatible = "fsl,imx8mq-anatop", "syscon";
>  				reg = <0x30360000 0x10000>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
  2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
  2019-02-04 10:26   ` Lucas Stach
@ 2019-02-11 12:03   ` Lucas Stach
  2019-02-11 13:01     ` Lucas Stach
  1 sibling, 1 reply; 10+ messages in thread
From: Lucas Stach @ 2019-02-11 12:03 UTC (permalink / raw)
  To: Carlo Caione, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, linux-imx, devicetree, linux-arm-kernel

Am Samstag, den 02.02.2019, 15:06 +0000 schrieb Carlo Caione:
> Add the node for the OTP controller. The IP is the same as on the imx7d.

This is not true. According to the reference manual, the OCOTP
controller on i.MX8MQ uses the non-banked write mode, same as i.MX6.
Thus it is incompatible to the i.MX7 OCOTP.

Also the number of fuses is different, so we really need some driver
support for the imx8mq compatible and can't declare the controller
compatible to some older instance.

Regards,
Lucas

> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index c34cabe9b356..f37f17b71151 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -241,6 +241,14 @@
>  				reg = <0x30340000 0x10000>;
>  			};
>  
> +			ocotp: ocotp-ctrl@30350000 {
> +				compatible = "fsl,imx8mq-ocotp", "fsl,imx7d-ocotp", "syscon";
> +				reg = <0x30350000 0x10000>;
> +				clocks = <&clk IMX8MQ_CLK_OCOTP_ROOT>;
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +			};
> +
>  			anatop: syscon@30360000 {
>  				compatible = "fsl,imx8mq-anatop", "syscon";
>  				reg = <0x30360000 0x10000>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
  2019-02-11 12:03   ` Lucas Stach
@ 2019-02-11 13:01     ` Lucas Stach
  0 siblings, 0 replies; 10+ messages in thread
From: Lucas Stach @ 2019-02-11 13:01 UTC (permalink / raw)
  To: Carlo Caione, robh+dt, mark.rutland, shawnguo, s.hauer, kernel,
	festevam, linux-imx, devicetree, linux-arm-kernel

Am Montag, den 11.02.2019, 13:03 +0100 schrieb Lucas Stach:
> Am Samstag, den 02.02.2019, 15:06 +0000 schrieb Carlo Caione:
> > Add the node for the OTP controller. The IP is the same as on the
> > imx7d.
> 
> This is not true. According to the reference manual, the OCOTP
> controller on i.MX8MQ uses the non-banked write mode, same as i.MX6.
> Thus it is incompatible to the i.MX7 OCOTP.

Actually I need to correct myself here. While the programming sequence
description is the same as on i.MX6, the register layout looks like the
i.MX7 one, so likely someone copy and pasted the wrong documentation
snippet. This means the controller is in fact compatible to the i.MX7
write sequence.

> Also the number of fuses is different, so we really need some driver
> support for the imx8mq compatible and can't declare the controller
> compatible to some older instance.

But then I think this is still true. The changed number of fuses means
we need some driver support and should not claim backward compatibility
with the i.MX7 controller.

regards,
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller
  2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
  2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
  2019-02-02 15:06 ` [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Carlo Caione
@ 2019-02-25 15:11 ` Abel Vesa
  2019-02-26  8:57   ` Carlo Caione
  2 siblings, 1 reply; 10+ messages in thread
From: Abel Vesa @ 2019-02-25 15:11 UTC (permalink / raw)
  To: Carlo Caione
  Cc: mark.rutland, devicetree, shawnguo, s.hauer, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel, l.stach

On 19-02-02 15:06:36, Carlo Caione wrote:
> Add a new node to enable the On-Chip OTP controller and add the new 
> binding in the documentation.
> 
> Carlo Caione (2):
>   arm64: dts: imx8mq: Add on-chip OTP controller node
>   dt-bindings: imx-ocotp: Add i.MX8MQ compatible
> 
>  Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi             | 8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> -- 
> 2.19.1
> 

What's the status of this patchseries ?

It would help a lot if we would manage to get this in.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller
  2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
@ 2019-02-26  8:57   ` Carlo Caione
  2019-02-26  9:01     ` Abel Vesa
  2019-02-26  9:03     ` Lucas Stach
  0 siblings, 2 replies; 10+ messages in thread
From: Carlo Caione @ 2019-02-26  8:57 UTC (permalink / raw)
  To: Abel Vesa
  Cc: mark.rutland, devicetree, shawnguo, s.hauer, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel, l.stach

On 25/02/2019 15:11, Abel Vesa wrote:
> On 19-02-02 15:06:36, Carlo Caione wrote:
>> Add a new node to enable the On-Chip OTP controller and add the new
>> binding in the documentation.
>>
>> Carlo Caione (2):
>>    arm64: dts: imx8mq: Add on-chip OTP controller node
>>    dt-bindings: imx-ocotp: Add i.MX8MQ compatible
>>
>>   Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi             | 8 ++++++++
>>   2 files changed, 9 insertions(+)
>>
>> -- 
>> 2.19.1
>>
> 
> What's the status of this patchseries ?
> 
> It would help a lot if we would manage to get this in.

Uh, for some reason I thought Lucas was going to take care of this.
I'll submit a v2 now.

--
Carlo Caione


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller
  2019-02-26  8:57   ` Carlo Caione
@ 2019-02-26  9:01     ` Abel Vesa
  2019-02-26  9:03     ` Lucas Stach
  1 sibling, 0 replies; 10+ messages in thread
From: Abel Vesa @ 2019-02-26  9:01 UTC (permalink / raw)
  To: Carlo Caione
  Cc: mark.rutland, devicetree, shawnguo, s.hauer, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel, l.stach

On 19-02-26 08:57:13, Carlo Caione wrote:
> On 25/02/2019 15:11, Abel Vesa wrote:
> > On 19-02-02 15:06:36, Carlo Caione wrote:
> > > Add a new node to enable the On-Chip OTP controller and add the new
> > > binding in the documentation.
> > > 
> > > Carlo Caione (2):
> > >    arm64: dts: imx8mq: Add on-chip OTP controller node
> > >    dt-bindings: imx-ocotp: Add i.MX8MQ compatible
> > > 
> > >   Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
> > >   arch/arm64/boot/dts/freescale/imx8mq.dtsi             | 8 ++++++++
> > >   2 files changed, 9 insertions(+)
> > > 
> > > -- 
> > > 2.19.1
> > > 
> > 
> > What's the status of this patchseries ?
> > 
> > It would help a lot if we would manage to get this in.
> 
> Uh, for some reason I thought Lucas was going to take care of this.
> I'll submit a v2 now.
> 

I tried this morning to apply and test both yours and Lucas's.

Your second patch overlaps with Lucas's.

Plus, Lucas's patch updates the the list in the description too.

So I would suggest you send only the dts update since Lucas's patch series
already has R-b and it's good to go.

> --
> Carlo Caione
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller
  2019-02-26  8:57   ` Carlo Caione
  2019-02-26  9:01     ` Abel Vesa
@ 2019-02-26  9:03     ` Lucas Stach
  1 sibling, 0 replies; 10+ messages in thread
From: Lucas Stach @ 2019-02-26  9:03 UTC (permalink / raw)
  To: Carlo Caione, Abel Vesa
  Cc: mark.rutland, devicetree, shawnguo, s.hauer, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel

Am Dienstag, den 26.02.2019, 08:57 +0000 schrieb Carlo Caione:
> On 25/02/2019 15:11, Abel Vesa wrote:
> > On 19-02-02 15:06:36, Carlo Caione wrote:
> > > Add a new node to enable the On-Chip OTP controller and add the
> > > new
> > > binding in the documentation.
> > > 
> > > Carlo Caione (2):
> > >    arm64: dts: imx8mq: Add on-chip OTP controller node
> > >    dt-bindings: imx-ocotp: Add i.MX8MQ compatible
> > > 
> > >   Documentation/devicetree/bindings/nvmem/imx-ocotp.txt | 1 +
> > >   arch/arm64/boot/dts/freescale/imx8mq.dtsi             | 8
> > > ++++++++
> > >   2 files changed, 9 insertions(+)
> > > 
> > > -- 
> > > 2.19.1
> > > 
> > 
> > What's the status of this patchseries ?
> > 
> > It would help a lot if we would manage to get this in.
> 
> Uh, for some reason I thought Lucas was going to take care of this.
> I'll submit a v2 now.

Huh? I've sent out the entire series [1]. It's just waiting for the
nvmem maintainers to pull it in AFAICS. There should be no need to
resend anything.

Regards,
Lucas


[1] https://patchwork.ozlabs.org/patch/1039959/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
2019-02-04 10:26   ` Lucas Stach
2019-02-11 12:03   ` Lucas Stach
2019-02-11 13:01     ` Lucas Stach
2019-02-02 15:06 ` [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Carlo Caione
2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
2019-02-26  8:57   ` Carlo Caione
2019-02-26  9:01     ` Abel Vesa
2019-02-26  9:03     ` Lucas Stach

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox