From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B508C43381 for ; Wed, 27 Feb 2019 09:47:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DE1C213A2 for ; Wed, 27 Feb 2019 09:47:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HOMrLV/D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DE1C213A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sMTWU2CNL4wp8eYvhUCjsfhyUZ0T6efWwkbv/rS6wrg=; b=HOMrLV/Djk8OEO Nkes7UYaXu6c07QuprTvDSOPHGLsZzztqSFdfCX725bkuL+Hw642BpseRXCWvuSADkkPNUdWF0Qxl RNzGjUCOuDvdQ2brNFwX59mH/9dn9QHMucnR9KEICfw1PwlgwnVKMwdJ14HSKd5+VQ0OaCvg/z7xO dl2UOelBivsp2almVWfEa9G0A5LZ840RebO/YoRv1pzo4tYnRtV+EatvLS47wdYd/ey6w+99/2Guo n/T5E9pLY9y+1lUNI2QlIRXyh355wtSAouNmAOTZPeGO5UsSPC46lscWV56xIF4ja8StwIYfikuZj t2kIMFVgOPoSoCcw3a5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyvo7-0002VO-L4; Wed, 27 Feb 2019 09:47:19 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gyvo4-0002Uq-DG; Wed, 27 Feb 2019 09:47:18 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 44221260F44; Wed, 27 Feb 2019 09:47:14 +0000 (GMT) Date: Wed, 27 Feb 2019 10:47:11 +0100 From: Boris Brezillon To: Miquel Raynal Subject: Re: [RFC PATCH 03/27] mtd: nand: Introduce the ECC engine abstraction Message-ID: <20190227104703.386c677e@kernel.org> In-Reply-To: <20190227102642.4a1c8224@xps13> References: <20190221100216.25255-1-miquel.raynal@bootlin.com> <20190221100216.25255-4-miquel.raynal@bootlin.com> <20190221121625.33a7f6c0@kernel.org> <20190227102642.4a1c8224@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190227_014716_587234_4A2DF3D7 X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mason Yang , Vignesh R , Tudor Ambarus , Julien Su , Richard Weinberger , Schrempf Frieder , Marek Vasut , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Feb 2019 10:26:42 +0100 Miquel Raynal wrote: > > > > > + unsigned int strength; > > > + unsigned int step_size; > > > + unsigned int total; > > > > Do we really need to add this total field here? Looks like something > > that should be kept private to the ECC engine implementation. > > It was initially private, but I realized it was needed by generic parts > (including for instance the generic OOB layouts) so it could not be > made private. > > I just moved the 'total' entry out of the struct nand_ecc_conf and > moved it in the struct nand_ecc_ctx. It is still public but not in the > very generic "conf" structure anymore. Ack. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel