Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values
Date: Thu, 28 Feb 2019 10:47:01 +0800
Message-ID: <20190228024659.GF26041@dragon> (raw)
In-Reply-To: <20190211141333.28725-1-u.kleine-koenig@pengutronix.de>

On Mon, Feb 11, 2019 at 03:13:19PM +0100, Uwe Kleine-König wrote:
> Instead of relying on reset defaults or a bootloader to configure
> use explicit values for the swpad configuration. Here the reset
> defaults are used owing to lack of other evidence.

As there is a pretty good chance that kernel works only because of the
configuration set up by bootloader, we are likely going to break things.
So I'm happy to take the patches only with board maintainers' ACK.

Shawn

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> index ebe7a8bddf04..208f94be1296 100644
> --- a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> @@ -58,9 +58,9 @@
>  	imx6qdl-dfi-fs700-m60 {
>  		pinctrl_hog: hoggrp {
>  			fsl,pins = <
> -				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> -				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x80000000 /* PMIC irq */
> -				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x80000000 /* MAX11801 irq */
> +				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x0001b0b0
> +				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x0001b0b0 /* PMIC irq */
> +				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x0001b0b0 /* MAX11801 irq */
>  				MX6QDL_PAD_NANDF_D5__GPIO2_IO05 0x000030b0 /* Backlight enable */
>  			>;
>  		};
> @@ -114,7 +114,7 @@
>  				MX6QDL_PAD_SD2_DAT1__SD2_DATA1		0x17059
>  				MX6QDL_PAD_SD2_DAT2__SD2_DATA2		0x17059
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3		0x17059
> -				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x80000000 /* card detect */
> +				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 	0x1b0b0 /* card detect */
>  			>;
>  		};
>  
> @@ -149,7 +149,7 @@
>  				MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO	0x100b1
>  				MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI	0x100b1
>  				MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK	0x100b1
> -				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> +				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24	0x1b0b0 /* SPI NOR chipselect */
>  			>;
>  		};
>  	};
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 14:13 Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 02/15] ARM: dts: imx6qdl-cubox-i: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 03/15] ARM: dts: imx6qdl-hummingboard: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 04/15] ARM: dts: imx6qdl-phytec-pbab01/pfla02: " Uwe Kleine-König
2019-02-12  8:15   ` Marco Felsch
2019-02-12  8:24     ` Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 05/15] ARM: dts: imx6qdl-rex-*: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 06/15] ARM: dts: imx6qdl-sabreauto: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 07/15] ARM: dts: imx6qdl-udoo: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 08/15] ARM: dts: imx6qdl-wandboard-*: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 09/15] ARM: dts: imx6q-arm2: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 10/15] ARM: dts: imx6q-mccmon6: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 11/15] ARM: dts: imx6q-dmo-edmqmx6: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 12/15] ARM: dts: imx6qdl-aristainetos2: fix swpad values for reserved values Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 13/15] ARM: dts: imx6qdl-aristainetos: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 14/15] ARM: dts: imx6qdl-colibri: " Uwe Kleine-König
2019-02-11 14:13 ` [PATCH 15/15] ARM: dts: imx6qdl-ts7970: " Uwe Kleine-König
2019-02-28  2:47 ` Shawn Guo [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228024659.GF26041@dragon \
    --to=shawnguo@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox