From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20AC1C43381 for ; Fri, 1 Mar 2019 20:15:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E18B82084D for ; Fri, 1 Mar 2019 20:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OYxyU+xd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="kXPB0719" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E18B82084D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sHh8WUWpwpqDQjlBfdChKnQteq8B5eXhZYf6iuQaKPk=; b=OYxyU+xdb1jp2Z X2VKx5+bnTZebAOnRiaJZgBZQsYQXLwEZPz7tGDutzcqtPr7XP86+bUhoExEFp/AXn1gZP/QPMEfO 2/O3P3VKMQWtuQeKMsXjbSz/JfdGJhH7y5A48mkiJ3W8TNiJazqXneMv1LKIJ+mwftnWCpU+JX/Q0 MgcB0j6WKUfaTqct9gimMRRpOrU9xTL6OvmBjtaNcVDF2i43r+06SvGBO74NckPWvYp9O1e4blYTf JFaUNtTHa/TPjkIMj3/GFNeKp1Ym4k4NuOkuKkytyoOACzByAVQUiAuLzdmOsRmlbviGaD/ibk0Fe JSISALlm6/R0J4JLQNGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzoZG-0006Y7-Vo; Fri, 01 Mar 2019 20:15:38 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzoZD-0006XY-4H for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 20:15:36 +0000 Received: by mail-wr1-x442.google.com with SMTP id t18so27206335wrx.2 for ; Fri, 01 Mar 2019 12:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iWJym2v96IK6dnzWOixk+4fN/BIWMSM1tG3qdh2C1A0=; b=kXPB0719YM6N5FS57LnaS8hNpGKaSOiyRNeRogzcPbWjOzEMVROveyzZPr4BnpPjxX MFCexEgK8p87l6nYf4kmmFXu4rJesF2eEvoQ8Y0xCHb58Uqeo9OO8FqfjbBpQOLWq4sT X1YHjYeubxjGSTj6Arp3KdkOnSUzpMv0qw/G/EWVGDjglV93CdaDqno/2D3TiObMwWF+ d+tEO233HobrQZH3cZ75G58zHX/NUFK2I2KqsQ4cZ1C43sXKgffWyAyoEJJVTYE6hVV2 7XtS6HSMWMKei4BVn9HEKWY7b94R56Xh0gjicd5ljj1vemUMjjIzFj65zIgTDntKM+DX 5pVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iWJym2v96IK6dnzWOixk+4fN/BIWMSM1tG3qdh2C1A0=; b=c9osnHT+EIqKdVn2kU1aIX3a7NzIaeNV/8Y2AdSdHOZWKYtkvwPKTVMRywYM5I7F0b fvxBCW2RNf9T0capwXcNTTfGxQxaPJuoxn8G6Qh5K7mN5ljuACeBku9Are6oZAChJqRT mfigCBBwam7XKplb6NBnufQbbRjxp+bXv401qHP80W2I5gKjM6dS0DJ5bRCyWkF3R2zM W4YaZgCKkqCjK7zxaHMajB2EeDeS3L/EvhbMQmEOJN3mOs+ZoHEA8EkzQpLWfX8KKk3Q fXysiZUMSAkW+Z+GsYz9LI3fE8F+8pQahS6R2nZtv45xGG1Tl8wCJ0K9Tx+mrCZIjJb/ vQvA== X-Gm-Message-State: APjAAAUNCbpE0w5eVhpSflu4SlP480ycXjQWmbXWuEl+eJiXdGJo8Cuc 5Whch3evkdi4IHKo0WmF4IY= X-Google-Smtp-Source: APXvYqyUQcxYSz0DkkajW+CZgxOr/ANK2ptX+nKAP1TyXZelWSXGjVX9mYrSrdhbw0vVgJ9A0GwCgQ== X-Received: by 2002:a05:6000:6:: with SMTP id h6mr4529351wrx.134.1551471332597; Fri, 01 Mar 2019 12:15:32 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7109200428D5CFFFEB99DB8.dip0.t-ipconnect.de. [2003:dc:d710:9200:428d:5cff:feb9:9db8]) by smtp.googlemail.com with ESMTPSA id v10sm22899389wrn.26.2019.03.01.12.15.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 12:15:31 -0800 (PST) From: Martin Blumenstingl To: anarsoul@gmail.com, alex_lu@realsil.com.cn Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Date: Fri, 1 Mar 2019 21:15:19 +0100 Message-Id: <20190301201519.21953-1-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_121535_198414_27BEA2FA X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, johan.hedberg@gmail.com, robh@kernel.org, maxime.ripard@bootlin.com, netdev@vger.kernel.org, marcel@holtmann.org, stefan.wahren@i2se.com, beagleboard@davidjohnsummers.uk, linux-bluetooth@vger.kernel.org, wens@csie.org, Martin Blumenstingl , davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vasily, Hi Alex, On 22/02/2019 11:21, Vasily Khoruzhick wrote: > I agree with Rob that we should probably use firmware-name here instead. Have you considered skipping this property for v1 of this series? We can still add that property (as optional one) later on if we really see the need for it. (The btrtl code should already support the case where NULL is passed as "postfix") I checked the public rtl8723bs_bt [0] and rtl8723ds_bt [1] git repos and they each contain only one config blob. The blob from the rtl8723bs_bt repo worked on my two Amlogic boards (data only, sound input/output not tested), even though Amlogic seems to ship different blobs: [2] >> Is there a need to have the board name? > > As far as I understand firmware config depends on board, so I think > it's a good idea to use board name here. I also added Alex Lu from Realtek / Realsil to this email. Alex, I hope that you can help us with the "Bluetooth config" format for the Realtek WiFi and Bluetooth combo chips - mainly the ones which connect to the host using SDIO. This is important for us because the question came up whether we can describe everything that's part of the "config blob" as device-tree properties. If we knew the format we could generate the "config blob" on-the-fly (either by fully generating it, taking a blob - maybe with only the smallest set of config data - as "template" and update values on-the-fly, etc.) Marcel wrote a tool [3] which handles the basic config format. However, we're still missing a lot of details (only 3 offsets are known, "UART_CONFIG" contains 16 bytes but we only know the purpose of 4 of these, ...). I would highly appreciate if you give us enough details so we can extend Marcel's tool to display the human-readable representation of the config blobs from rtl8723bs_bt [0] and rtl8723ds_bt [1]. Vasily, thank you for your effort on this topic so far! If you keep me CC'ed on v2 of your series then I can test it on two of my Amlogic boards (which come with a RTL8723BS). [0] https://github.com/lwfinger/rtl8723bs_bt/tree/09eb91f52a639ec5e4c5c4c98dc2afede046cf20 [1] https://github.com/ayufan-pine64/rtl8723ds_bt/tree/fab21b52250d67857b694f961e1ff8618e678d89/8723D [2] https://github.com/khadas/android_hardware_realtek/tree/bd3b113266c353aafcbf528a0334d28090ff249b/rtkbt/system/etc/firmware [3] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/rtlfw.c?id=261948090e9073514ac4b5f64c8715cf0a71eafa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel