From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF69AC43381 for ; Tue, 5 Mar 2019 10:38:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7580F2082C for ; Tue, 5 Mar 2019 10:38:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DXY+jsyN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7580F2082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jp.panasonic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: From:Subject:To:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jSGY7co2jaIJaYelyovWypeyDWMlSO0TzJpv8x1ec94=; b=DXY+jsyNhSQYpb wuz89BhGY+AraIaKhFrE5IxA8sQ36/+CBJlRkJBkJ9aA1Bp9AxxozVbnoXxI9s2dggRSM3Q3ca3wf Z6CKNgwMgBj0f+9Fix2w43FDQ4DrNRvh8FRUmzS6BAytFTHB/nXgMrzufl/p2qLo9T14xjSR/aHJP ELEhHTYAY7Oqt5WErprPAu2ydx2tturvwQs+QWsbW2UI+Mc39939OGVLFe72askJNsPCwosKMfL9K QwYlWifnT4oil1eK0hwmIrtyplP4I0JOjdacnfD9KdDAMwfYCKgILOF8rBbm3My2wKLXepr7w3bFJ xD5g+eOoacmultmon+KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17Sh-0006Qu-Vm; Tue, 05 Mar 2019 10:38:15 +0000 Received: from smtp.mei.co.jp ([133.183.100.20]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17Se-0006QT-T0 for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 10:38:14 +0000 Received: from mail-gw.jp.panasonic.com ([157.8.1.157]) by smtp.mei.co.jp (8.14.4/8.14.4/lvzy12) with ESMTP id x25Ac8LE027627; Tue, 5 Mar 2019 19:38:08 +0900 Received: from epochmail.jp.panasonic.com ([157.8.1.130]) by mail.jp.panasonic.com (8.11.6p2/3.7W/kc-maili12) with ESMTP id x25Ac8t23814; Tue, 5 Mar 2019 19:38:08 +0900 Received: by epochmail.jp.panasonic.com (8.12.11.20060308/3.7W/pml-send2) id x25Ac8PR029497; Tue, 5 Mar 2019 19:38:08 +0900 Received: from jpa000secmn21.palet.jp.panasonic.com [10.74.216.56] by JPA000SGWMN05.palet.jp.panasonic.com with ESMTP id VAA27813; Tue, 5 Mar 2019 19:38:08 +0900 Received: from localhost (10.74.216.172) by JPA000SECMN21.palet.jp.panasonic.com (10.74.216.56) with Microsoft SMTP Server (TLS) id 15.0.1076.9; Tue, 5 Mar 2019 19:38:07 +0900 Date: Tue, 5 Mar 2019 19:38:05 +0900 Message-ID: <20190305.193805.2098843820562835621.okuno.kohji@jp.panasonic.com> To: Subject: Re: [PATCH v3] ARM: imx6q: cpuidle: fix bug that CPU might not wake up at expected time From: Kohji Okuno In-Reply-To: <20190304070656.GF26041@dragon> References: <20190222.174953.431124434951497467.okuno.kohji@jp.panasonic.com> <20190226023413.19531-1-okuno.kohji@jp.panasonic.com> <20190304070656.GF26041@dragon> Organization: Panasonic Corporation X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) MIME-Version: 1.0 X-Originating-IP: [10.74.216.172] X-ClientProxiedBy: JPA000SUMMN02.palet.jp.panasonic.com (10.74.216.25) To JPA000SECMN21.palet.jp.panasonic.com (10.74.216.56) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_023813_159984_A98BFBE0 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: s.hauer@pengutronix.de, okuno.kohji@jp.panasonic.com, linux-imx@nxp.com, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shawn, I found the fix of the same issue on linux-imx repository. Could you refer to the following? https://source.codeaurora.org/external/imx/linux-imx/commit/?h=imx_4.1.y_brillo&id=f739483488ef76979c06efea397237756bec45b9 Regarding the fix of cpuidle-imx6q.c, my fix is better, I think. But, we may also need to modify pm-imx6.c. # I cannot understand why they doesn't release their modifications. Best regards, Kohji Okuno Shawn Guo wrote: > On Tue, Feb 26, 2019 at 11:34:13AM +0900, Kohji Okuno wrote: >> In the current cpuidle implementation for i.MX6q, the CPU that sets >> 'WAIT_UNCLOCKED' and the CPU that returns to 'WAIT_CLOCKED' are always >> the same. While the CPU that sets 'WAIT_UNCLOCKED' is in IDLE state of >> "WAIT", if the other CPU wakes up and enters IDLE state of "WFI" >> istead of "WAIT", this CPU can not wake up at expired time. >> Because, in the case of "WFI", the CPU must be waked up by the local >> timer interrupt. But, while 'WAIT_UNCLOCKED' is set, the local timer >> is stopped, when all CPUs execute "wfi" instruction. As a result, the >> local timer interrupt is not fired. >> In this situation, this CPU will wake up by IRQ different from local >> timer. (e.g. broacast tiemr) > > s/tiemr/timer > >> >> So, this fix changes CPU to return to 'WAIT_CLOCKED'. >> >> Signed-off-by: Kohji Okuno > > Applied the patch with following Fixes tag. > > Fixes: e5f9dec8ff5f ("ARM: imx6q: support WAIT mode using cpuidle") > > Thanks for the fixing. > > Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel