From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 229CAC43381 for ; Tue, 5 Mar 2019 11:12:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E650920842 for ; Tue, 5 Mar 2019 11:12:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k3gPYJ/P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E650920842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IvXmJg7MaBZQnmUcEPiURXuTZjeAKClwREacLQ/2Q4c=; b=k3gPYJ/PTBYyif HdsKRE8llFYOQZuFyjtIVTbjr+9N0TuCbsxysNB61ZXX1LU5teQpbEB/bS4wXaZg6NuPlr8XbM/JY ms25YNzGELpLiVFubHFNfqEE1O/gRtG3CX3WPazt6pv7zynThh9kck6NV3TDNVgft487YW8mT4LHr nlJzRK0f4D573BwHRbrNrYE9aCaB8R3aCrSWkLFbdVMznyEDQG7HUpO7zBBPyRfN7DLV22aSVlYEJ Thb53jAqQ+j3SMff4H04qo0AmcrncCBLGszRIgSkqylUjOCpV+HGRGvULRPgw1mtYTSOcWd4HznBJ VolFV4Th5QGpHzhIVb1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17zM-0001oN-HB; Tue, 05 Mar 2019 11:12:00 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h17zH-0001lt-Th for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 11:11:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C4CC1596; Tue, 5 Mar 2019 03:11:55 -0800 (PST) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B09843F71D; Tue, 5 Mar 2019 03:11:53 -0800 (PST) Date: Tue, 5 Mar 2019 11:11:51 +0000 From: Dave Martin To: Amit Daniel Kachhap Subject: Re: [kvmtool PATCH v6 6/6] arm/kvm: arm64: Add a vcpu feature for pointer authentication Message-ID: <20190305111149.GK3567@e103592.cambridge.arm.com> References: <1550568271-5319-1-git-send-email-amit.kachhap@arm.com> <1550568271-5319-7-git-send-email-amit.kachhap@arm.com> <20190221155409.GA3567@e103592.cambridge.arm.com> <048f772a-1faf-5fa3-d82c-25212a5104af@arm.com> <20190301112452.GS16031@e103592.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_031155_981266_FFB8070A X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , Kristina Martsenko , Ramana Radhakrishnan , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 04, 2019 at 04:38:18PM +0530, Amit Daniel Kachhap wrote: > > Hi Dave, > > On 3/1/19 4:54 PM, Dave P Martin wrote: > >On Fri, Mar 01, 2019 at 10:37:54AM +0000, Amit Daniel Kachhap wrote: > >>Hi, > >> > >>On 2/21/19 9:24 PM, Dave Martin wrote: > >>>On Tue, Feb 19, 2019 at 02:54:31PM +0530, Amit Daniel Kachhap wrote: > > > >[...] > > > >>>>diff --git a/arm/aarch64/include/kvm/kvm-config-arch.h b/arm/aarch64/include/kvm/kvm-config-arch.h > >>>>index 04be43d..2074684 100644 > >>>>--- a/arm/aarch64/include/kvm/kvm-config-arch.h > >>>>+++ b/arm/aarch64/include/kvm/kvm-config-arch.h > >>>>@@ -8,7 +8,9 @@ > >>>> "Create PMUv3 device"), \ > >>>> OPT_U64('\0', "kaslr-seed", &(cfg)->kaslr_seed, \ > >>>> "Specify random seed for Kernel Address Space " \ > >>>>- "Layout Randomization (KASLR)"), > >>>>+ "Layout Randomization (KASLR)"), \ > >>>>+ OPT_BOOLEAN('\0', "ptrauth", &(cfg)->has_ptrauth, \ > >>>>+ "Enable address authentication"), > >>> > >>>Nit: doesn't this enable address *and* generic authentication? The > >>>discussion on what capababilities and enables the ABI exposes probably > >>>needs to conclude before we can finalise this here. > >>ok. > >>> > >>>However, I would recommend that we provide a single option here that > >>>turns both address authentication and generic authentication on, even > >>>if the ABI treats them independently. This is expected to be the common > >>>case by far. > >>ok > >>> > >>>We can always add more fine-grained options later if it turns out to be > >>>necessary. > >>Mark suggested to provide 2 flags [1] for Address and Generic > >>authentication so I was thinking of adding 2 features like, > >> > >>+#define KVM_ARM_VCPU_PTRAUTH_ADDR 4 /* CPU uses pointer address > >>authentication */ > >>+#define KVM_ARM_VCPU_PTRAUTH_GENERIC 5 /* CPU uses pointer generic > >>authentication */ > >> > >>And supply both of them concatenated in VCPU_INIT stage. Kernel KVM > >>would expect both feature requested together. > > > >Seems reasonable. Do you mean the kernel would treat it as an error if > >only one of these flags is passed to KVM_ARM_VCPU_INIT, or would KVM > >simply treat them as independent? > If both flags are passed together then only start using ptrauth otherwise > keep ptrauth disabled. This is just to finalize the user side abi as of now > and KVM can be updated later. If just flag is passed, I think KVM_ARM_VCPU_INIT should just fail. Otherwise we risk userspace becoming accidentally reliant on behaviour that may change in the future. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel