From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7B6C43381 for ; Sat, 9 Mar 2019 04:03:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63B1320866 for ; Sat, 9 Mar 2019 04:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dbuk0q1f"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="b7zJ9O1W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63B1320866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=umn.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=PGrm1XABP4hV5c/LxI8LafxH1ebFan2PzKMNmPe6jJ0=; b=dbu k0q1fR90bHVOxJxqhL2tRWk0SmGAu8VrmH28o7LuROhQ0I1pd3SKIclvO/hrW6LoANXLjlK46Ltx+ i05p5kGZx8LOSOHAakdMsnbce2SCQfQJkknU5iWe5kD3iWCql48JwOl3xSRdTO/C95B51Gb4i2Z/E BcUTKrSTExBKh9ABHjdePY1k8ot2w0ASuwaDGVxcgnRNPCHaCFiUTrF4JAjSTi4Z1MtKtEjk26qYm HTJdDqatVACTXNJ8SqDc7FXwm1XsdewFzGvSdoVlKPXYKOBpLLXwVusQzqajPYfo8T2yHiuq1w0ME lAQeKf5rRwUhxJAii725BOHF9Pzodkw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2TCU-0006aC-4s; Sat, 09 Mar 2019 04:03:06 +0000 Received: from mta-p8.oit.umn.edu ([134.84.196.208]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2TCQ-0006Yi-Bx for linux-arm-kernel@lists.infradead.org; Sat, 09 Mar 2019 04:03:03 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id E1276A2B for ; Sat, 9 Mar 2019 04:02:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k8CddEiQeaFs for ; Fri, 8 Mar 2019 22:02:50 -0600 (CST) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id BBD2084F for ; Fri, 8 Mar 2019 22:02:50 -0600 (CST) Received: by mail-it1-f197.google.com with SMTP id a184so8254634itc.0 for ; Fri, 08 Mar 2019 20:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=Og6l9fJCMlQv3m4hn4Y5g8y+/yXp1JLZDjMGF/Nf2UU=; b=b7zJ9O1WD2t45JUUZEShzGlXyjvMY2eIgF5rPmC9atuzraoFtef4eZq+P0xZciP4Vq oMxkpTwF+G2Rkb28Mw7eBZPIqAp8sjqqi1H7qFLh1m+TkKVyG+QOJNkt4+91HNpFHyhC 7n7DLKMPCTpS9guKfxapPawtART/bEy8w9XCLVRTUs3HMLivPg8g/9NTx3ASC7fMNli/ w9vXEGnzBv4NiB/xT1Hm62JaWSS8R289vx89S+gjYqaKoR6Ja4de8Bj9pdp+JtUMaaTp 9wNGOfIBvjDdFmQWTm0pKaXZ2dWrzASmQbvsjgohnTORIars4BxJdpTk/4B0t+x6VSwD wvBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Og6l9fJCMlQv3m4hn4Y5g8y+/yXp1JLZDjMGF/Nf2UU=; b=gYbYIdTh1qJ7NrbIIN09erWUXgHZ2U3VHjIF16GiHweAx+dtSCHpvNxWm/shtCROWv hb0UvSBCAI5mgm8Kna/xf6mb/9zRzzt1UePH3ccMGkaUrBkEK+cl+wJdGqFGM82dE2/u MVnzMtgZNJicDvBcg605o2RLKkQrF88HYIM17xHH7mzRH0LqtgKpHsRLRJ0qXT8g4fNS Jt9SUyJDZbfsvoT58bb3eFNzX4Xe/SmefOZt7LMThMrcnQ7ieNO7sddWdIFPNB8c7El5 l7lJqIRfx3UsVtN3jyKLmM2F1/pyZZgkR2juf+9cH/KvTjicr9Jw7Q/OkR/dZfX2HrIE rNcg== X-Gm-Message-State: APjAAAXBYUOSIVvgHwCEfeDJ4KP03UIvX2uwXiNtLhs28KInzJUTJacH YRK43iHbZkvqf0OAbqZpE88WeMHaQudRfNpzs356mcwEwA/pYBKoWc2491O4X2Byw38wJFI+c/6 zjDksCg6oLuyvIjsRAc5+ziCjKQh4zxIu7oTseIE= X-Received: by 2002:a5d:980c:: with SMTP id a12mr12631908iol.58.1552104170251; Fri, 08 Mar 2019 20:02:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyjtKqJscT99MA53yJupAUypXIuFOTy85wFNZIRArCRneUmf6co+/Daa6dg6b0XyN8vrj+d1Q== X-Received: by 2002:a5d:980c:: with SMTP id a12mr12631897iol.58.1552104170006; Fri, 08 Mar 2019 20:02:50 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id y3sm5031683itb.2.2019.03.08.20.02.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 20:02:49 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] firmware: arm_scmi: check return value of idr_find Date: Fri, 8 Mar 2019 22:02:39 -0600 Message-Id: <20190309040239.32431-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_200302_446341_5FCDF5F7 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pakki001@umn.edu MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org idr_find may return NULL, so check its return value and return an error code. Signed-off-by: Kangjie Lu --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 8f952f2f1a29..35faa203d549 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -709,6 +709,8 @@ scmi_mbox_chan_setup(struct scmi_info *info, struct device *dev, int prot_id) if (scmi_mailbox_check(np)) { cinfo = idr_find(&info->tx_idr, SCMI_PROTOCOL_BASE); + if (!cinfo) + return -EINVAL; goto idr_alloc; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel