From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537FFC43381 for ; Thu, 14 Mar 2019 12:15:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2243220854 for ; Thu, 14 Mar 2019 12:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mSUuFvhU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GGJbpjxB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2243220854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NwpYuvRWMs/lEBJJVAzy7Y/2aIrFZLk55aRJM0DkbLg=; b=mSUuFvhUW4PoTs 7hVvOghVUjE4sB+zST36ZqGmAiQejvVc56fTtupuqG/WR4njUosYgmUPMXgPmnZu+HwSQkyLYNnYa 2KnRCOY1JYefBwi7CWV8GVyFuJuyhDl1ka/XjNE96ZaofiStrSoAKHg0N96ZKIhZSPj2W9v/9xue5 opwE0KKSnhTOcABooEKY7knrPo31nAzfN0cijlEfG7cTWS4USA064Z/RMVhupNLjX14diK753AJ6u 5M1vAiOROGhOx+ci3tdZwzeFiSUhchorlLqL/32K0jc36jXwAyfTtF0C0FkMAeKSbx1OHc8IGCBr+ DHFXnfeoVU850MCozP7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PH3-00083P-I1; Thu, 14 Mar 2019 12:15:49 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4PH1-000831-2x for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 12:15:48 +0000 Received: by mail-wr1-x443.google.com with SMTP id h99so5574612wrh.12 for ; Thu, 14 Mar 2019 05:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P8Musrq+Zf+Vn7QYOvAJ2kgQ4P8kl8oepHXj9wkd3GA=; b=GGJbpjxB7uPfBqHRz/ucVfC1craEJiLjv6ESissugbbKUE5jF75Cg5PDhH3kamtnS9 dFY4dGb9fxqD8D7aMhmyY1i0qVay1r2TK8fsssUWIsTLIlcfew+rCpBEFa8yvr1UhDkM mJEzD/DJR60fl5oY5gOKB5m4+EZ1tb0i5qwrJPLDN7HtNDbZlHlEWiQjmAMmT20Prl4R 1KpR9nojkwpm+IOfCFk+ilW6u1O9KjACz+oxUHuZWBNtyL2hCe2pJiIY+nO06LXK2d3x UDokWQtmR9ThGVefQauo2Q3rhlfS2JufOF+H4Y1bUnQO+5MlW5dfOnGbX91uTp/QTDtp HAhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P8Musrq+Zf+Vn7QYOvAJ2kgQ4P8kl8oepHXj9wkd3GA=; b=BX4W7A8U9LU50FHJeJjOIzyzEoxcDaUHtyiwz2PssQTQ5gOfVvGnf5REQmIMG7Nz0B 09IrGZDF8pJiE5N/bcIL3XA+AEOlmXBSJqFmYuLVHvb95WXCZXeDsGoIg/WuUbKDvf4m tAlgFKvVQ8mXjLexN8HkdYdOvScroqf+EvZ7FmtooS8EJ8HYYt6G4BK+g+wgkgK2QeNd OxLkXb+55UfmKc88dLyVswT4JUsF1MZ9yZ2e0j5+pFveIxt3QrR4YYl2dGHQiREAgf41 6AYmuxy0IXgs/1kZpxMBsdNvh5FiDKOciomLKDXbnSFCmMglOjM1ac7DfnZEofd1FqRx HXrg== X-Gm-Message-State: APjAAAXAmzSIEW4PJJ0cfcWjX8ZMehIYGNXxKqNtDiHnbLVbuh2PRGYG q2atfCz+C6t2xygDZhD9oVxYCg== X-Google-Smtp-Source: APXvYqyIKACOcbNCjO/NnBPLjcHRAhMfJhnAqlC++nMC5MUv1Jm9vyeCd2PDhOjydD6d04wPCcdxBQ== X-Received: by 2002:a5d:464b:: with SMTP id j11mr24102376wrs.307.1552565745062; Thu, 14 Mar 2019 05:15:45 -0700 (PDT) Received: from apalos (ppp-94-64-206-130.home.otenet.gr. [94.64.206.130]) by smtp.gmail.com with ESMTPSA id o127sm1856038wmo.20.2019.03.14.05.15.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 05:15:44 -0700 (PDT) Date: Thu, 14 Mar 2019 14:15:41 +0200 From: Ilias Apalodimas To: Gregory CLEMENT Subject: Re: [PATCH] clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks Message-ID: <20190314121541.GB19385@apalos> References: <20190313163558.6705-1-gregory.clement@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190313163558.6705-1-gregory.clement@bootlin.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_051547_136834_909D0C3B X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Vincent Guittot , Jason Cooper , linux-pm@vger.kernel.org, Antoine Tenart , Viresh Kumar , Mike Turquette , Christian Neubert , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Maxime Chevallier , Stephen Boyd , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Gregory, > The clock parenting was not setup properly when DVFS was enabled. It was > expected that the same clock source was used with and without DVFS which > was not the case. > > This patch fixes this issue, allowing to make the cpufreq support work > when the CPU clocks source are not the default ones. > > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > Cc: > Reported-by: Christian Neubert > Reported-by: Ilias Apalodimas > Signed-off-by: Gregory CLEMENT > --- > drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c > index 1f1cff428d78..26ed3c18a239 100644 > --- a/drivers/clk/mvebu/armada-37xx-periph.c > +++ b/drivers/clk/mvebu/armada-37xx-periph.c > @@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(const struct clk_periph_data *data, > map = syscon_regmap_lookup_by_compatible( > "marvell,armada-3700-nb-pm"); > pmcpu_clk->nb_pm_base = map; > + > + /* > + * Use the same parent when DVFS is enabled that the > + * default parent received at boot time. When this > + * function is called, DVFS is not enabled yet, so we > + * get the default parent and we can set the parent > + * for DVFS. > + */ > + if (clk_pm_cpu_set_parent(muxrate_hw, > + clk_pm_cpu_get_parent(muxrate_hw))) > + dev_warn(dev, "Failed to setup default parent clock for DVFS\n"); > } > > *hw = clk_hw_register_composite(dev, data->name, data->parent_names, > -- > 2.20.1 > Applied this and selected only CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y CONFIG_CPU_FREQ_GOV_PERFORMANCE=y CONFIG_CPU_FREQ_GOV_POWERSAVE=y After changing the governor from 'powersave' to 'performance' the board completely froze (i even lost access to the serial port) Cheers /Ilias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel