From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2C6C43381 for ; Thu, 14 Mar 2019 13:44:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C83E22184C for ; Thu, 14 Mar 2019 13:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vh4A8B5R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wPmOucFG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C83E22184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EMjUP+UJtFX1D4s4dDfRceSZkMNIgs8+gIKWA/s3Sf4=; b=Vh4A8B5RpGOXcB ayCQDqTpGqNygzMRkjihR0yzdxl03NnRIyJiZmP5I+i+G7e8iUIj3ZrtO+qWedlMvr9fbhzndEToq MHGxDDbu/FWztG2ui2KtxDl3rYOhcxDELlWMwkKqHu3P2W0UsQ44qo8v4J4Y9uCDgkaMVi9mzYYEj j41yKFyGoLx0Gwonr5CWP9PRlawwaLEzHCYVG77zQUnIBh4NZrDCeyCe6aWZJLcR9uywuQKVHVh2k vNAlpqh0bzufcSKSTfz5i9orJqybu31zTcJcrP+Z267wKtEPMaEXaxjJBm4slY/exhfh9valKS+VN frS1Tqd3+4On6TMsGvHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Qez-00018f-W5; Thu, 14 Mar 2019 13:44:38 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Qex-000184-7Q for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2019 13:44:36 +0000 Received: by mail-wm1-x343.google.com with SMTP id e74so3037515wmg.3 for ; Thu, 14 Mar 2019 06:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nAygQuAN2Ep1RjNQH8Rkl+EGXN+NRu9th/af/xku6Hw=; b=wPmOucFGhini30TBE5fO8WK3lmlOXRHHp0QmRy7hOh7jvdj/9z5/CGRrwX3QKb1v7g u8M1JKIDECHzWNmMu5h43r9onVsmOM7+7b7cLC9Ce1PfS/pbqe7VCXlVuo5a57el9HJF SkvXr6aEtSGzPk6kb01bPFhZz0Z/g6pYu1wmYpUI4L0Ri7ydvkDui4KMrhSz+M3vVCMe 2LAtYNt9Ez5mJa0jW2XJV+usGoiOebW8fyuHPe7VL4GzyggPNhtAdlAuEikCAmlfKQR2 r/H+hjOBAXAixgkcIrEggVUY7TeEEqophqWE8otxmluxM/dZlqP7a5fQQHuexvVGet1A KjzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nAygQuAN2Ep1RjNQH8Rkl+EGXN+NRu9th/af/xku6Hw=; b=I7ixZrn6lSkQuMdh0pYu7aA0PJcSn1iVGGMImBqI0axivHpuf7dEUEPprWiKdrlUiV ayu68+osG0YUgjNG0hoIWCxKR4UM4EsFJFMeGIUXnbMFQiVc8P3iACGxah60u4Y7os2f rMuBq0/HbBIj9YBYru08ADVIQBYsKGhmYnyu1uKhk6zcZPmZTCY+dIh/RgnAeur4qE6B 5hmPWBjRj88YbP6v1wRwFYf37xZ0cJYqnHH50apUWydE2arduLHOzueGUSfZb9Jwvlax t+zKnCmCMazEX2WPmUjXMc7iDGWa+RVvJvKljNiMisqllAqPrlvek5nwSF7DqfVtv3fO wdLw== X-Gm-Message-State: APjAAAXktn4Qb3CvG0txm6Rp/K5NRJgn32cBWmQOCfUm+TjEK4TJwM3v TNwR7RN7siR2GdUJA+9RcXZj8g== X-Google-Smtp-Source: APXvYqzTyFinBnIUlxzhh36lZ4klfslF6Yc0OOGn0mwwwCmk43k3j278ceSgykV+h9S1kEgPikMzPw== X-Received: by 2002:a1c:7ec2:: with SMTP id z185mr2815639wmc.69.1552571072332; Thu, 14 Mar 2019 06:44:32 -0700 (PDT) Received: from apalos (ppp-94-64-206-130.home.otenet.gr. [94.64.206.130]) by smtp.gmail.com with ESMTPSA id a82sm2427548wmf.11.2019.03.14.06.44.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 06:44:31 -0700 (PDT) Date: Thu, 14 Mar 2019 15:44:28 +0200 From: Ilias Apalodimas To: Christian Neubert Subject: Re: [PATCH] clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks Message-ID: <20190314134428.GA24768@apalos> References: <20190313163558.6705-1-gregory.clement@bootlin.com> <20190314121541.GB19385@apalos> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_064435_273090_75BCF3A9 X-CRM114-Status: GOOD ( 25.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Vincent Guittot , Jason Cooper , linux-pm@vger.kernel.org, Antoine Tenart , Stephen Boyd , Gregory CLEMENT , =?iso-8859-1?Q?Miqu=E8l?= Raynal , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni , Viresh Kumar , Maxime Chevallier , Mike Turquette , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Christian, > Hi, > = > I assume you use the 1000 MHz firmware. This does also not work on my Rev= 7 > board. But I'm pretty sure this is not a problem of the patches, because = if > I take a newer kernel (4.19.20/27) without the patches it also does not > work. A kernel 4.19.17 does work for me. My opinion on that is that this = is > another problem which does just occure now because now the cpu frequency > scaling is working with the right frequencies. I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches Regards /Ilias > = > Ilias Apalodimas schrieb am Do., 14. M=E4rz > 2019, 13:15: > = > > Hi Gregory, > > > The clock parenting was not setup properly when DVFS was enabled. It = was > > > expected that the same clock source was used with and without DVFS wh= ich > > > was not the case. > > > > > > This patch fixes this issue, allowing to make the cpufreq support work > > > when the CPU clocks source are not the default ones. > > > > > > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > > > Cc: > > > Reported-by: Christian Neubert > > > Reported-by: Ilias Apalodimas > > > Signed-off-by: Gregory CLEMENT > > > --- > > > drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/clk/mvebu/armada-37xx-periph.c > > b/drivers/clk/mvebu/armada-37xx-periph.c > > > index 1f1cff428d78..26ed3c18a239 100644 > > > --- a/drivers/clk/mvebu/armada-37xx-periph.c > > > +++ b/drivers/clk/mvebu/armada-37xx-periph.c > > > @@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(const > > struct clk_periph_data *data, > > > map =3D syscon_regmap_lookup_by_compatible( > > > "marvell,armada-3700-nb-pm"); > > > pmcpu_clk->nb_pm_base =3D map; > > > + > > > + /* > > > + * Use the same parent when DVFS is enabled that the > > > + * default parent received at boot time. When this > > > + * function is called, DVFS is not enabled yet, so we > > > + * get the default parent and we can set the parent > > > + * for DVFS. > > > + */ > > > + if (clk_pm_cpu_set_parent(muxrate_hw, > > > + > > clk_pm_cpu_get_parent(muxrate_hw))) > > > + dev_warn(dev, "Failed to setup default parent > > clock for DVFS\n"); > > > } > > > > > > *hw =3D clk_hw_register_composite(dev, data->name, > > data->parent_names, > > > -- > > > 2.20.1 > > > > > Applied this and selected only > > > > CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=3Dy > > CONFIG_CPU_FREQ_GOV_PERFORMANCE=3Dy > > CONFIG_CPU_FREQ_GOV_POWERSAVE=3Dy > > > > After changing the governor from 'powersave' to 'performance' the board > > completely froze (i even lost access to the serial port) > > > > Cheers > > /Ilias > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel