From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D895C43381 for ; Fri, 15 Mar 2019 13:46:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DCE1217F5 for ; Fri, 15 Mar 2019 13:46:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OCroprSt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DCE1217F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vGEkPiI2injkr7m9K9zxlHNzuyqwDSz5pbFJttkshWo=; b=OCroprStC66Eat/9DXtkh6vz/ xQFTlVCvEUSv28v8x3JQIAYcJCLmrAc3mJl65LMn155JB/Se1um5OWXGsXynC44CB0ROu+LcDO1R9 xWpX1cBD6fOgdgmsNxq3shblVBF8N/iRsR4whqfLCnxej6vs/okF88dLfyT3x2ou7wCi/IysrTkt5 Q85EFUb5CufPTlkU0WDLKGJsK2ZP4DWLFIea31aAEaiR3Ul/vmAlGoNc4QFxpt1IYi2oVl0JkGmgK w2N3qeEOJxTL1nVtZm5hG0HrrlxLGwRfVhHEFc3jw1B7o1KEoIVbh7bJ9+BN6LiJPE19ZUmg/KM3y NTRWqG3Sg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4nA1-0000pO-6v; Fri, 15 Mar 2019 13:46:09 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4n9x-0000p2-QE for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 13:46:07 +0000 X-Originating-IP: 90.88.22.102 Received: from localhost (aaubervilliers-681-1-80-102.w90-88.abo.wanadoo.fr [90.88.22.102]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 78E84FF807; Fri, 15 Mar 2019 13:45:55 +0000 (UTC) Date: Fri, 15 Mar 2019 14:45:55 +0100 From: Maxime Ripard To: Paul Kocialkowski Subject: Re: [linux-sunxi] [PATCH 3/6] drm/sun4i: dsi: Add bridge support Message-ID: <20190315134555.ekpywymjx3xqmdhf@flea> References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-4-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_064606_154681_B0C78959 X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Chen-Yu Tsai , Rob Herring , jagan@amarulasolutions.com, Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org, Laurent Pinchart Content-Type: multipart/mixed; boundary="===============0326770567108295090==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0326770567108295090== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pswiqfcemuf43jfz" Content-Disposition: inline --pswiqfcemuf43jfz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2019 at 02:32:55PM +0100, Paul Kocialkowski wrote: > Hi, >=20 > On Fri, 2019-03-15 at 18:38 +0530, Jagan Teki wrote: > > Some display panels would come up with a non-DSI output which > > can have an option to connect DSI interface by means of bridge > > convertor. > >=20 > > This DSI to non-DSI bridge convertor would require a bridge > > driver that would communicate the DSI controller for bridge > > functionalities. > >=20 > > So, add support for bridge functionalities in Allwinner DSI > > controller. >=20 > See a few comments below. >=20 > > Signed-off-by: Jagan Teki > > --- > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 65 +++++++++++++++++++------- > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 1 + > > 2 files changed, 49 insertions(+), 17 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/s= un4i/sun6i_mipi_dsi.c > > index 0960b96b62cc..64d74313b842 100644 > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > @@ -781,6 +781,9 @@ static void sun6i_dsi_encoder_enable(struct drm_enc= oder *encoder) > > if (!IS_ERR(dsi->panel)) > > drm_panel_prepare(dsi->panel); > > =20 > > + if (!IS_ERR(dsi->bridge)) > > + drm_bridge_pre_enable(dsi->bridge); > > + > > /* > > * FIXME: This should be moved after the switch to HS mode. > > * > > @@ -796,6 +799,9 @@ static void sun6i_dsi_encoder_enable(struct drm_enc= oder *encoder) > > if (!IS_ERR(dsi->panel)) > > drm_panel_enable(dsi->panel); > > =20 > > + if (!IS_ERR(dsi->bridge)) > > + drm_bridge_enable(dsi->bridge); > > + > > sun6i_dsi_start(dsi, DSI_START_HSC); > > =20 > > udelay(1000); > > @@ -812,6 +818,9 @@ static void sun6i_dsi_encoder_disable(struct drm_en= coder *encoder) > > if (!IS_ERR(dsi->panel)) { > > drm_panel_disable(dsi->panel); > > drm_panel_unprepare(dsi->panel); > > + } else if (!IS_ERR(dsi->bridge)) { > > + drm_bridge_disable(dsi->bridge); > > + drm_bridge_post_disable(dsi->bridge); > > } > > =20 > > phy_power_off(dsi->dphy); > > @@ -973,11 +982,16 @@ static int sun6i_dsi_attach(struct mipi_dsi_host = *host, > > struct sun6i_dsi *dsi =3D host_to_sun6i_dsi(host); > > =20 > > dsi->device =3D device; > > - dsi->panel =3D of_drm_find_panel(device->dev.of_node); > > - if (IS_ERR(dsi->panel)) > > - return PTR_ERR(dsi->panel); > > =20 > > - dev_info(host->dev, "Attached device %s\n", device->name); > > + dsi->bridge =3D of_drm_find_bridge(device->dev.of_node); > > + if (!dsi->bridge) { >=20 > You are using IS_ERR to check that the bridge is alive in the changes > above, but switch to checking that it's non-NULL at this point. >=20 > Are both guaranteed to be interchangeable? They aren't. Any ERR_PTR will be !NULL > > + dsi->panel =3D of_drm_find_panel(device->dev.of_node); > > + if (IS_ERR(dsi->panel)) > > + return PTR_ERR(dsi->panel); > > + } >=20 > You should probably use drm_of_find_panel_or_bridge instead of > duplicating the logic here. Or we can even use the drm_panel_bridge_add to simplify things. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --pswiqfcemuf43jfz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIuskgAKCRDj7w1vZxhR xe0MAP4wC7EmToXTIAr2uOVsRai2Km5NXRQqLmWuFt7WTBh5PQD7BrjuxRRWuADu 6AhK0aD8Oy8jtGOk+S5TYlOvOMVv3wI= =qwPR -----END PGP SIGNATURE----- --pswiqfcemuf43jfz-- --===============0326770567108295090== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0326770567108295090==--