From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF7FC43381 for ; Fri, 22 Mar 2019 22:25:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57CE5218B0 for ; Fri, 22 Mar 2019 22:25:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OvMVtJNu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57CE5218B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+xbo/e3UZGYDpvupKErIxJUTRqJwjyaBfWIbhKPGEl4=; b=OvMVtJNu352ZrX CmY2JsYguZw9tNuXSfHXnq3oSyA8adnSBO4CI1/cSqck0w1IwwgMLzTnuCIhyCFo7LALV2HO1HpU3 jpH9vDqZRz5l7igxuNEOeZbBPfrQvr6zUITD6BCJp8yDyE/Ia3NJLpHg8dkMVTFLcUx27+U3wydxo LTMwYp8A/R9Z7DoHjCEZk1Lx0g5kmNFoNVziFriQzDIaPr0ah5SmXg1LC679V89YN1BefHD2Ifgcs UAcrrcQqkjZ3npKEhK6I5ARf7uV+Ez/ouerqxEI2NqEILP8LALQvakCF4OWFzo+nVTuRbbASt6q1X J0hLLgumKQbGa8NAn2iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7Sb0-0003qO-AO; Fri, 22 Mar 2019 22:25:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7Saw-0003p9-5h for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2019 22:25:00 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 50CE580DB; Fri, 22 Mar 2019 22:25:11 +0000 (UTC) Date: Fri, 22 Mar 2019 15:24:54 -0700 From: Tony Lindgren To: Julia Lawall Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available Message-ID: <20190322222454.GJ19425@atomide.com> References: <1550928043-14889-1-git-send-email-Julia.Lawall@lip6.fr> <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.11.2 (2019-01-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190322_152458_252231_B256F886 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Julia Lawall [190223 13:58]: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_node_put(e) > when != x = e > when != e = x > when any > if (<+...of_device_is_available(e)...+>) { > ... when != of_node_put(e) > ( > return e; > | > + of_node_put(e); > return ...; > ) > } > // > > Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver") > Signed-off-by: Julia Lawall Thanks applying this one into omap-for-v5.1/fixes. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel