From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
Andrew Jeffery <andrew@aj.id.au>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] rtc: Add ASPEED RTC driver
Date: Mon, 25 Mar 2019 15:59:54 +0100 [thread overview]
Message-ID: <20190325145954.GM30105@piout.net> (raw)
In-Reply-To: <20190325133159.10653-3-joel@jms.id.au>
Hi,
This seems mostly good to me.
On 26/03/2019 00:01:59+1030, Joel Stanley wrote:
> + dev_dbg(dev, "%s: %4d-%02d-%02d %02d:%02d:%02d\n", __func__,
> + 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
> + tm->tm_hour, tm->tm_min, tm->tm_sec);
> +
We now have %ptR, could you use that?
> + rtc->rtc_dev->ops = &aspeed_rtc_ops;
> + rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900;
> + rtc->rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */
> +
I'm curious how many RTC have been properly designed, could you run
rtc-range?
https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc-range.c
Thanks!
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:31 [PATCH v2 0/2] rtc: Add ASPEED RTC driver Joel Stanley
2019-03-25 13:31 ` [PATCH v2 1/2] dt-bindings: rtc: Add on-chip ASPEED RTC documentation Joel Stanley
2019-03-25 13:31 ` [PATCH v2 2/2] rtc: Add ASPEED RTC driver Joel Stanley
2019-03-25 14:59 ` Alexandre Belloni [this message]
2019-03-25 15:28 ` Joel Stanley
2019-03-25 15:43 ` Alexandre Belloni
2019-03-25 16:10 ` Alexandre Belloni
2019-03-27 1:00 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325145954.GM30105@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).