From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2547FC43381 for ; Tue, 26 Mar 2019 23:40:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E613120811 for ; Tue, 26 Mar 2019 23:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AvGugbx+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E613120811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rWIri3BGQHNWAEF3gmVEqZnGMucKUgX2RmbYMwvlwSY=; b=AvGugbx+je6B3V OLtMHQ0Q0VqSdaEUcosakUSuJHuxmDCf9nkw13h4rAr3gjX/4q/ksl8m5Z8PGUXaKvYLXK+NVQICs WrBOKNHcvI+TjhCSsR+dUrSIVnDHiPAl3Vqrl0neb68Zgt4RnVaJjjoCJ0CoymMN5vov5caBplofb PfxM9Xi8Wvc+baQQSebbE9xlSW5QJhH3eVko/VUgkx1dT+A6qu06nUNTmk4PDmyuJy5qwvAgfmdTK IorLlVjR2ahTxtQxWUcG1ky43slm60a2rM2mQLLHvJuE+sSgkNKHB3iw5CION6kFK1NDkFBJ9ERs2 q57rwKv4iWPte3SDCc4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8vgR-0000JV-0j; Tue, 26 Mar 2019 23:40:43 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8vgB-0000IS-GL for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 23:40:37 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1959C8030; Tue, 26 Mar 2019 23:40:38 +0000 (UTC) Date: Tue, 26 Mar 2019 16:40:22 -0700 From: Tony Lindgren To: Suman Anna Subject: Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later Message-ID: <20190326234022.GD49658@atomide.com> References: <20190325215849.13182-1-tony@atomide.com> <20190325215849.13182-10-tony@atomide.com> <20190326231306.GC49658@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_164032_320614_AEE108D6 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Dave Gerlach , Keerthy , linux-kernel@vger.kernel.org, Peter Ujfalusi , Faiz Abbas , Greg Kroah-Hartman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Suman Anna [190326 23:22]: > On 3/26/19 6:13 PM, Tony Lindgren wrote: > Hmm, are you envisioning the SYSC reset (OCP SoftReset) here or the PRCM > RSTCTRL hardresets here? The latter in general requires the clocks to be > running first (module won't be in ready status until you deassert the > hardresets with clocks running). You can look up the Warm-reset or > Cold-reset sequences in the TRMs for any of the processors. That's for rstctrl. I just did a quick test with my earlier reset-simple patch and I noticed sgx on am33xx produces a clock error unless we deassert it's rstrctrl before enabling clocks first: gfx-l3-clkctrl:0004:0: failed to enable > I am working on preparing the next version of PRUSS patches with ti-sysc > on AM33xx/AM437x/AM57xx platforms, so will pick up these patches for my > testing. OK great, yes please check and test with your rstctrl use case. I guess you still need to use the reset-simple patch for now until we have a proper prm rstctrl driver. Note that you probably also want to leave out the struct omap_hwmod data from omap_hwmod_*_data.c files with rstctrl entries. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel