From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3322C43381 for ; Wed, 27 Mar 2019 13:51:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEBF2075E for ; Wed, 27 Mar 2019 13:51:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uHHPGjjV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DEBF2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5ohMxfaWjGwao3YlIKxpKiboCb8jgCuu4F+Ixl/M+iQ=; b=uHHPGjjVj4hZA9 MuG9zy2M8YV859DAZt0gcqp64KEIpoIDba7IwmF45oF8aPXn6fe+kumwLZgyzbZjtOJuBJhuw/Ufa TdoKYNbA/t0W8EIj+W3jTqdWC7T3vYueS/XoL5AM2XGoGhPk2Vec1qVM4J4S7l8W1BV2HTV9UdjDT n4lFLZgZHqqH08fp1DTHOGXxLE0YIN6dZyYNh1IGOWfV5A7pIP5qrqzzymMjFhbUthK7cnjgTTnEy L5cv7UvMYcz7AFpoMI9qY0HX/S0z7WncT4hPIxD71hC98BuEbYVkoJBH3//EDsXInqzaHeUI/gLWa Z+Byf6TKpERdGnof/LKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h98xT-0002Eo-24; Wed, 27 Mar 2019 13:51:11 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h98xP-0002Dt-OW for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 13:51:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2649680D; Wed, 27 Mar 2019 06:51:03 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BEB93F59C; Wed, 27 Mar 2019 06:51:01 -0700 (PDT) Date: Wed, 27 Mar 2019 13:50:59 +0000 From: Dave Martin To: Amit Daniel Kachhap Subject: Re: [PATCH v7 9/10] KVM: arm64: docs: document KVM support of pointer authentication Message-ID: <20190327135058.GW3567@e103592.cambridge.arm.com> References: <1552984243-7689-1-git-send-email-amit.kachhap@arm.com> <1552984243-7689-10-git-send-email-amit.kachhap@arm.com> <23e4a9d4-e9e1-2c1f-32ce-e7fd96080437@arm.com> <20190327104428.GV3567@e103592.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_065107_799935_2E42C729 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Kristina Martsenko , Ramana Radhakrishnan , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2019 at 05:19:28PM +0530, Amit Daniel Kachhap wrote: > Hi, > > On 3/27/19 4:14 PM, Dave Martin wrote: > >On Mon, Mar 25, 2019 at 08:05:49PM +0000, Kristina Martsenko wrote: > >>On 19/03/2019 08:30, Amit Daniel Kachhap wrote: > >>>This adds sections for KVM API extension for pointer authentication. > >>>A brief description about usage of pointer authentication for KVM guests > >>>is added in the arm64 documentations. > >>> > >>>Signed-off-by: Amit Daniel Kachhap > >>>Cc: Mark Rutland > >>>Cc: Christoffer Dall > >>>Cc: Marc Zyngier > >>>Cc: kvmarm@lists.cs.columbia.edu > >> > >>I think it makes sense to also update the Kconfig symbol description for > >>CONFIG_ARM64_PTR_AUTH, since it currently only mentions userspace > >>support, but now the option also enables KVM guest support. > >> > >>It's also worth mentioning that CONFIG_ARM64_VHE=y is required for guest > >>support. > > > >Is it worth making this dependency explicit in Kconfig? > Currently there is discrepancy that userspace supports ptrauth in both > nVHE/VHE mode and KVM guest only in VHE mode. I suppose adding explicit > dependency flag here makes both of them similar. Looking at the history, for SVE this Kconfig restriction has always been present. Since ptrauth initially upstreamed without an equivalent restriction in Kconfig, adding it now could be seen as a regression. So, maybe it's not worth it here. You could add a separate option, say config ARM64_PTR_AUTH_KVM bool "Pointer authentication support for KVM guests" default y depends on ARM64_PTR_AUTH && ARM64_VHE && KVM ...but that may be overkill. Cheers, ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel