From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>,
"srv_heupstream@mediatek.com" <srv_heupstream@mediatek.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fan.chen@mediatek.com" <fan.chen@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 4/4] devfreq: add mediatek cci devfreq
Date: Mon, 01 Apr 2019 13:18:43 +0900 [thread overview]
Message-ID: <20190401041843epcms1p10a664023cf0556e42afe118a1d84daad@epcms1p1> (raw)
In-Reply-To: <1553841972-19737-5-git-send-email-andrew-sh.cheng@mediatek.com>
>This adds a devfreq driver for the Cache Coherent Interconnect (CCI)
>of the Mediatek MT8183.
>
>On the MT8183 the CCI is supplied by the same regulator as the LITTLE
>cores. The driver is notified when the regulator voltage changes
>(driven by cpufreq) and adjusts the CCI frequency to the maximum
>possible value.
>
>Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
>---
> drivers/devfreq/Kconfig | 10 ++
> drivers/devfreq/Makefile | 1 +
> drivers/devfreq/mt8183-cci-devfreq.c | 235 +++++++++++++++++++++++++++++++++++
> 3 files changed, 246 insertions(+)
> create mode 100644 drivers/devfreq/mt8183-cci-devfreq.c
>
1. It appears that proc_reg_uV might be used before initialization.
It would be appropriate to initialize it at the probe function.
2. Because you are already using OPP, why don't you rely on
OPP fully? (use OPP from CPUFreq drivers as well in order to get
OPP events automatically.) Anyway, this is a minor item that does
not need to be corrected.
Cheers
MyungJoo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-01 4:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 6:46 [PATCH v2 0/4] Add cpufreq and cci devfreq for mt8183 Andrew-sh.Cheng
2019-03-29 6:46 ` [PATCH v2 1/4] cpufreq: mediatek: add mt8183 cpufreq support Andrew-sh.Cheng
2019-03-31 0:06 ` Nicolas Boichat
2019-04-13 2:33 ` andrew-sh.cheng
2019-03-29 6:46 ` [PATCH v2 2/4] opp: add API which get max freq by voltage Andrew-sh.Cheng
2019-04-03 4:32 ` Nicolas Boichat
2019-04-13 4:39 ` andrew-sh.cheng
2019-04-10 6:29 ` Viresh Kumar
2022-06-02 6:54 ` Viresh Kumar
2019-03-29 6:46 ` [PATCH v2 3/4] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng
2019-04-16 9:08 ` Chanwoo Choi
2019-05-08 9:27 ` andrew-sh.cheng
2019-03-29 6:46 ` [PATCH v2 4/4] devfreq: add mediatek " Andrew-sh.Cheng
2019-04-08 17:22 ` [v2,4/4] " Guenter Roeck
2019-04-13 7:07 ` andrew-sh.cheng
2019-04-16 9:05 ` [PATCH v2 4/4] " Chanwoo Choi
2019-05-10 9:24 ` andrew-sh.cheng
[not found] ` <CGME20190329064632epcas2p4d10ea099bfea4ad682d7312a75bfbe68@epcms1p8>
2019-04-01 2:30 ` [PATCH v2 2/4] opp: add API which get max freq by voltage MyungJoo Ham
2019-04-13 3:36 ` andrew-sh.cheng
[not found] ` <CGME20190329064636epcas1p13633ae078ef83ceda0b8189df1399753@epcms1p1>
2019-04-01 4:18 ` MyungJoo Ham [this message]
2019-04-13 5:54 ` [PATCH v2 4/4] devfreq: add mediatek cci devfreq andrew-sh.cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401041843epcms1p10a664023cf0556e42afe118a1d84daad@epcms1p1 \
--to=myungjoo.ham@samsung.com \
--cc=andrew-sh.cheng@mediatek.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).