From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9612C4360F for ; Tue, 2 Apr 2019 10:27:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8CAE207E0 for ; Tue, 2 Apr 2019 10:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q54lzFZx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8CAE207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xRkKyL3M0/bX2v0iejjUwd2GkmCLABUlXy87ZSKojJA=; b=Q54lzFZxg46X2zFKSBxmYTg0F XYYrbT75ix+VkxUIS+hlQ+5mtIGboj4JNFyZ8YQuA8tlwR7FrhS+DNGfMsQC+Y/sGiRfkvmy8ImYI tGzvjF3fBJSvsbI4o/zUIOD0TVMTnMsL7j2LaMGHN/hu43rJJkaBrkChZkUX5C4ecDXYCBhQJj+dM HzxTIIqKk9qxHbxGge4cQIkkys2rk4+5C6W9PxsHgs2kZQWdjBkWvEVI5DnB0cuaOfMHUu5fFqg3u 9JJedGzzjD+VVIA8UiJ9Pa7Ja5o1FuKiWKt5jn9vYQnLsAa7PCexnBWYHBUjGlEHIZNzR27SF+s/u +DgsGGr4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBGdl-0000V3-ID; Tue, 02 Apr 2019 10:27:37 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBGdj-0000UG-6b for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 10:27:36 +0000 Received: from localhost (p5486CD10.dip0.t-ipconnect.de [84.134.205.16]) by pokefinder.org (Postfix) with ESMTPSA id 741DE2CF606; Tue, 2 Apr 2019 12:27:34 +0200 (CEST) Date: Tue, 2 Apr 2019 12:27:34 +0200 From: Wolfram Sang To: Ray Jui Subject: Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support Message-ID: <20190402102733.GD2960@kunai> References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-8-ray.jui@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20190214175725.60462-8-ray.jui@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_032735_386415_B450DA0B X-CRM114-Status: UNSURE ( 7.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0253987542825867715==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0253987542825867715== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > +#define IDM_CTRL_DIRECT_OFFSET 0x00 And this IDM thing is also never used outside of the I2C context? In other words, it also doesn't need a seperate DT node? > + /* indicates no slave mode support */ > + bool no_slave; I would suggest to not use a flag, but to nullify the {un}reg_slave callbacks in probe depending on the type. That will also tell the i2c-core that slave functionality is not supported. And you can use if (!algo->reg_slave) as a flag, too. > + iproc_i2c->type = > + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev); No need to cast a void*. --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlyjORUACgkQFA3kzBSg KbZmdw/9GNjBVJL/3oOGEZFDISLOBXCpa+MekxPn+H439sj9T661k+CV8XQZH12K TcchO9mzMA4w5nMFPKYGw3+aJ6cZXbXuvYwZfXu97u8zrfrN6dLcR4erWZi7/yMR Ckk0e2lcuOzXVp8JAiLtpWnix1dvc6c0vm4F50n+fD8UjGCkIn/Ur+syRCwsQnMB JD3Fb8m/Y+g0OSGOLtbJCg4UFnnz4rDrIecRUfUZgukKpL6alRyiKoE2ldQUecrh 8ftdrE0DA0FGnByRjboeLEWWUxMFAF3a3C4OFmytZ8P9nqihTfhwoRIfFLupmywU bUPHN00gol6EHw1tGPxu2KxuJ0n/yRgGr7ASw+CBbvDgpWhha4hBShT/bCfIufcq 1vIDA5M2wkG12FLn9MbwjjCXAR7WuWZbqI65UgwU4f9OKsbhC28S3siirKUSnRGg KR5Kv5jTgSZVSSdjWNG5xS1xKh1sp8iQUcQQRaOua60FqmHY1HvKc6HLogLJK5gH j/ByoLKqy16KTG1uOSmVEtEdNEQ5xiba84UvncJrIQcrvZnZlSQZml8EQ4njoK9Q vfQmCl7Tyx+S+GKSnMABvsHhvhf1GZf0EFYagwTPUZi4lsoK4Gvu2vu3YvD3D5Zn CqjsZsUHqW1jLPNYv9hDHO5eov/ZpRa7kJwuxcwmGLuvwbneSFU= =vf6X -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl-- --===============0253987542825867715== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0253987542825867715==--