From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
Stefan Lengfeld <contact@stefanchrist.eu>,
linux-omap@vger.kernel.org, Peter Rosin <peda@axentia.se>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/12] i2c: core: introduce atomic transfers
Date: Wed, 3 Apr 2019 16:15:10 +0300 [thread overview]
Message-ID: <20190403131510.GE9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190403124019.8947-1-wsa+renesas@sang-engineering.com>
On Wed, Apr 03, 2019 at 02:40:07PM +0200, Wolfram Sang wrote:
> This series adds support for very late atomic transfers to the I2C subsystem.
> It finally reached a state which I think is ready-to-apply. This is mainly
> because of two things:
>
> a) we decided to respect the current locking scheme and to not give atomic
> transfers a priority. The code needed for that would have been either
> incomplete or very invasive. And we cannot guarantee successful transfers
> anyhow. See [1] for the discussion and other write-ups for design choices.
>
> b) thanks to a discussion with Peter Zijlstra[2], the conditions when to allow
> atomic transfers became much clearer. The new helper i2c_in_atomic_xfer_mode()
> adds readability, too.
>
> In detail, changes since RFC v2:
>
> * dropped coding style patch because already applied
> * added new patch 1 to drop in_atomic() and have better conditions when
> to enter the atomic path
> * added support to the mux-core
> * simplified omap conversion a little
> * added new conversions for ocores, stu300, and algo-bit/gpio
> * typo corrections found by Simon and Stefan
> * added tags to drivers
> * dropped tags from core patches because that part changed too much
>
> All tested on a Renesas Lager board (R-Car H2). Sadly, the i2c-sh_mobile driver
> cannot be converted now because of other work needed first. I tested with the
> i2c-gpio driver, though. The other driver patches are build tested. A branch
> can be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/i2c/atomic_xfer
>
> I am happy for reviews and comments. Please note if you review (especially the
> core parts), I'd like to have a short summary of your review even if there is
> no proposed change. Like what you did, what you think about it, etc. Some stuff
> in here is subtle, so if you went through the effort to double check my
> assumptions you should name it :)
>
Thank you!
FWIW,
Reviewed-by Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for patches 1-5,12.
Indeed, atomic condition sounds clear now.
>
> Finally, a big thank you and credit to Renesas for funding this work, of course!
>
> Happy hacking,
>
> Wolfram
>
> [1] https://lkml.org/lkml/2019/3/2/76
> [2] http://patchwork.ozlabs.org/patch/1067437/
>
> Wolfram Sang (12):
> i2c: remove use of in_atomic()
> i2c: core: use I2C locking behaviour also for SMBUS
> i2c: core: introduce callbacks for atomic transfers
> i2c: mux: populate the new *_atomic callbacks
> i2c: demux: handle the new atomic callbacks
> i2c: omap: Add the master_xfer_irqless hook
> i2c: tegra-bpmp: convert to use new atomic callbacks
> i2c: ocores: refactor setup for polling
> i2c: ocores: enable atomic xfers
> i2c: stu300: use xfer_atomic callback to bail out early
> i2c: algo: bit: add flag to whitelist atomic transfers
> i2c: gpio: flag atomic capability if possible
>
> drivers/i2c/algos/i2c-algo-bit.c | 22 +++++++++-
> drivers/i2c/busses/i2c-gpio.c | 2 +
> drivers/i2c/busses/i2c-ocores.c | 16 +++-----
> drivers/i2c/busses/i2c-omap.c | 76 +++++++++++++++++++++++++++++------
> drivers/i2c/busses/i2c-stu300.c | 25 +++++-------
> drivers/i2c/busses/i2c-tegra-bpmp.c | 25 +++++++++---
> drivers/i2c/i2c-core-base.c | 17 ++++----
> drivers/i2c/i2c-core-smbus.c | 25 +++++++++---
> drivers/i2c/i2c-core.h | 25 ++++++++++++
> drivers/i2c/i2c-mux.c | 6 +++
> drivers/i2c/muxes/i2c-demux-pinctrl.c | 2 +
> include/linux/i2c-algo-bit.h | 1 +
> include/linux/i2c.h | 15 +++++--
> 13 files changed, 194 insertions(+), 63 deletions(-)
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-03 13:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:40 [PATCH 00/12] i2c: core: introduce atomic transfers Wolfram Sang
2019-04-03 12:40 ` [PATCH 01/12] i2c: remove use of in_atomic() Wolfram Sang
2019-04-15 12:40 ` Andy Shevchenko
2019-04-15 21:55 ` Stefan Lengfeld
2019-04-16 10:48 ` Wolfram Sang
2019-04-03 12:40 ` [PATCH 02/12] i2c: core: use I2C locking behaviour also for SMBUS Wolfram Sang
2019-04-15 12:39 ` Andy Shevchenko
2019-04-03 12:40 ` [PATCH 03/12] i2c: core: introduce callbacks for atomic transfers Wolfram Sang
2019-04-15 12:39 ` Andy Shevchenko
2019-04-15 21:57 ` Stefan Lengfeld
2019-04-03 12:40 ` [PATCH 04/12] i2c: mux: populate the new *_atomic callbacks Wolfram Sang
2019-04-03 15:17 ` Peter Rosin
2019-04-15 12:04 ` Wolfram Sang
2019-04-15 12:44 ` Andy Shevchenko
2019-04-03 12:40 ` [PATCH 05/12] i2c: demux: handle the new atomic callbacks Wolfram Sang
2019-04-15 12:37 ` Andy Shevchenko
2019-04-03 12:40 ` [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook Wolfram Sang
2019-04-15 22:05 ` Stefan Lengfeld
2019-04-16 10:52 ` Wolfram Sang
2019-04-03 12:40 ` [PATCH 07/12] i2c: tegra-bpmp: convert to use new atomic callbacks Wolfram Sang
2019-04-03 12:40 ` [PATCH 08/12] i2c: ocores: refactor setup for polling Wolfram Sang
2019-04-05 15:09 ` Peter Korsgaard
2019-04-05 19:00 ` Andrew Lunn
2019-04-03 12:40 ` [PATCH 09/12] i2c: ocores: enable atomic xfers Wolfram Sang
2019-04-05 19:20 ` Andrew Lunn
2019-04-03 12:40 ` [PATCH 10/12] i2c: stu300: use xfer_atomic callback to bail out early Wolfram Sang
2019-04-04 15:38 ` Linus Walleij
2019-04-03 12:40 ` [PATCH 11/12] i2c: algo: bit: add flag to whitelist atomic transfers Wolfram Sang
2019-04-03 12:40 ` [PATCH 12/12] i2c: gpio: flag atomic capability if possible Wolfram Sang
2019-04-04 15:40 ` Linus Walleij
2019-04-15 12:38 ` Andy Shevchenko
2019-04-03 13:15 ` Andy Shevchenko [this message]
2019-04-15 12:06 ` [PATCH 00/12] i2c: core: introduce atomic transfers Wolfram Sang
2019-04-15 12:35 ` Andy Shevchenko
2019-04-15 12:48 ` Andy Shevchenko
2019-04-15 12:50 ` Wolfram Sang
2019-04-15 12:10 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403131510.GE9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=contact@stefanchrist.eu \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).