From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E337DC10F06 for ; Sat, 6 Apr 2019 07:14:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA5192146F for ; Sat, 6 Apr 2019 07:14:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V4xZM/VR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA5192146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rJ5jRW4SEeQHCWB0f0PrGxI63wJfmdaTYBKxOR3K/lo=; b=V4xZM/VR1tyWLL zTzkI5U7DaQ+llPtzH6taxBDMsICQclx6ABLqMbCRVyANrH6dZonqF40PeT5abQS1mpsbA9tRXFDZ SvjsV8ku+1UGSV9+iBK3VhmG1MEAv2icZJYRacaOkCcJwszIXepVrQAMBpov5Odc49e6Oc1CEqRc3 jNnNHf3sN0vFmveT7t7Qbf8OtcZCtTQ6EupOpxkO6p8UCNCdm6YbRK9H6zFZzKHbrCvTUxiaiMx5g Tps1DcEQj4x6qd+Idf5quMJcfii9Qep0oFmKsoPgeIEC5wthVuWKDJ9/LHEX+A2qL+gjzTftVkH9s QBlKLVjtumIHKqSDqrxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCfWj-0006Ph-Oo; Sat, 06 Apr 2019 07:14:09 +0000 Received: from mail-pl1-f194.google.com ([209.85.214.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCfWg-0006Od-DU for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2019 07:14:07 +0000 Received: by mail-pl1-f194.google.com with SMTP id y6so4227442pll.13 for ; Sat, 06 Apr 2019 00:14:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JtnZVgGpUPAC9FI3mMvruPQumnTJn+wT5jX4iXUuE/U=; b=k5+tWaAqiw7nIrnjKDaN2/u0d0JkPrJItejva1JSb+OTbXaA8B+tmg9pPOBQgjMfW8 MKwR/eW0uhA8z1cCCubXpGHjr7YiMSm7YvT/oXwLAkxK1DXKoeDfL2r+rMPyUskuCk9V F321tgO+F8xuzbufNMAHE2YytPkXZaLzRtqu+r6RKNPtpuq0IMrTITLaP/pIUxR0zZhn a74L9A5YVD5mfWgFOq6quCKXubOjddxiw5XLGrlNe5YnEiDOUjWlf1BqY9IVBl5NClvX hNyeMVG5cPi6dsVaJT086x9SEGvXGgBnNFMwmQyA2ivWHy690MNo8ThX+8NR9V8tHkf1 szQw== X-Gm-Message-State: APjAAAUbDIDPSnelF0kcYTb8qLvbEcw5VF4vqN9pzMrsld5E3kdhK9fr xOEaxaX40mQO1OI3FrOvTw== X-Google-Smtp-Source: APXvYqwzFFU/bTjYXqwS50ZEPfZBcK/XqGaJ2uBXTppNb/xiheQiNW16RgYmcOC9O8a/Iau0SzXM7Q== X-Received: by 2002:a17:902:2ec1:: with SMTP id r59mr17755230plb.171.1554534844920; Sat, 06 Apr 2019 00:14:04 -0700 (PDT) Received: from localhost ([210.160.217.71]) by smtp.gmail.com with ESMTPSA id u4sm68433170pgn.12.2019.04.06.00.14.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Apr 2019 00:14:04 -0700 (PDT) Date: Sat, 6 Apr 2019 02:14:02 -0500 From: Rob Herring To: Icenowy Zheng Subject: Re: [PATCH v5 2/5] dt-bindings: phy: add binding for Allwinner USB3 PHY Message-ID: <20190406071402.GA6006@bogus> References: <20190405205736.55177-1-icenowy@aosc.io> <20190405205736.55177-3-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190405205736.55177-3-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190406_001406_459491_493C84EE X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Maxime Ripard , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 06, 2019 at 04:57:33AM +0800, Icenowy Zheng wrote: > The new Allwinner H6 SoC contains a USB3 PHY that is wired to the > external USB3 pins of the SoC. > > Add a device tree binding for the PHY. > > Signed-off-by: Icenowy Zheng > Reviewed-by: Chen-Yu Tsai > --- > Changes in v5: > - Dropped Vbus regulator and added connector subnode. > > Changes in v4: > - Changed Vbus regulator property to vbus-supply. > > Changes in v3: > - Added Chen-Yu's Review tag. > > No changes in v2, v1. > > .../bindings/phy/sun50i-usb3-phy.txt | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > new file mode 100644 > index 000000000000..eeedc53e6360 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/sun50i-usb3-phy.txt > @@ -0,0 +1,28 @@ > +Allwinner sun50i USB3 PHY > +----------------------- > + > +Required properties: > +- compatible : should be one of > + * allwinner,sun60i-h6-usb3-phy > +- reg : a list of offset + length pairs > +- #phy-cells : from the generic phy bindings, must be 0 > +- clocks : phandle + clock specifier for the phy clock > +- resets : phandle + reset specifier for the phy reset > + > +Optional nodes: > +- connector : A sub-node required for representing the connector connected > + to the USB PHY. See ../connector/usb-connector.txt for details. > + > +Example: > + usb3phy: phy@5210000 { > + compatible = "allwinner,sun50i-h6-usb3-phy"; > + reg = <0x5210000 0x10000>; > + clocks = <&ccu CLK_USB_PHY1>; > + resets = <&ccu RST_USB_PHY1>; > + #phy-cells = <0>; > + > + connector { > + compatible = "usb-a-connector"; > + label = "USB3"; The binding defines that a connector is a child of USB controller or some port controller (such as USB-C ctrlr) with OF graph to USB controller. So either way, this is wrong unless this is more than just a phy. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel