From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B69C10F13 for ; Mon, 8 Apr 2019 16:18:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A0902147A for ; Mon, 8 Apr 2019 16:18:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nQiLp/Vt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A0902147A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pv5s50uRzNdlGlwlciI/WSDXkirLjgG96eV7bn/Zj3Y=; b=nQiLp/VtUQloSQ n7aMES03ZXt7fazTRr9pZEJ6IOAs4sQmxoxNSyvxTbUbJvevtfqTCoF2G0cQh4z1qRRquXZFAjTma sRJ3Ul8ZErF8EJo0B7t3SYphfcQ+V6B3NACDcy//vUgN6ou1T9tUDPaE4SLIGKV/ukfURHS4fopAW W7eccQf8zodlwgc5fmgX/y8E3tItW76qLzY2qUNqE4r6Os7Xh9e6KajogrhMA7Vy9mTigYRd8SFfd DsRgrnyyfO4hpnJaVaVeFuGx88cTt51gbZhGebLS3iSPzlLEV4mscHxD0XAGPjZuKc6adF1FrAL2S uqne+HB+WhhYM7wTQZiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDWyL-0003q6-Jz; Mon, 08 Apr 2019 16:18:13 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDWyG-0003pJ-9k for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 16:18:09 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 33C3880AA; Mon, 8 Apr 2019 16:18:20 +0000 (UTC) Date: Mon, 8 Apr 2019 09:18:02 -0700 From: Tony Lindgren To: Masahiro Yamada Subject: Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Message-ID: <20190408161802.GI49658@atomide.com> References: <20190408075427.6052-1-yamada.masahiro@socionext.com> <20190408075427.6052-3-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190408075427.6052-3-yamada.masahiro@socionext.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_091808_377071_C397ABF1 X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Dave Gerlach , Keerthy , Russell King , linux-kernel@vger.kernel.org, arm@kernel.org, Olof Johansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Masahiro Yamada [190408 07:56]: > is only generated and included > by arch/arm/mach-omap2/, so it does not need to reside in the > globally visible include/generated/. > > I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h > since the prefix 'omap2-' is just redundant in mach-omap2/. > > Signed-off-by: Masahiro Yamada > --- > > Can this be applied to ARM-SOC tree in a series? > (with Ack from the platform sub-maintainer.) > > ti-pm-asm-offsets.h does not need to reside in include/generated/, > but you may ask "Why must it get out of include/generated/?" > > My main motivation is to avoid a race condition in the currently > proposed patch: > > https://lore.kernel.org/patchwork/patch/1052763/ > > This patch tries to embed some build artifacts into the kernel. > > If arch/arm/mach-omap2/ and kernel/ are built at the same time, > it may embed a truncated file. Looks like a nice improvment to me, adding Keerthy and Dave to Cc. Keerthy and Dave, can you please test this series with am3 and am4 PM code? Regards, Tony > arch/arm/mach-omap2/.gitignore | 1 + > arch/arm/mach-omap2/Makefile | 5 +++-- > arch/arm/mach-omap2/sleep33xx.S | 2 +- > arch/arm/mach-omap2/sleep43xx.S | 2 +- > 4 files changed, 6 insertions(+), 4 deletions(-) > create mode 100644 arch/arm/mach-omap2/.gitignore > > diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore > new file mode 100644 > index 000000000000..79a8d6ea7152 > --- /dev/null > +++ b/arch/arm/mach-omap2/.gitignore > @@ -0,0 +1 @@ > +pm-asm-offsets.h > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > index 85d1b13c9215..26baeb6477af 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o > > obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o > > -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE > +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE > $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__) > > -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h > +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h > > targets += pm-asm-offsets.s > +clean-files += pm-asm-offsets.h > diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S > index 47a816468cdb..a003769121aa 100644 > --- a/arch/arm/mach-omap2/sleep33xx.S > +++ b/arch/arm/mach-omap2/sleep33xx.S > @@ -6,7 +6,6 @@ > * Dave Gerlach, Vaibhav Bedia > */ > > -#include > #include > #include > #include > @@ -15,6 +14,7 @@ > > #include "iomap.h" > #include "cm33xx.h" > +#include "pm-asm-offsets.h" > > #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000 > #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003 > diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S > index 5b9343b58fc7..aa288f361c5e 100644 > --- a/arch/arm/mach-omap2/sleep43xx.S > +++ b/arch/arm/mach-omap2/sleep43xx.S > @@ -6,7 +6,6 @@ > * Dave Gerlach, Vaibhav Bedia > */ > > -#include > #include > #include > #include > @@ -19,6 +18,7 @@ > #include "iomap.h" > #include "omap-secure.h" > #include "omap44xx.h" > +#include "pm-asm-offsets.h" > #include "prm33xx.h" > #include "prcm43xx.h" > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel