From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E073C10F0E for ; Tue, 9 Apr 2019 10:10:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2CFC20857 for ; Tue, 9 Apr 2019 10:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bp7aUZ2o"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SVBVhho/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2CFC20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nJal+ZxitDvZpgt6MSh/RuHz/Z3lmpyZ/U2LUAvjhlk=; b=bp7aUZ2o+l/63B TTSPt9h2Adod4NIq1ZlKMU98TMZjx/yAJ33XRO04U0FFeIdq9LhHkBH/UoIXsticNiBFbzJmxJNyL PqnnK9lAyJzF4+CWJAFR3uBI3LmjnucXUwCRF4bxwwOYfhbmfAwLZL83vWrV6HNaKYbHZ/86qDJ7C nKZ5JRzpxXzU/0mRdfLKONOabeUNyObhtQ8fL8X+GGPVvpMgvE8mW+aPhlhBMPCzJLZthCCYUXvbn eie2DvrCEeKop0zaTVHRgIVP7RZO4MHnHeIpZalHCFY3Ox9eMVL4NgPHMb/FoUldHMdFdyK1mqZwM h0g6F9VR+hn5L5Zj6rAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDni1-0004oE-9W; Tue, 09 Apr 2019 10:10:29 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDnfD-0000wb-4v for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 10:07:39 +0000 Received: by mail-pf1-x441.google.com with SMTP id c207so9414976pfc.7 for ; Tue, 09 Apr 2019 03:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=63RC5yV5xPuk6vbHnpK6FXhUlEyzGfikDI5OAE5o4dw=; b=SVBVhho/CO1pj7d1xtD204w37VeuqYRg+2kyhK7a2g4ls69frxCc/QCr/+OivOcaLb sXqdV9a3hOyTsKAD3r5Ewnb7cFaRdHENj/q5aoOSJ1PvlTmlW+lGx5O9btIAzo7iZze1 i+uFUZBqg2qCFqQtPAd/6P42OyF3JuZ+XrrSGxhNCv2ssVwzK1KBCpy2azIcKf5tRklI cxaqbBrjEyjiEmWd3aS7lmFVIqmSgCaIieLGGDy7JewPIKKr/dxs/wC5CfDJaXDr9V4Y ZG7b6/1/HVCtvZ8Xp6IBFFjg0WN5tgRYBMaIoRyFZ6h0NrNTtZqhVPaVlamkht+BylRB tCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=63RC5yV5xPuk6vbHnpK6FXhUlEyzGfikDI5OAE5o4dw=; b=UCaTU80WcWQ5Ns4xjG2DzozVFJpHEsoVrXgNn2vfOISNndMJI5DiY8Oxl4CyAPbRbt BfYhQx06Vq//jYewqO+fRPsSc29D6lCNJ9SD1QinUOm6Fbknl5w+r2S+FaTSHqrhFkNY ttJHkEM3B8meKc9GvKHCxU8ErgCwSFW6cE19lRzpxX7cZDfOdFLvVb2JOdpEJ+jWgVDF aa55DrPfocGRmYue6MV87UQ40BRwYZuczGMkOA7zInKT+OVYYGayzoA76xTQwCRtjd7N lNutr2MAMYoXBv0jbdBOhJ9oN5jVybNSpn+EMJH+5C2+4kqIh8yMi2WqRqO3u9MVZBrs zUBw== X-Gm-Message-State: APjAAAWsu6rZGQXATFKNscza2Lu9xpMASB5R6HO8EWRHzq5+x731hevb Y0FoJn+52Dah9ofoNLWtrYtdSQ== X-Google-Smtp-Source: APXvYqxs5ramzBDSy8hQA1StgrIc+AZTeFh+vht56AKFMjRQvbnWuF9X4qGf1dEcFKRQHg9MhMTtaQ== X-Received: by 2002:a63:c505:: with SMTP id f5mr34218953pgd.87.1554804453806; Tue, 09 Apr 2019 03:07:33 -0700 (PDT) Received: from localhost ([122.172.162.162]) by smtp.gmail.com with ESMTPSA id o81sm26333085pfa.156.2019.04.09.03.07.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 03:07:32 -0700 (PDT) Date: Tue, 9 Apr 2019 15:37:30 +0530 From: Viresh Kumar To: Yangtao Li Subject: Re: [PATCH 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu Message-ID: <20190409100730.2rtxyy66knjning6@vireshk-i7> References: <20190405102455.15311-1-tiny.windzz@gmail.com> <20190405102455.15311-3-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190405102455.15311-3-tiny.windzz@gmail.com> User-Agent: NeoMutt/20180323-120-3dd1ac X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_030735_546385_78E0140E X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, mark.rutland@arm.com, linux-pm@vger.kernel.org, maxime.ripard@bootlin.com, vireshk@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, sboyd@kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, mchehab+samsung@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05-04-19, 06:24, Yangtao Li wrote: > +++ b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + compatible = "arm,cortex-a53"; > + device_type = "cpu"; > + reg = <0>; > + enable-method = "psci"; > + clocks = <&ccu CLK_CPUX>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + operating-points-v2 = <&cpu_opp_table>; > + #cooling-cells = <2>; > + }; > + > + cpu1: cpu@1 { > + compatible = "arm,cortex-a53"; > + device_type = "cpu"; > + reg = <1>; > + enable-method = "psci"; > + clocks = <&ccu CLK_CPUX>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + operating-points-v2 = <&cpu_opp_table>; > + #cooling-cells = <2>; > + }; > + > + cpu2: cpu@2 { > + compatible = "arm,cortex-a53"; > + device_type = "cpu"; > + reg = <2>; > + enable-method = "psci"; > + clocks = <&ccu CLK_CPUX>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + operating-points-v2 = <&cpu_opp_table>; > + #cooling-cells = <2>; > + }; > + > + cpu3: cpu@3 { > + compatible = "arm,cortex-a53"; > + device_type = "cpu"; > + reg = <3>; > + enable-method = "psci"; > + clocks = <&ccu CLK_CPUX>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + operating-points-v2 = <&cpu_opp_table>; > + #cooling-cells = <2>; > + }; > + }; > + > + cpu_opp_table: opp_table { > + compatible = "operating-points-v2-sunxi-cpu"; > + nvmem-cells = <&speedbin_efuse>; > + opp-shared; > + > + opp-480000000-0 { > + opp-hz = /bits/ 64 <480000000>; > + opp-microvolt = <880000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-720000000-0 { > + opp-hz = /bits/ 64 <720000000>; > + opp-microvolt = <880000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-816000000-0 { > + opp-hz = /bits/ 64 <816000000>; > + opp-microvolt = <880000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-888000000-0 { > + opp-hz = /bits/ 64 <888000000>; > + opp-microvolt = <940000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1080000000-0 { > + opp-hz = /bits/ 64 <1080000000>; > + opp-microvolt = <1060000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1320000000-0 { > + opp-hz = /bits/ 64 <1320000000>; > + opp-microvolt = <1160000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1488000000-0 { > + opp-hz = /bits/ 64 <1488000000>; > + opp-microvolt = <1160000>; > + opp-supported-hw = <0x1>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + > + opp-480000000-1 { > + opp-hz = /bits/ 64 <480000000>; > + opp-microvolt = <820000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-720000000-1 { > + opp-hz = /bits/ 64 <720000000>; > + opp-microvolt = <820000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-816000000-1 { > + opp-hz = /bits/ 64 <816000000>; > + opp-microvolt = <820000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-888000000-1 { > + opp-hz = /bits/ 64 <888000000>; > + opp-microvolt = <820000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1080000000-1 { > + opp-hz = /bits/ 64 <1080000000>; > + opp-microvolt = <880000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1320000000-1 { > + opp-hz = /bits/ 64 <1320000000>; > + opp-microvolt = <940000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1488000000-1 { > + opp-hz = /bits/ 64 <1488000000>; > + opp-microvolt = <1000000>; > + opp-supported-hw = <0x2>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + > + opp-480000000-2 { > + opp-hz = /bits/ 64 <480000000>; > + opp-microvolt = <800000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-720000000-2 { > + opp-hz = /bits/ 64 <720000000>; > + opp-microvolt = <800000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-816000000-2 { > + opp-hz = /bits/ 64 <816000000>; > + opp-microvolt = <800000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-888000000-2 { > + opp-hz = /bits/ 64 <888000000>; > + opp-microvolt = <800000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1080000000-2 { > + opp-hz = /bits/ 64 <1080000000>; > + opp-microvolt = <840000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1320000000-2 { > + opp-hz = /bits/ 64 <1320000000>; > + opp-microvolt = <900000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + opp-1488000000-2 { > + opp-hz = /bits/ 64 <1488000000>; > + opp-microvolt = <960000>; > + opp-supported-hw = <0x4>; > + clock-latency-ns = <244144>; /* 8 32k periods */ > + }; > + }; Well, this is pure duplication of all the OPPs which isn't great. If I have understood things correctly from the above example, then all you want is a different microvolt value for each OPP, right ? Then you are using the wrong feature of OPP core I am afraid. What you should rather look for is opp-microvolt- property, look in opp.txt bindings. And these are the helper you need to use: dev_pm_opp_set_prop_name()/dev_pm_opp_put_prop_name(). -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel