From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96268C10F11 for ; Wed, 10 Apr 2019 16:25:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6750320830 for ; Wed, 10 Apr 2019 16:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kqhvp5bW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6750320830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aiKZF9ZYYCardavhDBNd9Ts7M3aW3+ZTCgKkx1Uac08=; b=kqhvp5bWXok9Ti 2iiAQg8PI7dWxWBIlfqgd587WvoYNFQYGKjoApR4HVI6uqgGDIYWofNDWZZlmsLqFf2h2GQG4i4XD aw/BldkH5NUzivcIEH6U1ZDDUj9pUdDelrrdagidFVh1RqP83dPFzRkGHyhBVgz5Fbwm2kZGiAkkK PGMordXZcSjvGp1fQF9UO62oYQx0Epw5mXyX1+ovwI6ep4X9FQKPYlDWZONIdMz12HGmiI78aBamy wloSC5vKrgTYOK4oN1N5XnPTHT0E5+xJQeLSsW8cwOUhFlv7FY64cyO9JNdR6X1NsaQd+0H+tH5Ft JXL9tendz0LcxsgyUwAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEG2j-0003Zt-SK; Wed, 10 Apr 2019 16:25:45 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEG2f-0003ZZ-RB for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2019 16:25:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A226E374; Wed, 10 Apr 2019 09:25:40 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 925FC3F59C; Wed, 10 Apr 2019 09:25:39 -0700 (PDT) Date: Wed, 10 Apr 2019 17:25:37 +0100 From: Sudeep Holla To: Kangjie Lu Subject: Re: [PATCH] firmware: arm_scmi: check return value of idr_find Message-ID: <20190410162537.GF3952@e107155-lin> References: <20190309040239.32431-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190309040239.32431-1-kjlu@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_092541_884048_278614CB X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pakki001@umn.edu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2019 at 10:02:39PM -0600, Kangjie Lu wrote: > idr_find may return NULL, so check its return value and return an > error code. > I can't imagine a scenario leading to this. Steven has already explained why, so I won't repeat the same here. Did you hit this issue ? If so I would like to know details, so that we can bail out much earlier where the failure occurs than proceed until this point. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel