From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7E5C10F14 for ; Thu, 11 Apr 2019 00:20:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9691F20850 for ; Thu, 11 Apr 2019 00:20:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mTBlIJxC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="nzoHh2m8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9691F20850 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+YA/3DHtoxM8w/b3IAuQNBwlGLKGmsvntrbXo4UXnOA=; b=mTBlIJxCdxxzdH pV5WdcNXboyTBSfMxbUABS/justp3K7Xrj/DmWrmlST4103SkE4kcuitQB+8iqeeOEjC49lzlGMpu wvPV79i3spX0ca+0UcXoihoeeFGErVA21Tecta2iIdszweQJ7YHURLo7hIE4bYkmWZdWifYWCC6eG 8IEhkWv0A7Otho08T49+LJ7VZffLaoCDS4u6XW5h6BvxDAjK8jIDFVNYoslHvQTu3KXdnp8wJ51z5 RCZ9qhbY/jwZEaCKIqnSflr004hWW4ofuA3758UYQC2p9QaurXZtXhDZ70F47QT/CJbcruZ0LHrFX aiLCdI2jbYoj0Tl4PH2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hENSS-00059A-Vj; Thu, 11 Apr 2019 00:20:48 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hENSO-00058n-Mk for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 00:20:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1554942042; bh=fD6bQqDjgKTw1DvWij6cFvCpOrELqpOUZDmhQ5T8Tco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nzoHh2m8iva8LUBIEeJPgARTCkgc90GAl3vaSTKFrCu6f6gVyUaDTGcVHu+CQMT4b Z7b8csBPSJfi1GTqY5KbfcxP5r3nD7QwTwk69784SNw1yRjzcPocVp63P45r5ndfdO IiiJDrV+oj7Y+NhbPX4e2f6MRsw2JgS+GIq/naRw= Date: Thu, 11 Apr 2019 02:20:42 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Icenowy Zheng Subject: Re: [linux-sunxi] [PATCH v5 3/5] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC Message-ID: <20190411002042.mw7pozfzopj5qnxu@core.my.home> Mail-Followup-To: Icenowy Zheng , Rob Herring , Kishon Vijay Abraham I , Maxime Ripard , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com References: <20190405205736.55177-1-icenowy@aosc.io> <20190405205736.55177-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190405205736.55177-4-icenowy@aosc.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_172045_091497_68AC2121 X-CRM114-Status: GOOD ( 29.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Maxime Ripard , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 06, 2019 at 04:57:34AM +0800, Icenowy Zheng wrote: > Allwinner H6 SoC contains a USB3 PHY (with USB2 DP/DM lines also > controlled). > > Add a driver for it. > > The register operations in this driver is mainly extracted from the BSP > USB3 driver. > > Signed-off-by: Icenowy Zheng > Reviewed-by: Chen-Yu Tsai > --- > Changes in v5: > - Dropped support for vbus-supply property in the device node itself and > added support for vbus-supply property in the connector subnode. > > Changes in v4: > - Added support for vbus-supply property. > > Changes in v3: > - Dropped USB_SUPPORT dependency. > - Added Chen-Yu's Review tag. > > No changes in v2, v1. drivers/phy/allwinner/Kconfig | 12 ++ > drivers/phy/allwinner/Makefile | 1 + > drivers/phy/allwinner/phy-sun50i-usb3.c | 260 ++++++++++++++++++++++++ > 3 files changed, 273 insertions(+) > create mode 100644 drivers/phy/allwinner/phy-sun50i-usb3.c > > diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig > index fb1204bcc454..2c363db177f2 100644 > --- a/drivers/phy/allwinner/Kconfig > +++ b/drivers/phy/allwinner/Kconfig > @@ -41,3 +41,15 @@ config PHY_SUN9I_USB > sun9i SoCs. > > This driver controls each individual USB 2 host PHY. > + > +config PHY_SUN50I_USB3 > + tristate "Allwinner sun50i SoC USB3 PHY driver" > + depends on ARCH_SUNXI && HAS_IOMEM && OF > + depends on RESET_CONTROLLER > + select USB_COMMON > + select GENERIC_PHY > + help > + Enable this to support the USB3.0-capable transceiver that is > + part of some Allwinner sun50i SoCs. > + > + This driver controls each individual USB 2+3 host PHY combo. > diff --git a/drivers/phy/allwinner/Makefile b/drivers/phy/allwinner/Makefile > index 7d0053efbfaa..59575a895779 100644 > --- a/drivers/phy/allwinner/Makefile > +++ b/drivers/phy/allwinner/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o > obj-$(CONFIG_PHY_SUN6I_MIPI_DPHY) += phy-sun6i-mipi-dphy.o > obj-$(CONFIG_PHY_SUN9I_USB) += phy-sun9i-usb.o > +obj-$(CONFIG_PHY_SUN50I_USB3) += phy-sun50i-usb3.o > diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c > new file mode 100644 > index 000000000000..5299aef98668 > --- /dev/null > +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c > @@ -0,0 +1,260 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Allwinner sun50i(H6) USB 3.0 phy driver > + * > + * Copyright (C) 2017 Icenowy Zheng > + * > + * Based on phy-sun9i-usb.c, which is: > + * > + * Copyright (C) 2014-2015 Chen-Yu Tsai > + * > + * Based on code from Allwinner BSP, which is: > + * > + * Copyright (c) 2010-2015 Allwinner Technology Co., Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Interface Status and Control Registers */ > +#define SUNXI_ISCR 0x00 > +#define SUNXI_PIPE_CLOCK_CONTROL 0x14 > +#define SUNXI_PHY_TUNE_LOW 0x18 > +#define SUNXI_PHY_TUNE_HIGH 0x1c > +#define SUNXI_PHY_EXTERNAL_CONTROL 0x20 > + > +/* USB2.0 Interface Status and Control Register */ > +#define SUNXI_ISCR_FORCE_VBUS (3 << 12) > + > +/* PIPE Clock Control Register */ > +#define SUNXI_PCC_PIPE_CLK_OPEN (1 << 6) > + > +/* PHY External Control Register */ > +#define SUNXI_PEC_EXTERN_VBUS (3 << 1) > +#define SUNXI_PEC_SSC_EN (1 << 24) > +#define SUNXI_PEC_REF_SSP_EN (1 << 26) > + > +/* PHY Tune High Register */ > +#define SUNXI_TX_DEEMPH_3P5DB(n) ((n) << 19) > +#define SUNXI_TX_DEEMPH_3P5DB_MASK GENMASK(24, 19) > +#define SUNXI_TX_DEEMPH_6DB(n) ((n) << 13) > +#define SUNXI_TX_DEEMPH_6GB_MASK GENMASK(18, 13) > +#define SUNXI_TX_SWING_FULL(n) ((n) << 6) > +#define SUNXI_TX_SWING_FULL_MASK GENMASK(12, 6) > +#define SUNXI_LOS_BIAS(n) ((n) << 3) > +#define SUNXI_LOS_BIAS_MASK GENMASK(5, 3) > +#define SUNXI_TXVBOOSTLVL(n) ((n) << 0) > +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2) > + > +struct sun50i_usb3_phy { > + struct phy *phy; > + void __iomem *regs; > + struct reset_control *reset; > + struct clk *clk; > + struct platform_device *connector_dev; > + struct regulator *vbus; > +}; > + > +static void sun50i_usb3_phy_open(struct sun50i_usb3_phy *phy) > +{ > + u32 val; > + > + val = readl(phy->regs + SUNXI_PHY_EXTERNAL_CONTROL); > + val |= SUNXI_PEC_EXTERN_VBUS; > + val |= SUNXI_PEC_SSC_EN | SUNXI_PEC_REF_SSP_EN; > + writel(val, phy->regs + SUNXI_PHY_EXTERNAL_CONTROL); > + > + val = readl(phy->regs + SUNXI_PIPE_CLOCK_CONTROL); > + val |= SUNXI_PCC_PIPE_CLK_OPEN; > + writel(val, phy->regs + SUNXI_PIPE_CLOCK_CONTROL); > + > + val = readl(phy->regs + SUNXI_ISCR); > + val |= SUNXI_ISCR_FORCE_VBUS; > + writel(val, phy->regs + SUNXI_ISCR); > + > + /* > + * All the magic numbers written to the PHY_TUNE_{LOW_HIGH} > + * registers are directly taken from the BSP USB3 driver from > + * Allwiner. > + */ > + writel(0x0047fc87, phy->regs + SUNXI_PHY_TUNE_LOW); > + > + val = readl(phy->regs + SUNXI_PHY_TUNE_HIGH); > + val &= ~(SUNXI_TXVBOOSTLVL_MASK | SUNXI_LOS_BIAS_MASK | > + SUNXI_TX_SWING_FULL_MASK | SUNXI_TX_DEEMPH_6GB_MASK | > + SUNXI_TX_DEEMPH_3P5DB_MASK); > + val |= SUNXI_TXVBOOSTLVL(0x7); > + val |= SUNXI_LOS_BIAS(0x7); > + val |= SUNXI_TX_SWING_FULL(0x55); > + val |= SUNXI_TX_DEEMPH_6DB(0x20); > + val |= SUNXI_TX_DEEMPH_3P5DB(0x15); > + writel(val, phy->regs + SUNXI_PHY_TUNE_HIGH); > +} > + > +static int sun50i_usb3_phy_init(struct phy *_phy) > +{ > + struct sun50i_usb3_phy *phy = phy_get_drvdata(_phy); > + int ret; > + > + ret = clk_prepare_enable(phy->clk); > + if (ret) > + goto err_clk; > + > + ret = reset_control_deassert(phy->reset); > + if (ret) > + goto err_reset; > + > + sun50i_usb3_phy_open(phy); > + return 0; > + > +err_reset: > + clk_disable_unprepare(phy->clk); > + > +err_clk: > + return ret; > +} > + > +static int sun50i_usb3_phy_exit(struct phy *_phy) > +{ > + struct sun50i_usb3_phy *phy = phy_get_drvdata(_phy); > + > + reset_control_assert(phy->reset); > + clk_disable_unprepare(phy->clk); > + > + return 0; > +} > + > +static int sun50i_usb3_phy_power_on(struct phy *_phy) > +{ > + struct sun50i_usb3_phy *phy = phy_get_drvdata(_phy); > + > + if (phy->vbus) > + return regulator_enable(phy->vbus); > + else > + return 0; > +} > + > +static int sun50i_usb3_phy_power_off(struct phy *_phy) > +{ > + struct sun50i_usb3_phy *phy = phy_get_drvdata(_phy); > + > + if (phy->vbus) > + return regulator_disable(phy->vbus); > + else > + return 0; > +} > + > +static const struct phy_ops sun50i_usb3_phy_ops = { > + .init = sun50i_usb3_phy_init, > + .exit = sun50i_usb3_phy_exit, > + .power_on = sun50i_usb3_phy_power_on, > + .power_off = sun50i_usb3_phy_power_off, > + .owner = THIS_MODULE, > +}; > + > +static int sun50i_usb3_phy_probe(struct platform_device *pdev) > +{ > + struct sun50i_usb3_phy *phy; > + struct device *dev = &pdev->dev; > + struct phy_provider *phy_provider; > + struct resource *res; > + struct device_node *connector_node; > + int ret; > + > + phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); > + if (!phy) > + return -ENOMEM; > + > + dev_set_drvdata(dev, phy); > + > + phy->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(phy->clk)) { > + dev_err(dev, "failed to get phy clock\n"); > + return PTR_ERR(phy->clk); > + } > + > + phy->reset = devm_reset_control_get(dev, NULL); > + if (IS_ERR(phy->reset)) { > + dev_err(dev, "failed to get reset control\n"); > + return PTR_ERR(phy->reset); > + } > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + phy->regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(phy->regs)) > + return PTR_ERR(phy->regs); > + > + /* Populate the connector as platform device */ > + ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > + if (ret) > + return ret; > + > + /* > + * Currently the Allwinner USB3 PHY contains only one port, so we > + * only process one connector now. > + */ > + connector_node = of_get_next_child(pdev->dev.of_node, NULL); > + > + if (connector_node) { > + /* Get the platform device */ > + phy->connector_dev = of_find_device_by_node(connector_node); Also of_find_device_by_node takes a reference that needs to be put back in sun50i_usb3_phy_remove() and error paths. So many refs to take care of, everywhere. Hmm. :) I'm just noticing all this now, because I'm writing similar code for HDMI/connector regualtor borrowing from HDMI controller via of_graph. regards, o. > + if (!phy->connector_dev) { > + dev_err(dev, "no device for connector\n"); > + return -ENODEV; > + } > + > + phy->vbus = regulator_get(&phy->connector_dev->dev, "vbus"); > + if (IS_ERR(phy->vbus)) > + return PTR_ERR(phy->vbus); > + } > + > + phy->phy = devm_phy_create(dev, NULL, &sun50i_usb3_phy_ops); > + if (IS_ERR(phy->phy)) { > + dev_err(dev, "failed to create PHY\n"); > + return PTR_ERR(phy->phy); > + } > + > + phy_set_drvdata(phy->phy, phy); > + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + > + return PTR_ERR_OR_ZERO(phy_provider); > +} > + > +static int sun50i_usb3_phy_remove(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct sun50i_usb3_phy *phy = dev_get_drvdata(dev); > + > + if (phy->vbus) > + regulator_put(phy->vbus); > + > + return 0; > +} > + > +static const struct of_device_id sun50i_usb3_phy_of_match[] = { > + { .compatible = "allwinner,sun50i-h6-usb3-phy" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, sun50i_usb3_phy_of_match); > + > +static struct platform_driver sun50i_usb3_phy_driver = { > + .probe = sun50i_usb3_phy_probe, > + .remove = sun50i_usb3_phy_remove, > + .driver = { > + .of_match_table = sun50i_usb3_phy_of_match, > + .name = "sun50i-usb3-phy", > + } > +}; > +module_platform_driver(sun50i_usb3_phy_driver); > + > +MODULE_DESCRIPTION("Allwinner sun50i USB 3.0 phy driver"); > +MODULE_AUTHOR("Icenowy Zheng "); > +MODULE_LICENSE("GPL"); > -- > 2.18.1 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel