From: Shawn Guo <shawnguo@kernel.org>
To: Markus Kueffner <kueffner.markus@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
Date: Thu, 11 Apr 2019 14:54:42 +0800 [thread overview]
Message-ID: <20190411065440.GB26817@dragon> (raw)
In-Reply-To: <1554566420-1008-1-git-send-email-kueffner.markus@gmail.com>
On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 776bfc7..42954ee 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -221,6 +221,14 @@
> >;
> };
>
> + pinctrl_usbotg: usbotg {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> + MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
> + >;
> + };
> +
I know ac97 is out of order, but I still would like to keep pinctrl
nodes sort alphabetically. That said, pinctrl_usbotg should go after
pinctrl_usbh.
> pinctrl_ac97_running: ac97running {
> fsl,pins = <
> MX6QDL_PAD_DI0_PIN2__AUD6_TXD 0x1b0b0
> @@ -294,6 +302,14 @@
> status = "okay";
> };
>
> +&usbotg {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbotg>;
> + fsl,power-line-polarity-active-high;
> + fsl,over-current-polarity-active-low;
Are these two properties supported by upstream bindings and driver?
Shawn
> + status = "okay";
> +};
> +
> &audmux {
> status = "okay";
> };
> --
> 2.1.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 16:00 [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG Markus Kueffner
2019-04-11 6:54 ` Shawn Guo [this message]
2019-04-13 13:19 ` [PATCH v2] " Markus Kueffner
2019-04-13 14:08 ` Fabio Estevam
2019-04-15 9:11 ` Shawn Guo
2019-09-16 13:06 ` Markus Kueffner
2019-09-24 23:09 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411065440.GB26817@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kueffner.markus@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).