From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D6FC10F13 for ; Thu, 11 Apr 2019 18:47:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC18720850 for ; Thu, 11 Apr 2019 18:47:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PQOIq4MP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC18720850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Js7jkt/DC+WAqdLpxpuIf7Jpo+9un1wtapOMixld0j8=; b=PQOIq4MPWgK9GE pslgSpo+/ukgpToZwAXjOYbmREitWehM+SIetkk6T7uQNdzS/G8hdpS7lYCkkydorGv3hFuXHd57k yu5KyX0Xk2OkqLKXGYCpWy7KB6+y6jjzRMsN+Ve12WDVH5QooFa1OLYNWtkGGvjgsxgCNV3Ol8eZr 0JvBA6jEZY3gFrE2AC9/oBa3quddg/chsW64Dri1xuCVTjJO2FiG9sycnTkyEO1pWTFJnYlUYPbkJ ncEBg1KjKLDKaJqygckWPSgb9X1tYvofcy4GGAeb6FYnvNEAd58jUlnfmJLa3B1jO/kJ1lwYE/YGW 8HNGV+d9sCRjB2wjfYgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEeja-0001EN-Qf; Thu, 11 Apr 2019 18:47:38 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEejW-0001Dw-LF for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 18:47:37 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id C529DFB03; Thu, 11 Apr 2019 20:47:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yNUKvVwiefGi; Thu, 11 Apr 2019 20:47:28 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 167F1465F9; Thu, 11 Apr 2019 20:47:28 +0200 (CEST) Date: Thu, 11 Apr 2019 20:47:28 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Lucas Stach Subject: Re: [PATCH] arm64: dts: imx8mq: add GPU node Message-ID: <20190411184728.GA4139@bogon.m.sigxcpu.org> References: <20190404165211.29297-1-l.stach@pengutronix.de> <20190408130729.GA31666@bogon.m.sigxcpu.org> <20190408134540.GA13816@bogon.m.sigxcpu.org> <1554901332.11529.9.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1554901332.11529.9.camel@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_114734_863355_32176A91 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Apr 10, 2019 at 03:02:12PM +0200, Lucas Stach wrote: > Hi Guido, > = > Am Montag, den 08.04.2019, 15:45 +0200 schrieb Guido G=FCnther: > > Hi, > > On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido G=FCnther wrote: > > > Hi Lucas, > > > On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote: > > > > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC. > > > > = > > > > > > > Signed-off-by: Lucas Stach > > > > --- > > > > =A0arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 +++++++++++++++++= +++++ > > > > =A01 file changed, 22 insertions(+) > > > > = > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64= /boot/dts/freescale/imx8mq.dtsi > > > > index 4300781558f6..79d418b4f585 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > @@ -792,6 +792,28 @@ > > > > > > > =A0 }; > > > > > > > =A0 }; > > > > =A0 > > > > > > > > > > + gpu: gpu@38000000 { > > > > > > > + compatible =3D "vivante,gc"; > > > > > > > + reg =3D <0x38000000 0x40000>; > > > > > > > + interrupts =3D ; > > > > > > > + clocks =3D <&clk IMX8MQ_CLK_GPU_ROOT>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0<&clk IMX8MQ_CLK_GPU_SHADER_DI= V>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0<&clk IMX8MQ_CLK_GPU_AXI>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0<&clk IMX8MQ_CLK_GPU_AHB>; > > > > > > > + clock-names =3D "core", "shader", "bus", "reg"; > > > > > > > + assigned-clocks =3D <&clk IMX8MQ_CLK_GPU_CORE_SRC>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0<&c= lk IMX8MQ_CLK_GPU_SHADER_SRC>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0<&c= lk IMX8MQ_CLK_GPU_AXI>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0<&c= lk IMX8MQ_CLK_GPU_AHB>; > > > > > > > + assigned-clock-parents =3D <&clk IMX8MQ_GPU_PLL_OUT>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0<&clk IMX8MQ_GPU_PLL_OUT>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0<&clk IMX8MQ_GPU_PLL_OUT>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0<&clk IMX8MQ_GPU_PLL_OUT>; > > > > > > > + assigned-clock-rates =3D <800000000>, <800000000>, > > > > > > > + =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0<800000000>, <800000000>; > > > > > > > + power-domains =3D <&pgc_gpu>; > > > > + }; > > > = > > > Reviewed-by: Guido G=FCnther > > = > > On a second thought should this have a > > = > > =A0=A0=A0=A0status =3D "disabled"; > = > I disagree. This is a SoC internal peripheral, that has no board level > dependencies other than the voltage rail being connected, so it's fine > to have the node enabled on all systems. This is consistent with what > we did on all previous i.MX SoC DTs. Makes sense. Reviewed-by: Guido G=FCnther = Cheers, -- Guido _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel