From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3ACCC10F11 for ; Sat, 13 Apr 2019 14:38:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4EB42077C for ; Sat, 13 Apr 2019 14:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hQQEasrr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G/wI8KHF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4EB42077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KsMAO+2Jgh/tY2oAVyMivdO6Dx8PWxl4/ge7sO+d5DQ=; b=hQQEasrrC6IYIEUIWVgz1H3vT OU8S9hxzkKmaR4MEQwHoFGxnQkfwixVdx43XcMyue/9+7D76agFVR0i2AOZUvZUcr+Iy6Vvl4qg0E x8ITexo61nMu+05KYCeAmEgT7rc3DoIbQWibwOBfr6or3fsJs4dEF9/bgjnuKEfBnlR+427MfEysZ yRBrHu8YzyuXDAKQPnEDpDaWRxudXidJFTpLqQ1OlwbVlrweuW0AZ3wVjR5tLgmJy+wAf81xFMbCl jxB3kwCKjWCZdq9WdnNN8YFO5P6eX7MBgrKPY+4qaUHoSt729nBp2dE5x4Hg3snbU5omN1awBYUyc e2dT/SjOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFJnI-0006Oe-Dp; Sat, 13 Apr 2019 14:38:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFJnF-0006ON-QU for linux-arm-kernel@lists.infradead.org; Sat, 13 Apr 2019 14:38:11 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDF922077C; Sat, 13 Apr 2019 14:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555166289; bh=eDdpk7OVEkgezpqaRXRb+Tovg4FCFdCUBaBUtTanoBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G/wI8KHF11+XCX8ZvRKt5IAWIIsYojvrDIS0j3Ar/gnfV1xfKpPIl4BmOrAAOOSXi 6eSikcNQYHV1UAgozcaVw4u0yriv3Pp00lWFrg2HRIpoNUZbKbMZLcmcq3pbg711+d X8njMc3oF6GTNotKmtYwreGUhYlVyuKGgXmV6wuM= Date: Sat, 13 Apr 2019 10:38:07 -0400 From: Sasha Levin To: Nicolas Boichat Subject: Re: [PATCH] arm64: kaslr: Reserve size of ARM64_MEMSTART_ALIGN in linear region Message-ID: <20190413143807.GV11568@sasha-vm> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190413_073810_051841_780A13AA X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yueyi Li , Ard Biesheuvel , "catalin.marinas@arm.com" , "markus@oberhumer.com" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , stable@vger.kernel.org, Guenter Roeck , "akpm@linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 13, 2019 at 08:41:33PM +0800, Nicolas Boichat wrote: >Dear stable maintainers, > >I encountered a similar issue on a 4.19.33 kernel (Chromium OS). On my >board, the system would not even be able to boot if KASLR decides to >map the linear region to the top of the virtual address space. This >happens every 253 boots on average (there are 0xfd possible random >offsets, and only the top one fails). > >I tried to debug the issue, and it appears physical memory allocated >for vmemmap and mem_section array would end up at the same location, >corrupting each other early on boot. I could not figure out exactly >why this is happening, but in any case, this patch fixes my issue (no >failure in 744 reboots with 240 unique offsets, and counting...), and >IMHO the ERR_PTR justification in the commit message is enough to >warrant inclusion in -stable branches. > >The patch below was committed to mainline as: >commit c8a43c18a97845e7f94ed7d181c11f41964976a2 > arm64: kaslr: Reserve size of ARM64_MEMSTART_ALIGN in linear region > >and should be included in stable branches after this commit: >Fixes: c031a4213c11a5db ("arm64: kaslr: randomize the linear region") >i.e. anything after kernel 4.5 (git describe says v4.5-rc4-62-gc031a4213c11a5d). I've queued it for 4.9-4.19, thanks for the report. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel