From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85799C10F0E for ; Mon, 15 Apr 2019 09:18:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 562FC2073F for ; Mon, 15 Apr 2019 09:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LF66x/0Y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="bfIvQYOs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 562FC2073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J4iPTtrNvwZFrT5uQNEXtz/bKKR5BJ/H6/yCtJAFhZU=; b=LF66x/0Y+ebmsD vk+WWw7fos5f5j0k4abvda+J+nLay1WunO1SzX9Z3oF/mbdxNzdLyfbG6dT9ByoK0qHuvnhy7XMli uq2Y8LFEIkZ2MufyLsxrhSIbUUal4uL5BukFlKNf5s6rsd+EmW1Pk4KZr3moKjoDh7D0qkInvEwNF eVVeDc4oakj+U8pUWvwP17+OxTVgEKufTRiQAR8WWggi2uleuOdiE9yOMjVzy5Eu+RKk5mxyPo96i WbuSy2t8IAwOb1VKckSyJQ4nYbeKg3PY8zsB8wijs3P2b2uyfjnviVlfAvIE/hTTmYug6BfuLYCc2 WD268p7CszbMpB6tVtRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFxlG-0007sc-5h; Mon, 15 Apr 2019 09:18:46 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFxlC-0007rO-Nv for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 09:18:44 +0000 Received: by mail-ed1-x541.google.com with SMTP id d13so14025430edr.5 for ; Mon, 15 Apr 2019 02:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ynQtq/6aBUoTAipkeDKcQtf7kKsME/OPz6dQg69/ZqA=; b=bfIvQYOsMuRfY7e2nyCsEZp366cC8dWDkDaYDWjxwzxadojySJtksZwssf/48Lk7uf GUHPNRX/ujNQ1QYwPiFyrGwtJaU7VpLIjhP0kl/W9R9YUMRSfK4Gyd8c0Ab6ecPHf9bw kywY6l2dmW2fER/dievAMG/iLNhDovtkvEkX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=ynQtq/6aBUoTAipkeDKcQtf7kKsME/OPz6dQg69/ZqA=; b=Re6LysCtnqVAJ8nOTqJ5aDILxGNwn3Eb8C5g1lmhFOiFBmlutdrrlT5qscjYdUru+0 vZ1EiOjH4WEZsIKWUQtXpn09Kh8JL+jYfq8dunQJQJDNjf2sxpFdqtEbyu1G7IwqEN+Z NpI1feasnn1Q/3+QY1+8391N7PWQz1hXhUxwm+XSmHWd/ww3ItBUZLnGt8eA+KYdX9Xh Qt4x+2ASEDjGPH11DIKp0P7Z1xqk7fJusJAo6H9tUxssNrRvemMq/qW0RSnyAJ+YWyl9 DzNoeV7CIrUrEjJqtiF3LJ/V3KI0r7dr3GHbEk6ekyjpieLJhSIfkGdJFcbLtcNXZGzU RbFQ== X-Gm-Message-State: APjAAAUm8ALFd8exIw3kg/5NAZoW1TG61U6CFrO87OkJ4t3xu4HXIxt/ ASlzpW+u5ES5FaL0hmON6av2ZA== X-Google-Smtp-Source: APXvYqz4bP4buv8PrROHVBzhkpiDUy0i+0wCAHiCT1WKRbo3mf5xVcBaqcpM2rq8dc8Va+iUasniiA== X-Received: by 2002:aa7:ca07:: with SMTP id y7mr14132059eds.149.1555319920740; Mon, 15 Apr 2019 02:18:40 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id b2sm2635652eds.15.2019.04.15.02.18.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 02:18:39 -0700 (PDT) Date: Mon, 15 Apr 2019 11:18:37 +0200 From: Daniel Vetter To: Steven Price Subject: Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver Message-ID: <20190415091837.GV2665@phenom.ffwll.local> Mail-Followup-To: Steven Price , Alyssa Rosenzweig , Tomeu Vizoso , Neil Armstrong , Maxime Ripard , Sean Paul , Will Deacon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , iommu@lists.linux-foundation.org, "Marty E . Plummer" , Robin Murphy , linux-arm-kernel@lists.infradead.org References: <20190401074730.12241-1-robh@kernel.org> <20190401074730.12241-4-robh@kernel.org> <5efdc3cb-7367-65e1-d1bf-14051db5da10@arm.com> <20190405161632.GA9160@rosenzweig.io> <34a7038e-34f0-0cc4-4fc4-9b7dda356df6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <34a7038e-34f0-0cc4-4fc4-9b7dda356df6@arm.com> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_021842_843342_2A615BC0 X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , Neil Armstrong , Maxime Ripard , Robin Murphy , Will Deacon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, "Marty E . Plummer" , Sean Paul , Alyssa Rosenzweig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: > On 05/04/2019 17:16, Alyssa Rosenzweig wrote: > > acronym once ever and have it as a "??"), I'm not sure how to respond to > > that... We don't know how to allocate memory for the GPU-internal data > > structures (the tiler heap, for instance, but also a few others I've > > just named "misc_0" and "scratchpad" -- guessing one of those is for > > "TLS"). With kbase, I took the worst-case strategy of allocating > > gigantic chunks on startup with tiny commit counts and GROW_ON_GPF set. > > With the new driver, well, our memory consumption is scary since > > implementing GROW_ON_GPF in an upstream-friendly way is a bit more work > > and isn't expected to hit the 5.2 window. > > Yes GROW_ON_GPF is pretty much required for the tiler heap - it's not > (reasonably) possible to determine how big it should be. The Arm user > space driver does the same approach (tiny commit count, but allow it to > grow). Jumping in here with a drive through comment ... Growing gem bo and dma-buf is going to be endless amounts of fun, since we hard-coded that their size is invariant. I think the only reasonable way to implement this is if you allocate a really huge bo, map it, but only put the pages in on faulting. Or when really evil userspace tries to export it. Actually changing the underlying buffer size is not going to work I think. Note: I didn't read kbase, so might be totally wrong in how GROW_ON_GPF works. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel