linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: linux-renesas-soc@vger.kernel.org,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: renesas: draak: Remove unecessary index from vin4 port
Date: Wed, 24 Apr 2019 11:57:15 +0200	[thread overview]
Message-ID: <20190424095712.akqypzhnytbc7ev2@verge.net.au> (raw)
In-Reply-To: <20190420084122.GE28515@bigcity.dyn.berto.se>

On Sat, Apr 20, 2019 at 10:41:22AM +0200, Niklas Söderlund wrote:
> Hi Laurent and Simon,
> 
> On 2019-04-20 02:30:49 +0300, Laurent Pinchart wrote:
> > Hi Niklas,
> > 
> > On Wed, Mar 13, 2019 at 02:46:28PM +0100, Niklas Söderlund wrote:
> > > On 2019-03-13 11:51:18 +0100, Simon Horman wrote:
> > > > The ports node of vin4 only has one sub-node and thus does
> > > > not need #address-cells/#size-cells and the sub-node does
> > > > not need an exit.
> > > 
> > > I agree that the warning should be silenced however I have a feeling 
> > > this might need to be tested. The VIN bindings assigns special meaning 
> > > to which port reg an endpoint is described in and handles each of them 
> > > differently, see the biding documentation.
> > > 
> > > As the single port described here is port 0 I think removing the reg 
> > > property will probably work but is it correct? If someone with a Draak 
> > > board could test this patch it would be great!
> > 
> > I've tested this patch, and the media-ctl -p output is identical before
> > and after applying it.
> > 
> > # media-ctl -p -d /dev/media2
> > Media controller API version 5.1.0
> > 
> > Media device information
> > ------------------------
> > driver          rcar_vin
> > model           renesas,vin-r8a77995
> > serial
> > bus info        platform:e6ef4000.video
> > hw revision     0x0
> > driver version  5.1.0
> > 
> > Device topology
> > - entity 1: adv7180 0-0020 (1 pad, 1 link)
> >             type V4L2 subdev subtype Decoder flags 0
> >             device node name /dev/v4l-subdev6
> >         pad0: Source
> >                 [fmt:UYVY8_2X8/720x240 field:alternate]
> >                 -> "VIN4 output":0 []
> > 
> > - entity 5: VIN4 output (1 pad, 1 link)
> >             type Node subtype V4L flags 0
> >             device node name /dev/video5
> >         pad0: Sink
> >                 <- "adv7180 0-0020":0 []
> > 
> > 
> > Please let me know if I should conduct other tests.
> 
> Thanks for testing, no more tests are needed.
> 
> > 
> > Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> It works and the change silence the warning,
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks, applied for v5.3.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-04-24  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 10:51 [PATCH] arm64: dts: renesas: draak: Remove unecessary index from vin4 port Simon Horman
2019-03-13 13:46 ` Niklas Söderlund
2019-04-19 23:30   ` Laurent Pinchart
2019-04-20  8:41     ` Niklas Söderlund
2019-04-24  9:57       ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424095712.akqypzhnytbc7ev2@verge.net.au \
    --to=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).