Re: [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: mark.rutland@arm.com, daniel.lezcano@linaro.org,
	catalin.marinas@arm.com, will.deacon@arm.com,
	bjorn.andersson@linaro.org, mchehab+samsung@kernel.org,
	paulmck@linux.ibm.com, stefan.wahren@i2se.com,
	linux-pm@vger.kernel.org, wens@csie.org,
	jagan@amarulasolutions.com, andy.gross@linaro.org,
	rui.zhang@intel.com, devicetree@vger.kernel.org,
	marc.w.gonzalez@free.fr, edubezval@gmail.com,
	enric.balletbo@collabora.com, robh+dt@kernel.org,
	Jonathan.Cameron@huawei.com,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, olof@lixom.net,
	davem@davemloft.net
Subject: Re: [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller
Date: Sun, 12 May 2019 15:41:52 +0200	[thread overview]
Message-ID: <20190512134152.yrletgtiglxncyo4@flea> (raw)
In-Reply-To: <20190512082614.9045-4-tiny.windzz@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1870 bytes --]

Hi,

On Sun, May 12, 2019 at 04:26:14AM -0400, Yangtao Li wrote:
> This patch adds binding document for allwinner h6 thermal controller.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  .../bindings/thermal/sun50i-thermal.txt       | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/sun50i-thermal.txt

We're starting to convert to YAML for binding descriptions that will
allow to validate that all DT are properly using the binding. It would
be great if you could use it as well.

> diff --git a/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt
> new file mode 100644
> index 000000000000..67eda7794262
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt
> @@ -0,0 +1,32 @@
> +Binding for Thermal Sensor of Allwinner SOC.
> +
> +This describes the device tree binding for the Allwinner thermal controller
> +which measures the on-SoC temperatures.
> +
> +Required properties:
> +- compatible:
> +  - "allwinner,sun50i-h6-ths" : For H6
> +- reg: Address range of the thermal controller
> +- clocks, clock-names: Clocks needed for the thermal controller.
> +		       The required clocks for h6 are: "bus".

If there's a single clock, then we don't need clock-names

> +- resets, reset-names: Reference to the reset controller controlling
> +		       the thermal controller.

Ditto.

> +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
> +	       unspecified default values shall be used.
> +- nvmem-cell-names: Should be "calib"

I thought you said that nvmem support was optional in the
driver. Maybe we could make it optional in the DT too?

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel