From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097A1C04AAF for ; Thu, 16 May 2019 15:48:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D08FB2082E for ; Thu, 16 May 2019 15:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oD8FVhYc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D08FB2082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z+ox6NLlj1cvGwlb3SX0r6fyzedP4MG/7Vqd2Rrd9Oc=; b=oD8FVhYcigVGxt fFX3IT3y5UnK5EnMpynMtMPxni4VWK8hWOfGc9u/wH2V7o2O2iO9t6fXsTIMQori9hZB0rrhBh7tL EkO2xnIV5GeoNhsqi8KPTI6sE14/SnC/36Fur5HjAjVSfF2dM17NCIKMjpcwbVNju6PsCm1P+2PDW zKKIgSAhNeiH9lv7zdCv4DZI9sDPuidTQAUUMFgLlm93ilKmXuHlNS/BRHZR/u0NX+n9355H4yrSO B5F6HWpdaW3iiAIeLjUFB3jgonfr+J5j8QGhTLSchYavusT7jjVT+jOHEW8fhXNkRgQOEBqvc8FDa 2gZam/R9dqHcIKDH7u7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRIci-0002VS-8J; Thu, 16 May 2019 15:48:48 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRIcf-0002UI-5B for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2019 15:48:46 +0000 Received: by newverein.lst.de (Postfix, from userid 2005) id BC11268B02; Thu, 16 May 2019 17:48:20 +0200 (CEST) Date: Thu, 16 May 2019 17:48:20 +0200 From: Torsten Duwe To: Vasily Khoruzhick Subject: Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I Message-ID: <20190516154820.GA10431@lst.de> References: <20190514155911.6C0AC68B05@newverein.lst.de> <20190514160241.9EAC768C7B@newverein.lst.de> <20190515093141.41016b11@blackhole.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190516_084845_351659_489D63B9 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Andrzej Hajda , David Airlie , linux-kernel , dri-devel , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Daniel Vetter , Harald Geyer , Sean Paul , arm-linux , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 15, 2019 at 08:08:57AM -0700, Vasily Khoruzhick wrote: > On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > > > It does comply with the bindings. The ports are all optional. > > As far as DT is concerned, the signal path ends here. This is also the > > final component _required_ to get the Linux kernel DRI up and running. > > Ugh, then bindings should be fixed. It's not optional. It may work if > bootloader enables power for you, but it won't if you disable display > driver in u-boot. I double-checked. On the Teres-I, mentioning the panel _is_ optional. PD23 powers down panel and backlight as much as possible, see 24bd5d2cb93bc arm64: dts: allwinner: a64: teres-i: enable backlight (currently only in Maxime's repo) and the Teres-I schematics... And the driver in your repo neatly guards all accesses with "if (anx6345->panel)" -- good! But I found the Vdds are required, so I added them as such. > I guess you're testing it with older version of anx6345. Newer version > that supports power management [1] needs startup delay for panel. > Another issue that you're seeing is that backlight is not disabled on > DPMS events. All in all, you need to describe panel in dts. > > [1] https://github.com/anarsoul/linux-2.6/commit/2fbf9c242419c8bda698e8331a02d4312143ae2c > > Should I also have added a Tested-by: ? ;-) > > I don't have Teres, so I haven't tested these. *I* have one, and this works. I'll retest with your newer driver, just in case. Nonetheless, the changes in this series should be fine. Sending out v2 in a moment... Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel