From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9CEC04AB4 for ; Fri, 17 May 2019 07:31:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E12120868 for ; Fri, 17 May 2019 07:31:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pol+/+e8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E12120868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zsmYRRlhAT+MbWJSt/smr3PgCaZG5MRaTn14CoLzfwc=; b=pol+/+e8tX3wgNIIxEl02nv2F SuCLdAxXQ/9XDA/LbsZEf84vlM7IID1kZ3pbv5wjeqyaYfQDVy0IeV99q/M+Ql8kewdKaQMnLast4 ZeJ4hHhhI9Ke9hLUCX40EThOWG0t906BCpX9QHeGZT2g8Abf5IIJjyvJCyZu7/CDPRZ0tHpd12G3/ m7qsaTDAkqqv4GAhltHdlV9lUmaGi63o2lEr0yLsRLlU3XCBkfVze+T1l7mYtUG6tOliSWTJXVHtO mf07MVoFN8/wfjVyAtw5VEwR6veQaz3HmWqrMKK5o/UsoEHmg0fzJUHz2Y9Kge/rlaugN+NPoXGoP a7SjRXbxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRXKR-0000P5-WA; Fri, 17 May 2019 07:30:56 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRXKO-0000Of-9R for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2019 07:30:54 +0000 X-Originating-IP: 80.215.154.25 Received: from localhost (unknown [80.215.154.25]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3C582E0006; Fri, 17 May 2019 07:30:48 +0000 (UTC) Date: Fri, 17 May 2019 09:30:48 +0200 From: Maxime Ripard To: Jernej Skrabec Subject: Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT Message-ID: <20190517073048.y6mzgbhhryfmuckl@flea> References: <20190516161039.18534-1-jernej.skrabec@siol.net> MIME-Version: 1.0 In-Reply-To: <20190516161039.18534-1-jernej.skrabec@siol.net> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190517_003052_594010_91415057 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6339453871213117169==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6339453871213117169== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jkbi65rx3dzh424y" Content-Disposition: inline --jkbi65rx3dzh424y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote: > mmc1 node where wifi module is connected doesn't have properly defined > power supplies so wifi module is never powered up. Fix that by > specifying additional power supplies. > > Additionally, this STB may have either Realtek or Broadcom based wifi > module. One based on Broadcom module also needs external clock to work > properly. Fix that by adding clock property to wifi_pwrseq node. > > Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB") > Signed-off-by: Jernej Skrabec > --- > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > index 6277f13f3eb3..6a0ac85b4616 100644 > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > @@ -89,7 +89,10 @@ > > wifi_pwrseq: wifi_pwrseq { > compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; pinctrl-names only make sense with another pinctrl-[0-255] property. Did you forgot something here? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --jkbi65rx3dzh424y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXN5jKAAKCRDj7w1vZxhR xUr9AP97UzodMbd7XRkMSWOZH5h4GuNferFgLYoAMM0yGXZWrwD6AwhGz1w7cehv pfHluFzjaOLCt4LLQWUiDAMaW2+Y0wU= =ocrv -----END PGP SIGNATURE----- --jkbi65rx3dzh424y-- --===============6339453871213117169== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6339453871213117169==--