From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30A7C04AB4 for ; Fri, 17 May 2019 21:53:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B48402133D for ; Fri, 17 May 2019 21:53:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Po/e6gJH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B48402133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ilZebp7Nn7KTTey8xsDYy3FiavEzpgpltZCYLrC/27Q=; b=Po/e6gJHtJigTF RJj7WlXunTymPP528QGL4YkLzZzjjijpCIe+0xm02AymXYdnVJLCkv0imhVO1VwNZnNp9p5aIpvvP thyJep98pYfYb/q41bBwm31z6mvCcXOcrTY8FxYmKhzmrjSltjy7kHvshQ+bbARyO3ye1L8O7rd12 1Q6Vxd2tIlFDk5WktM+FGTG+IFN4Cev06nUqDVtmLwEE5t7MrXDX6pHWVlgODOMr7FVGPAeJLeKFY aFZKxst2opjWEbcrwn+vLMp7l8z7gB6ed4kSfhVFKPG2Lz6jhNb2aUEoT/92RVMs4krexaWjC1KL+ diwGNmymaJX+Rm6BmA5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRkmv-0002LS-Ko; Fri, 17 May 2019 21:53:13 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRkms-0002Kk-3x for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2019 21:53:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99A151715; Fri, 17 May 2019 14:53:08 -0700 (PDT) Received: from mbp (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73CCD3F71E; Fri, 17 May 2019 14:53:07 -0700 (PDT) Date: Fri, 17 May 2019 22:53:04 +0100 From: Catalin Marinas To: Mark Salyzyn Subject: Re: [PATCH] arch64: export __flush_dcache_area Message-ID: <20190517215303.3daebi7o66we2cjh@mbp> References: <20190517200012.136519-1-salyzyn@android.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190517200012.136519-1-salyzyn@android.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190517_145310_175207_E542D8EB X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 17, 2019 at 12:59:56PM -0700, Mark Salyzyn wrote: > Some (out of tree modular) drivers feel a need to ensure > data is flushed to the DDR before continuing flow. > > Signed-off-by: Mark Salyzyn > Cc: linux-kernel@vger.kernel.org > Cc: kernel-team@android.com > --- > arch/arm64/mm/cache.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S > index a194fd0e837f..70d7cb5c0bd2 100644 > --- a/arch/arm64/mm/cache.S > +++ b/arch/arm64/mm/cache.S > @@ -120,6 +120,7 @@ ENTRY(__flush_dcache_area) > dcache_by_line_op civac, sy, x0, x1, x2, x3 > ret > ENDPIPROC(__flush_dcache_area) > +EXPORT_SYMBOL_GPL(__flush_dcache_area) > > /* > * __clean_dcache_area_pou(kaddr, size) NAK. Such drivers are doing something wrong, there is a dedicated in-kernel API for that handles kernel maintenance (hint: DMA). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel