From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7AF0C04AAF for ; Sat, 18 May 2019 10:36:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC48A20B7C for ; Sat, 18 May 2019 10:36:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nGesHdj4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zHTz8ROx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC48A20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OMAGmtAGp1Nk5fpj6Cpgf+USa+0BJz6h+1pujo45cgE=; b=nGesHdj4E1Eo76 YZy8dDv23Yx1hnSm91E1xe6O9OJ9IDy867eYNMboWDs2qZ+2FBBjOD0hYQa4B6y/VD6Y4uvkFHbuO 0m9koJfvWQdRifssgqv0nuiPdC81FcFD52yj6lbyNmS3owIxQ20HzfulSEft9TzXotzkkr4MmWYfy nlHXMgDVFKDB0TBihhiL5a/I5U0AijRAWnb1lEmmyufUQR1m/wWhTAe8vom7CCglMDTJvF+ndSAZy gUmgI/agwHeg/hvsr9XC4XmC/HMsptMSswJIu1zYJLKm8HjtxSc0UUClSMGCTbeNsMibrVLjcUAdN EmntGqP9fy7rMVOz0r9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRwhy-0002LS-9f; Sat, 18 May 2019 10:36:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRwhv-0002KZ-93; Sat, 18 May 2019 10:36:52 +0000 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE78A2087E; Sat, 18 May 2019 10:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558175809; bh=M1cIR0VtB3TnODl/YmcCk/DeYpsOPIWvqiJuH+ZAFUs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zHTz8ROxUjXgte53XjHgXP5dkTZVEV0pmQckU89uK6+MPaGeN9/N+brp4jDieoyoc k2r6IvTw63gXs8CGpigA7dRWuBeYJkFp5YI+lk10B1P8VTMnmpDlB1s46MDMveWw6h 0Z9DOouy3lTGmuty10y5oQom+ftK+0O+NPUuqhi4= Date: Sat, 18 May 2019 11:36:43 +0100 From: Jonathan Cameron To: Chun-Hung Wu Subject: Re: [PATCH 4/4] iio: auxadc: mediatek: change to subsys_initcall Message-ID: <20190518113643.53a42976@archlinux> In-Reply-To: <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-5-git-send-email-chun-hung.wu@mediatek.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190518_033651_331527_C309A24F X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , wsd_upstream@mediatek.com, linux-iio@vger.kernel.org, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, Peter Meerwald-Stadler , Hartmut Knaack , Matthias Brugger , jg_poxu@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 May 2019 16:10:47 +0800 Chun-Hung Wu wrote: > Move auxadc platform_driver_register() from module_init > to subsys_initcall because auxadc user drivers > are all moudle drivers, need to gurantee > auxadc driver ready before module_init. > Is it not possible to make them use deferred handling to come back later if this isn't yet available? subsys_initcall often ends up being a more fragile approach. Thanks, Jonathan > Signed-off-by: Chun-Hung Wu > --- > drivers/iio/adc/mt6577_auxadc.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > index 58d7cb2..cb8e3dd 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -350,7 +350,19 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > .probe = mt6577_auxadc_probe, > .remove = mt6577_auxadc_remove, > }; > -module_platform_driver(mt6577_auxadc_driver); > + > +static int __init mt6577_auxadc_init(void) > +{ > + return platform_driver_register(&mt6577_auxadc_driver); > +} > + > +static void __exit mt6577_auxadc_exit(void) > +{ > + platform_driver_unregister(&mt6577_auxadc_driver); > +} > + > +subsys_initcall(mt6577_auxadc_init); > +module_exit(mt6577_auxadc_exit); > > MODULE_AUTHOR("Zhiyong Tao "); > MODULE_DESCRIPTION("MTK AUXADC Device Driver"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel