From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4A5C04AAC for ; Mon, 20 May 2019 14:44:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FE652054F for ; Mon, 20 May 2019 14:44:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jDJ5aJrU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FE652054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Sq6mKjm5G52QE2/no3VwZhP1bm5TRMutwGj7oBSk50=; b=jDJ5aJrUTu7amBEI1nHJLtKSu sfGEYyQCtJy4zBOYZpBGmejRsXjbAWq/8G69njfWMdb4o8wOCtIWPZShgeJ4I2xkBIUxHlmMxSFTD PZIXHylVFo6fE3FfIPXmIx5keftQkP5uHJxBgldWufeA5m90WgM8lhIQPOKARmCvZa4fnBYvMYHd5 YkMpllBzfNMNoVRV7XQQw9yZenCxQJIXIVJgAzqX1BAXfOgj5fInb3/g+Ln8l0Ofb3TTboRHW2xT6 ZJPWtSPKzABzt9p/+cqkx0/lcbOm/5eKZyEqqXTbkkmomzvdaCIcazYUGbFR9ewnVXIa75+OKZqxL fJqJ0jYCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSjWN-0005oA-FW; Mon, 20 May 2019 14:44:11 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSjWJ-0005no-QV for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2019 14:44:09 +0000 X-Originating-IP: 90.88.22.185 Received: from localhost (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id F0B831BF216; Mon, 20 May 2019 14:44:04 +0000 (UTC) Date: Mon, 20 May 2019 16:44:04 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v3 2/4] arm64: dts: allwinner: h6: add watchdog node Message-ID: <20190520144404.zprbuqt3d7uuxgr2@flea> References: <20190518152355.11134-1-peron.clem@gmail.com> <20190518152355.11134-3-peron.clem@gmail.com> <20190520073652.itk452vrpnicta5v@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_074408_014540_690D4077 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , linux-watchdog@vger.kernel.org, linux-kernel , Chen-Yu Tsai , Rob Herring , linux-arm-kernel , Wim Van Sebroeck , Guenter Roeck Content-Type: multipart/mixed; boundary="===============4978933016158731337==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4978933016158731337== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ilnq5ytbw3qmunv6" Content-Disposition: inline --ilnq5ytbw3qmunv6 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 20, 2019 at 10:21:40AM +0200, Cl=E9ment P=E9ron wrote: > Hi, > > On Mon, 20 May 2019 at 09:36, Maxime Ripard w= rote: > > > > On Sat, May 18, 2019 at 05:23:53PM +0200, Cl=E9ment P=E9ron wrote: > > > Allwinner H6 has a watchog node which seems broken > > > on some boards. > > > > > > Test has been performed on several boards. > > > > > > Chen-Yu Tsai boards: > > > Pine H64 - H6448BA 7782 =3D> OK > > > OrangePi Lite 2 - H8068BA 61C2 =3D> KO > > > > > > Martin Ayotte boards: > > > Pine H64 - H8069BA 6892 =3D> OK > > > OrangePi 3 - HA047BA 69W2 =3D> KO > > > OrangePi One Plus - H7310BA 6842 =3D> KO > > > OrangePi Lite2 - H6448BA 6662 =3D> KO > > > > > > Cl=E9ment P=E9ron board: > > > Beelink GS1 - H7309BA 6842 =3D> KO > > > > > > As it seems not fixable for now, declare the node > > > but leave it disable with a comment. > > > > > > Signed-off-by: Cl=E9ment P=E9ron > > > > If it doesn't work most boards, then why do we need to merge that > > patch in the first place? > > My personnal opinion, is that having the IP declared and disabled with > a comment saying "it's broken on some boards" in the device-tree is > better than not having at all. > > This will explicit say "the IP exist but don't use it!". > Maybe some people with a functionnal board would like to explicitly > use it on their dts. Yeah, that makes sense. Chen-Yu, any opinion on the matter? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ilnq5ytbw3qmunv6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOK9NAAKCRDj7w1vZxhR xTPcAP41As2dmsqJWuZDGwrGeXjz5+67O+gfyWMVpwNTjBfB3wD+LDkh8o3xUFs7 x5b2IjWeOW15lbD6dJpdtyxuRX4coQg= =178x -----END PGP SIGNATURE----- --ilnq5ytbw3qmunv6-- --===============4978933016158731337== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4978933016158731337==--