From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD6FC04AAC for ; Mon, 20 May 2019 17:17:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 149A620675 for ; Mon, 20 May 2019 17:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fol3hJxr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u/hk7dvb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 149A620675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vV9NYzaLK7DjCGTKUQInLX0aTf2v2A2hn4ogFFRwXm8=; b=Fol3hJxrzQf3qe Dw5+9+dHTdCyku60mc2rFNeZGLLeLBxmd0U1RUiuDBhbRmLQhpcw8gLmeQP7q0SHcuKj7qk4b2bwX b2Kne3Z84xBT6i0mYopnA9hxV6cqzeF8l7oafFTeEbA8wN66+Px9OXR8ImpfsiiZEzqd6S4XNIxpD I1Qw12Uc17zKhXNCHf3DbTveKftaqJJMfXEp+N6XkUUk1M1uU0VZV3TOuQu4G1OONQcRt+m3tqXnW xxhXuy5IFmTN46cLXZjj2n18fpgRc975NoWXdLA+U5U2Nv0iqY5zFrK11B5j3NeiJ2EMtcVYL+bEf xHQUTRQalUDa0NYhj5dA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSluW-00047T-Lr; Mon, 20 May 2019 17:17:16 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSluT-00046a-J9 for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2019 17:17:14 +0000 Received: by mail-pl1-x643.google.com with SMTP id w7so7027130plz.1 for ; Mon, 20 May 2019 10:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ScUZ/xpgU2aTY1Nb5OViipRU9LRxmOkzl5eEkgamu+4=; b=u/hk7dvb2PAmI5IFI5yr57lW7tUAYqA5xkIZlFRA5Iv/dRJt+p39pMkD0Bbt5qf4xm Ytjuma54OmHG5jIU3bN5wO/eY8VWRtz0gJlwP6zFmUgNcYs+mH6Wj84zJgnnEt+xtn8Y VHxtGaYR2PRh6e/C0ppGWI+o87sfWKSQZr81kvBh5mmB9bbMed3sf/+93nClSlMc0Wq5 PrH18U4Q6YvGpYLGx+O3rkDw77jUQ1FUjjDKpN3+cDiUp//siqAyubcvryZIFP4kSKnw +uKYUBZOwsvbFWWxAJ4ClKclBe4NPg6OZZS166JxwXbmTRur4MYX2NdkwpLfrOunPAjC 5Hwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ScUZ/xpgU2aTY1Nb5OViipRU9LRxmOkzl5eEkgamu+4=; b=FtEIa9cMRzyZ2yZpHEbj1H2/4T//AcTu+OB7Zud4nghAWZb2nyCKa4COzOXbk53cOu nq73OPz8GgLtikpSztE7zcod7Vnax5c3oefZG6ntkeUvrxnWlixnNdI4Thp7mTWfJQjl VXb4Coqwp2E4YA9FiJvUJJTxT3CAE5cl4IJM2lgEHaH6bb2XdIo0ZSl2Cpd/d9yQX2nH erE8F/O46pNhTuQR6GQTsufkhaCUBN0fSAPalX2AVW3mRAn0wVgZBBhwHG60wz/9xfCm ipF6rk+6TJ8X8X4hqKUd7NS2J6d0Kfdoy1Gz3J51iq1kzlAKgry2AArq+Mdb2fj5A3gp 52Hw== X-Gm-Message-State: APjAAAXDhoWVDQVnPa9btQ8dy/pevSjfFNQRESn/cUTcpppekdAjdcO4 sUNGAIp/0fFe6B1gEPRqw97s4w== X-Google-Smtp-Source: APXvYqxJH9e/9PMebXHaD9faSRZhhWJCU9i4asOXuPPssxo8pt9GHh9pom+TaB6TkWIjSBUjbqJe9Q== X-Received: by 2002:a17:902:24c7:: with SMTP id l7mr27347835plg.192.1558372632896; Mon, 20 May 2019 10:17:12 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id m12sm15083945pgi.56.2019.05.20.10.17.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 10:17:12 -0700 (PDT) Date: Mon, 20 May 2019 10:17:39 -0700 From: Bjorn Andersson To: Alex Elder Subject: Re: [PATCH 6/8] net: qualcomm: rmnet: get rid of a variable in rmnet_map_ipv4_ul_csum_header() Message-ID: <20190520171739.GU2085@tuxbook-pro> References: <20190520135354.18628-1-elder@linaro.org> <20190520135354.18628-7-elder@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190520135354.18628-7-elder@linaro.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_101713_632357_48F716EA X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syadagir@codeaurora.org, ejcaruso@google.com, arnd@arndb.de, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, evgreen@chromium.org, david.brown@linaro.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, subashab@codeaurora.org, davem@davemloft.net, cpratapa@codeaurora.org, benchan@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 20 May 06:53 PDT 2019, Alex Elder wrote: > The value passed as an argument to rmnet_map_ipv4_ul_csum_header() > is always an IPv4 header. Just have the type of the argument > reflect that rather than obscuring that with a void pointer. Rename > it to be consistent with rmnet_map_ipv6_ul_csum_header(). > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > index a95111cdcd29..61b7dbab2056 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > @@ -203,26 +203,25 @@ static void rmnet_map_complement_ipv4_txporthdr_csum_field(void *iphdr) > } > > static void > -rmnet_map_ipv4_ul_csum_header(void *iphdr, > +rmnet_map_ipv4_ul_csum_header(struct iphdr *ip4hdr, > struct rmnet_map_ul_csum_header *ul_header, > struct sk_buff *skb) > { > - struct iphdr *ip4h = iphdr; > u16 offset; > u16 val; > > - offset = skb_transport_header(skb) - (unsigned char *)iphdr; > + offset = skb_transport_header(skb) - (unsigned char *)ip4hdr; > ul_header->csum_start_offset = htons(offset); > > val = u16_encode_bits(skb->csum_offset, RMNET_MAP_UL_CSUM_INSERT_FMASK); > val |= RMNET_MAP_UL_CSUM_ENABLED_FMASK; > - if (ip4h->protocol == IPPROTO_UDP) > + if (ip4hdr->protocol == IPPROTO_UDP) > val |= RMNET_MAP_UL_CSUM_UDP_FMASK; > ul_header->csum_info = htons(val); > > skb->ip_summed = CHECKSUM_NONE; > > - rmnet_map_complement_ipv4_txporthdr_csum_field(iphdr); > + rmnet_map_complement_ipv4_txporthdr_csum_field(ip4hdr); > } > > #if IS_ENABLED(CONFIG_IPV6) > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel