linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <christian@brauner.io>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] open: add close_range()
Date: Tue, 21 May 2019 15:12:52 +0200	[thread overview]
Message-ID: <20190521131251.7qxjrxv2v26idd4u@brauner.io> (raw)
In-Reply-To: <aa87e4b1-42ee-52fc-8168-04413dadb460@free.fr>

On Tue, May 21, 2019 at 03:07:57PM +0200, Marc Gonzalez wrote:
> [ Trimming recipients ]
> 
> On 21/05/2019 13:34, Christian Brauner wrote:
> 
> > For extra paranoia close_range() comes with a flags argument. This can e.g.
> > be used to implement extension. Once can imagine userspace wanting to stop
> 
> s/Once/One/ ?

Thanks!

> 
> > diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl
> > index aaf479a9e92d..0125c97c75dd 100644
> > --- a/arch/arm/tools/syscall.tbl
> > +++ b/arch/arm/tools/syscall.tbl
> > @@ -447,3 +447,4 @@
> >  431	common	fsconfig			sys_fsconfig
> >  432	common	fsmount				sys_fsmount
> >  433	common	fspick				sys_fspick
> > +435	common	close_range			sys_close_range
> 
> For my information, why did you skip 434?

That's taken by pidfd_open(). The syscall number here also isn't fixed.
There's another pile of mount api syscalls (in addition to the ones that
landed in 5.2) coming up. So if this is something we want, David and I
need to coordinate the numbers anyway.
I think you can safely wait with acking this until it is even clear that
this is something we would like to go forward with.
Just in line with Arnd's syscall numbering changes I tend to try and add
the number everywhere at the same time.

Christian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-21 13:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 11:34 [PATCH 1/2] open: add close_range() Christian Brauner
2019-05-21 11:34 ` [PATCH 2/2] tests: add close_range() tests Christian Brauner
2019-05-21 12:09 ` [PATCH 1/2] open: add close_range() Florian Weimer
2019-05-21 13:04   ` Christian Brauner
2019-05-21 13:10     ` Florian Weimer
2019-05-21 13:18       ` Christian Brauner
2019-05-21 13:23       ` Christian Brauner
2019-05-21 13:07 ` Marc Gonzalez
2019-05-21 13:12   ` Christian Brauner [this message]
2019-05-21 15:00 ` Al Viro
2019-05-21 16:53   ` Christian Brauner
2019-05-21 16:30 ` David Howells
2019-05-21 16:41   ` Christian Brauner
2019-05-21 20:23     ` Linus Torvalds
2019-05-22  8:12       ` Christian Brauner
2019-05-21 19:20   ` Al Viro
2019-05-21 19:59     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521131251.7qxjrxv2v26idd4u@brauner.io \
    --to=christian@brauner.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.w.gonzalez@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).