Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] arm: add missing include <linux/elf-randomize.h>
@ 2019-05-21 15:54 Philippe Mazenauer
  2019-05-21 20:23 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mazenauer @ 2019-05-21 15:54 UTC (permalink / raw)
  Cc: Kees Cook, Ard Biesheuvel, Russell King, open list,
	Masahiro Yamada, Philippe Mazenauer, moderated list:ARM PORT,
	Andrew Morton, Kirill A. Shutemov

Include corresponding header file <linux/elf-randomize.h> for function
arch_randomize_brk().

../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
 unsigned long arch_randomize_brk(struct mm_struct *mm)
               ^~~~~~~~~~~~~~~~~~

Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
---
 arch/arm/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 72cc0862a30e..73782012d403 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -23,6 +23,7 @@
 #include <linux/interrupt.h>
 #include <linux/init.h>
 #include <linux/elfcore.h>
+#include <linux/elf-randomize.h>
 #include <linux/pm.h>
 #include <linux/tick.h>
 #include <linux/utsname.h>
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: add missing include <linux/elf-randomize.h>
  2019-05-21 15:54 [PATCH] arm: add missing include <linux/elf-randomize.h> Philippe Mazenauer
@ 2019-05-21 20:23 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-05-21 20:23 UTC (permalink / raw)
  To: Philippe Mazenauer
  Cc: Ard Biesheuvel, Russell King, open list, Masahiro Yamada,
	Kirill A. Shutemov, Andrew Morton, moderated list:ARM PORT

On Tue, May 21, 2019 at 03:54:36PM +0000, Philippe Mazenauer wrote:
> Include corresponding header file <linux/elf-randomize.h> for function
> arch_randomize_brk().
> 
> ../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
>  unsigned long arch_randomize_brk(struct mm_struct *mm)
>                ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>

Acked-by: Kees Cook <keescook@chromium.org>

> ---
>  arch/arm/kernel/process.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 72cc0862a30e..73782012d403 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -23,6 +23,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/init.h>
>  #include <linux/elfcore.h>
> +#include <linux/elf-randomize.h>
>  #include <linux/pm.h>
>  #include <linux/tick.h>
>  #include <linux/utsname.h>
> -- 
> 2.17.1
> 

-- 
Kees Cook

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 15:54 [PATCH] arm: add missing include <linux/elf-randomize.h> Philippe Mazenauer
2019-05-21 20:23 ` Kees Cook

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox