From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BBFC04AAF for ; Tue, 21 May 2019 12:15:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A666217D7 for ; Tue, 21 May 2019 12:15:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N9Ny6bHB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A666217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gee79I8ZuEJaP8sq6dpT8VD6rlJoSAI1IBA2itw9zO8=; b=N9Ny6bHB7IBy9BMseOmLKuXvF Vzqrn65dVxn2Ts5h9AUYEeo0zPSVrbKZl5FOLMrjtFK58Y2BZuYhvXM6N5KwhrChj64i7/9KUFMpq JsIUwgbYZGvUzCAjMdDe78JLX7K4m8v8x5L8MYRgvKViSL8EWHhlaVs332bQ79jJiIwEg5ngMztRt dRqfya3YH6pCjoXOTbaQVt2CThftn5X2vvD+MiOMHdyT0xLahMp2V3JMiGGCOM00dc8CZPMj2s3bb jXwHSBZK3/nqgzw0hwTqFGHiYIFKgqggORx9rwK3aYKFTzZWWzIHD1QSnVtIeavh2FHaDtWW3cJIN PEHaN/7ug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT3fq-0001WB-H3; Tue, 21 May 2019 12:15:18 +0000 Received: from smtp2.provo.novell.com ([137.65.250.81]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT3fn-0001V9-H4; Tue, 21 May 2019 12:15:17 +0000 Received: from ezekiel.suse.cz (prva10-snat226-2.provo.novell.com [137.65.226.36]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Tue, 21 May 2019 06:15:04 -0600 Date: Tue, 21 May 2019 14:14:56 +0200 From: Petr Tesarik To: Nicolas Saenz Julienne Subject: Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb Message-ID: <20190521141456.46f6d4a7@ezekiel.suse.cz> In-Reply-To: <46004f242c2618a185445630580116c772455613.camel@suse.de> References: <20190520104708.11980-1-nsaenzjulienne@suse.de> <20190520104708.11980-4-nsaenzjulienne@suse.de> <1558356237.12672.3.camel@suse.com> <46004f242c2618a185445630580116c772455613.camel@suse.de> Organization: SUSE Linux X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_051515_619275_47C4E10B X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org, Scott Branden , linux-pm@vger.kernel.org, sboyd@kernel.org, Ray Jui , mturquette@baylibre.com, Oliver Neukum , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, viresh.kumar@linaro.org, linux-clk@vger.kernel.org, mbrugger@suse.de, ssuloev@orpaltech.com Content-Type: multipart/mixed; boundary="===============0930731777838980654==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: --===============0930731777838980654== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/v4zFxgx_udbNpFsK480f9ms"; protocol="application/pgp-signature" --Sig_/v4zFxgx_udbNpFsK480f9ms Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 21 May 2019 13:39:31 +0200 Nicolas Saenz Julienne wrote: > Hi Oliver, thanks for the review. >=20 > On Mon, 2019-05-20 at 14:43 +0200, Oliver Neukum wrote: > > On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote: =20 > > > + * For more information on the firmware interface check: > > > + * https://github.com/raspberrypi/firmware/wiki/Mailbox-property-int= erface > > > + */ > > > +struct bcm2835_firmware_prop { > > > + u32 id; > > > + u32 val; > > > + u32 disable_turbo; > > > +} __packed; =20 > >=20 > > Hi, > >=20 > > technically we are not in arch and those fields have a defined > > endianness. > > =20 >=20 > Well I set it as packed since it's 'sent' through a memory mapped firmware > interface. Hence the need for the structure format to be fixed. So I gues= sed > we're safer with it, as I'm not 100% sure what the different compilers are > going to do with it (although it's very likely it'll stay the same). BTW = this > will be built both for arm & arm64. I believe that's not the point Oliver was trying to make. You should use __le32 instead of u32. That's because u32 means "host byte order" and this code is not located under arch/, so host endianness is unknown, but the mailbox interface requires little-endian. It's nit-picking, and that's why Oliver writes 'technically'; there is probably no way this firmware interface could be used on a big-endian CPU... Petr T --Sig_/v4zFxgx_udbNpFsK480f9ms Content-Type: application/pgp-signature Content-Description: Digitální podpis OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHl2YIZkIo5VO2MxYqlA7ya4PR6cFAlzj68AACgkQqlA7ya4P R6f62AgAz0n5U8DxFLjG8+/3CYeQR5ZyeBY4k4i59x0CtEHzdc/KpzHUMeMk4UY4 CX0BTMxH8rszNyr01dpGqYDlRUJTZg+WCs+V9N8ZWDafcI9+ZFoZPTOAZumw4o5g q7Y4Gpip+ygMHVSrds+uFQkJtinN7eiyr16GR8TLsb55TjYwiaodn4iNRiR3o+Od qhUwScebGj4vjjru+U0XyYUGUaL22vuKXx8j15aSEO+FB7qYCxs6QbhF33wLvP9T V7BUmamRLwoNqL1YPgj9RSC73PHPQpWKSCvwi2HcK4eUdwC3GNtfLwId+0ocxqwg pFEsVHZTqhV18UWpMD/Pnb5Z39zFRQ== =z3QT -----END PGP SIGNATURE----- --Sig_/v4zFxgx_udbNpFsK480f9ms-- --===============0930731777838980654== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0930731777838980654==--