From: Herbert Xu <herbert@gondor.apana.org.au>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: "open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH] crypto: arm/sha512 - make function static
Date: Thu, 23 May 2019 13:38:49 +0800 [thread overview]
Message-ID: <20190523053849.u2rpdk5ddafrkcnx@gondor.apana.org.au> (raw)
In-Reply-To: <VI1PR07MB44324EFEF57062FCCA758358FD000@VI1PR07MB4432.eurprd07.prod.outlook.com>
On Wed, May 22, 2019 at 10:07:14AM +0000, Philippe Mazenauer wrote:
> Function sha512_arm_final() is only used in this file, therefore should
> be static
>
> ../arch/arm/crypto/sha512-glue.c:40:5: warning: no previous prototype for ‘sha512_arm_final’ [-Wmissing-prototypes]
> int sha512_arm_final(struct shash_desc *desc, u8 *out)
> ^~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
An identical patch is already in the patchwork queue.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-23 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 10:07 [PATCH] crypto: arm/sha512 - make function static Philippe Mazenauer
2019-05-23 5:38 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523053849.u2rpdk5ddafrkcnx@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=philippe.mazenauer@outlook.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).