From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11D2C282DE for ; Thu, 23 May 2019 19:19:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 881A7217D9 for ; Thu, 23 May 2019 19:19:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nRGbipPv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 881A7217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U6aBAno6wMVsiwuucO1Fquvs6/T8MRAO2ugptMemWzk=; b=nRGbipPvGl+0Ql sfC7WANDaTdtaHKgSYKaWjyxhshtXz4jhOem/M7giiwDNJUywnZQkq0vWci390TM2cIvYo9VEH5XX niACQ2g4JagEQ0JdRLCnrdJAbstjSEYC81RL5gNATxLytSoHkuhF2gC5W9ZwgAlJ8gUiV4IcPySi9 5NhdnjlXW2RtAT/hDinBpc9TVWIZESVw8Y+XgnFRnAaoIAhjAKQ1GRNNEXelKRFiz21sAatww1WGI +Js1rk+7Jys56gMXxjVRD3x75NDcm+2ZpbmK3z7QsMjZeQgH5ZUj7EIOP6Pt+b5UFDaku76gpvDBV 4kFVs9Np1QKDnNiXVWEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTtFe-0002Rc-4z; Thu, 23 May 2019 19:19:42 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTtFa-0002Q7-0S for linux-arm-kernel@lists.infradead.org; Thu, 23 May 2019 19:19:39 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 26E8F803D1; Thu, 23 May 2019 21:19:25 +0200 (CEST) Date: Thu, 23 May 2019 21:19:26 +0200 From: Pavel Machek To: "Angus Ainslie (Purism)" Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit Message-ID: <20190523191926.GB3803@xo-6d-61-c0.localdomain> References: <20190520142330.3556-1-angus@akkea.ca> <20190520142330.3556-3-angus@akkea.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190520142330.3556-3-angus@akkea.ca> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_121938_199950_296C697F X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , angus.ainslie@puri.sm, Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > - LEDs > - gyro > - magnetometer > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_leds>; > + > + led1 { > + label = "LED 1"; So, what kind of LED do you have, and what color is it? label should probably be something like notify:green. > + charger@6b { /* bq25896 */ > + compatible = "ti,bq25890"; > + reg = <0x6b>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger>; > + interrupt-parent = <&gpio3>; > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > + ti,battery-regulation-voltage = <4192000>; /* 4.192V */ > + ti,charge-current = <1600000>; /* 1.6 A */ No space before A, for consistency. > + ti,termination-current = <66000>; /* 66mA */ > + ti,precharge-current = <1300000>; /* 1.3A */ I thought precharge is usually something low, because you are not yet sure of battery health...? > + ti,minimum-sys-voltage = <2750000>; /* 2.75V */ Are you sure? Normally systems shut down at 3.2V, 3V or so. Li-ion batteries don't really like to be discharged _this_ deep. Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel