From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39E4C04AB6 for ; Tue, 28 May 2019 05:19:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8949B208CB for ; Tue, 28 May 2019 05:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nuSa52Vp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ALnyFScM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8949B208CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GssEIp6abdifGT3MtDJ3GE2mt0/W48ryhnRDfSSDUzQ=; b=nuSa52VpGRGmYH CWH8Kd2r66fntE09nyIQS8s6tgUsRT3/yV+hC9ZxlAi1v3F3a/1VSvfBgRbAtVhkgBeZBEHOw9EYJ LE12CoZvvRy8ElwIsS0u83LgetXtGghtIoQ+GJhNsFOdLiYGzzHtyyiNh67HyriXmXq6DqvuDLQ3N Xrr4bnJxcd9g2gU+j6MvedhuEWMd9fTOIA6zQm7U2Pg0iyudiv92JqCDtGeqUUbGhhqt2hK1ETe8x nhgay6mEmH4Au9ywP9iXum6+fJYXt5/tqIpaolOcuhFoVC/0BYlRXIGVwXHdgAoYpOGIV15Aftx5d RJXmCXTusrSxKUBjKF5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVUWQ-0003z3-37; Tue, 28 May 2019 05:19:38 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVUWM-0003yA-RP for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 05:19:36 +0000 Received: by mail-qk1-x741.google.com with SMTP id w187so10385977qkb.11 for ; Mon, 27 May 2019 22:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d9vAkjT4zw1XDm8fsnSZlNEkjl4Nf7vHSlfSiY9KNso=; b=ALnyFScMHMtERUW5uD1FraHSomTN3wSkzcc4PKpGg+PWHBFD84hbVQEZQWoagJ5Xhb Mv1aFVz+PDS7WTLRjjzI3/r4f3n/zx7N3TJBC3qPz/FgPJY6s+MobfxiX3TxfZ4FQITm UtogIZKfFDygLEtHVL0jzihfUraD7hhrSKZ5jVQ9B64yED3R1Hs+HbvBE7hRMCNY5+5Y B/Yt2q4HmPgHIjcXO60h+/KlR+T943toFQ9IFKyU0WPZ2uNthhcK1PVqEO5iew+mGhU0 U497rM9uHMfnVPHfaU8O3uc/81MIvFhI+gAfEoN0yIRlpSvXJViZoXlf2cC9Gn22QzPW yUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d9vAkjT4zw1XDm8fsnSZlNEkjl4Nf7vHSlfSiY9KNso=; b=tAogdslMlj664vLFxnELJ7yz9UFZ8aArOrh8rU59aWEPJp8GL0aCP3Pe61i1zVvGK4 /1+pFWw2ylJrlUVYcIXK0tpwRbU56fO16IOmfUeDPSVkk8Ehggsiw8kacjjAEYQrxqyV XS9NLa2gZTqPLgFCs0ier9wJXXOd6+EHzZdinJccWa8Mq54sEPIoAnf9l2IFhjFnojqy QTkTuBFl5sSgA/s2lZ9n7vQP9FUdoIKKW7dxbVATeQKeZk62DEkcB5fpgFaYBY2qMxv7 Nq5XLZ6zKYnI/6Y0cGthQe0TF6QDlsPGvz3BvrOgRfydrg1I9XUYqeVQHlP+FGgBs/wE ocUg== X-Gm-Message-State: APjAAAVKkSHmUGOPwJLn5LDP9RX6Yip6FBKfUKO8RTKtPIrUb+DteXTj jjVRxPQV3Yvoo750nvOfRSuysw== X-Google-Smtp-Source: APXvYqxy8NJKLvh/0D73f9xSTX35TDleS3jm+lfG9xUeZFBhjVdzfEIXiW9z84VlnU9ZXc5GOVMmrw== X-Received: by 2002:a37:a247:: with SMTP id l68mr540762qke.89.1559020771336; Mon, 27 May 2019 22:19:31 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li483-211.members.linode.com. [50.116.44.211]) by smtp.gmail.com with ESMTPSA id w189sm1054949qkc.38.2019.05.27.22.19.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 May 2019 22:19:30 -0700 (PDT) Date: Tue, 28 May 2019 13:19:24 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH v4 00/30] coresight: Support for ACPI bindings Message-ID: <20190528051924.GA19112@leoy-ThinkPad-X240s> References: <1558521304-27469-1-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1558521304-27469-1-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_221934_951222_B36A101E X-CRM114-Status: GOOD ( 23.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Wed, May 22, 2019 at 11:34:33AM +0100, Suzuki K Poulose wrote: > This series adds the support for CoreSight devices on ACPI based > platforms. The device connections are encoded as _DSD graph property[0], > with CoreSight specific extensions to indicate the direction of data > flow as described in [1]. Components attached to CPUs are listed > as child devices of the corresponding CPU, removing explicit links > to the CPU like we do in the DT. > > The majority of the series cleans up the driver and prepares the subsystem > for platform agnostic firwmare probing, naming scheme, searching etc. > > We introduce platform independent helpers to parse the platform supplied > information. Thus we rename the platform handling code from: > of_coresight.c => coresight-platform.c > > The CoreSight driver creates shadow devices that appear on the Coresight > bus, in addition to the real devices (e.g, AMBA bus devices). The name > of these devices match the real device. This makes the device name > a bit cryptic for ACPI platform. So this series also introduces a generic > platform agnostic device naming scheme for the shadow Coresight devices. > Towards this we also make changes to the way we lookup devices to resolve > the connections, as we can't use the names to identify the devices. So, > we use the "fwnode_handle" of the real device for the device lookups. > Towards that we clean up the drivers to keep track of the "CoreSight" > device rather than the "real" device. However, all real operations, > like DMA allocation, Power management etc. must be performed on > the real device which is the parent of the shadow device. > > Finally we add the support for parsing the ACPI platform data. The power > management support is missing in the ACPI (and this is not specific to > CoreSight). The firmware must ensure that the respective power domains > are turned on. > > Applies on v5.2-rc1 > > Tested on a Juno-r0 board with ACPI bindings patch (Patch 31/30) added on > top of [2]. You would need to make sure that the debug power domain is > turned on before the Linux kernel boots. (e.g, connect the DS-5 to the > Juno board while at UEFI). arm32 code is only compile tested. After I applied this patch set, I found all device names under '/sys/bus/event_source/devices/cs_etm/sinks/' have been changed as below on my DB410c board: # ls /sys/bus/event_source/devices/cs_etm/sinks/ tmc_etf0 tmc_etr0 tpiu0 This leads to below command failure when open PMU device: # perf record -e cs_etm/@826000.etr/ --per-thread uname failed to set sink "826000.etr" on event cs_etm/@826000.etr/ with 2 (No such file or directory) I must use below command so that perf can match string with the device name under '/sys/bus/event_source/devices/cs_etm/sinks/': # perf record -e cs_etm/@tmc_etr0/ --per-thread uname Seems to me, this is an unexpected change and when I worked on the patch set v2, IIRC that version still can use '826000.etr' to open PMU device. Please help confirm for this. Thanks! Leo. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel