From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2390C28CC2 for ; Fri, 31 May 2019 07:30:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86D0E264E7 for ; Fri, 31 May 2019 07:30:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AtZ8bis4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mTrEKnP3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86D0E264E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NJ3g3ciaBKpZZ/yWy4KRsAU3mUD4UduBuTd/77xK9Tg=; b=AtZ8bis4qQXuTf tbyqkICXDz3OolOlh0e+e45X6YvL2Yny9msyjdGf+L3BiiRQcxBfxVNeVqZkkGH0cmJ7yBD5cH73p y3ISN0aUSV5D1Dsc+HsKj+nHKAvvApoCMSoF/SkLdeuVyxNro2UXgYaDmzraFuZThVwaJN6a1/USE LuyHsxVmvq0jwxUeFHTtsE8XUFAzq+Bg6JkbwUqAFrxmNVZ+FmPrUtvZvJrAwGAYye2ZwHNhstGKA K4nsaTtqhhSpJV5vpAH/B9vZSDH9kB5lPxioFdYiYlt/rqTnaRkPXkwkEmaQj2XMNUiImgwCiZ8oM Mt72jL4G/SC6GuXCOXHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWbzE-0007OE-Lg; Fri, 31 May 2019 07:30:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWbzC-0007Nm-AD for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 07:29:59 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E55FA264E7; Fri, 31 May 2019 07:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559287798; bh=Sx1m5/E8D/5A8KuMvDlpJkX5r56naO8qUsBat8C+qgk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTrEKnP3igGNFyinU5WlegALoxSzHevTxDMhvJML01Fxvds9diY9kGh0ptqTEVba6 jZt+kT6htNw5fnBs9nk4d0FTlH5KiAWoPM3Y6WcCd31Ggzsfzo/Mgb3lVBrxVqA5jx jhOcrry6DTnI5nrlsGw61OpHny4D+zMtZFL6SIw8= Date: Fri, 31 May 2019 15:28:33 +0800 From: Shawn Guo To: Daniel Baluta Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Message-ID: <20190531072832.GC23453@dragon> References: <20190515144210.25596-1-daniel.baluta@nxp.com> <20190515144210.25596-3-daniel.baluta@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_002958_365445_533B673A X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Aisheng Dong , Peng Fan , Anson Huang , "devicetree@vger.kernel.org" , Fabio Estevam , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "m.felsch@pengutronix.de" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Daniel Baluta , "S.j. Wang" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > > > > + simple-audio-card,codec { > > > > + sound-dai = <&wm8524>; > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > interface, not an external clock that feeds the codec. > > > > > > It seems you should remove this 'clocks' entry. > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > the representation is correct: > > > > Reviewed-by: Fabio Estevam > > Shawn, > > Can you have a look? I cannot apply this one, because there are '=20' in the patch content. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel