From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 490A7C04AB6 for ; Fri, 31 May 2019 07:43:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20FC52652B for ; Fri, 31 May 2019 07:43:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rSk1XbUi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GA2IoBIQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20FC52652B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZhG7+vEP+0kK5KcI/9i7zB3Rw3R35Hd5Nzb+3NVDIzQ=; b=rSk1XbUi15V64O a9UR6SW71W9sqs8AxIFPShZ3LlSzDL0lKLW8oG5GMbgJEsiEQVdIvJAmyCCveSFwJtc4U3oB+KYir LAHA0Eq4a4UejL04FXowm3+W688eaGkE8VQ2or+t/Hx0U2I6GwyoZ0XIrZRCM4Axia3cvpWET3NDA PuHAt4V0UZw6T4tT8tvcRY8kc5X+IZ3+X27J/ODQTGlOzPwAmZwmdMmGHKJNsLOH7osJWVlGW5c2u NOKrfVvHSwXTWe06h3Pdnex3yfTJxAtQ72nCSLtHG5ykJLHFllY/NrwRs2a5GmroysE59mgkUJXEe tazO4QyJ1A2Pm5LLRVCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWcCh-0007Lf-L0; Fri, 31 May 2019 07:43:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWcCe-0007LD-GM for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 07:43:53 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F29326529; Fri, 31 May 2019 07:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559288632; bh=BSO7PBA+ISSFwY87NDWyqZN2RLuI6E2nd55J5EJjfrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GA2IoBIQOegjFScrFondeK8spRXBSFymW1AP9qrLJiol9hWRMym9scSnEGDwSQ8Ph MKJzxigCFNwwje/M9U6IfeYm4Ld7G6r/+mgEaLxUdrQ35KGWQ+aIHTsR+g0w1YgmmT NJncQZ5TTpXzdQvUMVqy7ResQtMsJPrhJAlhQiO4= Date: Fri, 31 May 2019 15:42:30 +0800 From: Shawn Guo To: Daniel Baluta Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Message-ID: <20190531074230.GE23453@dragon> References: <20190515144210.25596-1-daniel.baluta@nxp.com> <20190515144210.25596-3-daniel.baluta@nxp.com> <20190531072832.GC23453@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190531072832.GC23453@dragon> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_004352_557487_BAE8A00E X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Aisheng Dong , Peng Fan , Anson Huang , "devicetree@vger.kernel.org" , Daniel Baluta , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "m.felsch@pengutronix.de" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "S.j. Wang" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 03:28:33PM +0800, Shawn Guo wrote: > On Tue, May 28, 2019 at 10:10:43AM +0300, Daniel Baluta wrote: > > On Mon, May 20, 2019 at 10:33 PM Fabio Estevam wrote: > > > > > > On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > > > > > > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > > > > > > + simple-audio-card,codec { > > > > > + sound-dai = <&wm8524>; > > > > > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; > > > > > > > > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 > > > > interface, not an external clock that feeds the codec. > > > > > > > > It seems you should remove this 'clocks' entry. > > > > > > Just checked the schematics and the SAI3_MCLK pin clocks the codec, so > > > the representation is correct: > > > > > > Reviewed-by: Fabio Estevam > > > > Shawn, > > > > Can you have a look? > > I cannot apply this one, because there are '=20' in the patch content. Talk to NXP colleague Anson Huang to find out how to fix it. https://patchwork.kernel.org/patch/10944169/#22656941 Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel