* [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible
2019-06-06 9:56 [RFC RESEND PATCH v2 0/4] arm64: dts: ti: am6: Add gpio nodes Keerthy
@ 2019-06-06 9:56 ` Keerthy
2019-06-07 22:39 ` Linus Walleij
2019-06-06 9:56 ` [RFC RESEND PATCH v2 2/4] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Keerthy @ 2019-06-06 9:56 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: devicetree, linux-gpio, lokeshvutla, j-keerthy, linus.walleij,
linux-kernel, bgolaszewski, linux-arm-kernel
The patch adds k3 am654 compatible, specific properties and
an example.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../devicetree/bindings/gpio/gpio-davinci.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
index 553b92a7e87b..bc6b4b62df83 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
@@ -5,6 +5,7 @@ Required Properties:
"ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
66AK2E SoCs
"ti,k2g-gpio", "ti,keystone-gpio": for 66AK2G
+ "ti,am654-gpio", "ti,keystone-gpio": for TI K3 AM654
- reg: Physical base address of the controller and the size of memory mapped
registers.
@@ -145,3 +146,20 @@ gpio0: gpio@260bf00 {
ti,ngpio = <32>;
ti,davinci-gpio-unbanked = <32>;
};
+
+Example for K3 AM654:
+
+wkup_gpio0: wkup_gpio0@42110000 {
+ compatible = "ti,am654-gpio", "ti,keystone-gpio";
+ reg = <0x42110000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_wkup_gpio>;
+ interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <56>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 59 0>;
+ clock-names = "gpio";
+};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible
2019-06-06 9:56 ` [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible Keerthy
@ 2019-06-07 22:39 ` Linus Walleij
2019-06-08 3:51 ` keerthy
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2019-06-07 22:39 UTC (permalink / raw)
To: Keerthy
Cc: ext Nishanth Menon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bartosz Golaszewski, Lokesh Vutla, linux-kernel, Tero Kristo,
open list:GPIO SUBSYSTEM, Rob Herring, Linux ARM
On Thu, Jun 6, 2019 at 11:55 AM Keerthy <j-keerthy@ti.com> wrote:
> The patch adds k3 am654 compatible, specific properties and
> an example.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Patch applied with the three others, so now all
GPIO changes are in tree.
Please funnel all the DTS changes through ARM SoC.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible
2019-06-07 22:39 ` Linus Walleij
@ 2019-06-08 3:51 ` keerthy
2019-06-17 14:27 ` Tero Kristo
0 siblings, 1 reply; 9+ messages in thread
From: keerthy @ 2019-06-08 3:51 UTC (permalink / raw)
To: Linus Walleij, Tero Kristo
Cc: ext Nishanth Menon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bartosz Golaszewski, Lokesh Vutla, linux-kernel,
open list:GPIO SUBSYSTEM, Rob Herring, Linux ARM
On 6/8/2019 4:09 AM, Linus Walleij wrote:
> On Thu, Jun 6, 2019 at 11:55 AM Keerthy <j-keerthy@ti.com> wrote:
>
>> The patch adds k3 am654 compatible, specific properties and
>> an example.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Patch applied with the three others, so now all
> GPIO changes are in tree.
>
> Please funnel all the DTS changes through ARM SoC.
Thank you Linus!
Tero,
Could you pull the dts changes on top of intr dts patches.
Regards,
Keerthy
>
> Yours,
> Linus Walleij
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible
2019-06-08 3:51 ` keerthy
@ 2019-06-17 14:27 ` Tero Kristo
0 siblings, 0 replies; 9+ messages in thread
From: Tero Kristo @ 2019-06-17 14:27 UTC (permalink / raw)
To: keerthy, Linus Walleij
Cc: ext Nishanth Menon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Bartosz Golaszewski, Lokesh Vutla, linux-kernel,
open list:GPIO SUBSYSTEM, Rob Herring, Linux ARM
On 08/06/2019 06:51, keerthy wrote:
>
>
> On 6/8/2019 4:09 AM, Linus Walleij wrote:
>> On Thu, Jun 6, 2019 at 11:55 AM Keerthy <j-keerthy@ti.com> wrote:
>>
>>> The patch adds k3 am654 compatible, specific properties and
>>> an example.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>
>> Patch applied with the three others, so now all
>> GPIO changes are in tree.
>>
>> Please funnel all the DTS changes through ARM SoC.
>
> Thank you Linus!
>
> Tero,
>
> Could you pull the dts changes on top of intr dts patches.
Queued patches #2...#4 towards 5.3, thanks.
-Tero
>
> Regards,
> Keerthy
>>
>> Yours,
>> Linus Walleij
>>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC RESEND PATCH v2 2/4] arm64: dts: ti: am6-wakeup: Add gpio node
2019-06-06 9:56 [RFC RESEND PATCH v2 0/4] arm64: dts: ti: am6: Add gpio nodes Keerthy
2019-06-06 9:56 ` [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible Keerthy
@ 2019-06-06 9:56 ` Keerthy
2019-06-06 9:56 ` [RFC RESEND PATCH v2 3/4] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
2019-06-06 9:56 ` [RFC RESEND PATCH v2 4/4] arm64: dts: ti: am654-base-board: Add gpio_keys node Keerthy
3 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2019-06-06 9:56 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: devicetree, linux-gpio, lokeshvutla, j-keerthy, linus.walleij,
linux-kernel, bgolaszewski, linux-arm-kernel
Add gpio0 node under wakeup domain. This has 56 gpios
and all are capable of generating banked interrupts.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index f1ca171abdf8..9cf2c0849a24 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -74,4 +74,19 @@
ti,sci-dst-id = <56>;
ti,sci-rm-range-girq = <0x4>;
};
+
+ wkup_gpio0: wkup_gpio0@42110000 {
+ compatible = "ti,am654-gpio", "ti,keystone-gpio";
+ reg = <0x42110000 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_wkup_gpio>;
+ interrupts = <59 128>, <59 129>, <59 130>, <59 131>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <56>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 59 0>;
+ clock-names = "gpio";
+ };
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [RFC RESEND PATCH v2 3/4] arm64: dts: ti: am6-main: Add gpio nodes
2019-06-06 9:56 [RFC RESEND PATCH v2 0/4] arm64: dts: ti: am6: Add gpio nodes Keerthy
2019-06-06 9:56 ` [RFC RESEND PATCH v2 1/4] dt-bindings: gpio: davinci: Add k3 am654 compatible Keerthy
2019-06-06 9:56 ` [RFC RESEND PATCH v2 2/4] arm64: dts: ti: am6-wakeup: Add gpio node Keerthy
@ 2019-06-06 9:56 ` Keerthy
2019-06-17 14:27 ` Tero Kristo
2019-06-06 9:56 ` [RFC RESEND PATCH v2 4/4] arm64: dts: ti: am654-base-board: Add gpio_keys node Keerthy
3 siblings, 1 reply; 9+ messages in thread
From: Keerthy @ 2019-06-06 9:56 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: devicetree, linux-gpio, lokeshvutla, j-keerthy, linus.walleij,
linux-kernel, bgolaszewski, linux-arm-kernel
Add gpio0/1 nodes under main domain. They have 96 and 90 gpios
respectively and all are capable of generating banked interrupts.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 32 ++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 22154f401930..182efe70402b 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -350,4 +350,36 @@
ti,sci-rm-range-global-event = <0x1>;
};
};
+
+ main_gpio0: main_gpio0@600000 {
+ compatible = "ti,am654-gpio", "ti,keystone-gpio";
+ reg = <0x0 0x600000 0x0 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_main_gpio>;
+ interrupts = <57 256>, <57 257>, <57 258>, <57 259>, <57 260>,
+ <57 261>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <96>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 57 0>;
+ clock-names = "gpio";
+ };
+
+ main_gpio1: main_gpio1@601000 {
+ compatible = "ti,am654-gpio", "ti,keystone-gpio";
+ reg = <0x0 0x601000 0x0 0x100>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-parent = <&intr_main_gpio>;
+ interrupts = <58 256>, <58 257>, <58 258>, <58 259>, <58 260>,
+ <58 261>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ ti,ngpio = <90>;
+ ti,davinci-gpio-unbanked = <0>;
+ clocks = <&k3_clks 58 0>;
+ clock-names = "gpio";
+ };
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC RESEND PATCH v2 3/4] arm64: dts: ti: am6-main: Add gpio nodes
2019-06-06 9:56 ` [RFC RESEND PATCH v2 3/4] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
@ 2019-06-17 14:27 ` Tero Kristo
0 siblings, 0 replies; 9+ messages in thread
From: Tero Kristo @ 2019-06-17 14:27 UTC (permalink / raw)
To: Keerthy, nm, robh+dt
Cc: devicetree, linux-gpio, lokeshvutla, linus.walleij, linux-kernel,
bgolaszewski, linux-arm-kernel
On 06/06/2019 12:56, Keerthy wrote:
> Add gpio0/1 nodes under main domain. They have 96 and 90 gpios
> respectively and all are capable of generating banked interrupts.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 32 ++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 22154f401930..182efe70402b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -350,4 +350,36 @@
> ti,sci-rm-range-global-event = <0x1>;
> };
> };
> +
> + main_gpio0: main_gpio0@600000 {
> + compatible = "ti,am654-gpio", "ti,keystone-gpio";
> + reg = <0x0 0x600000 0x0 0x100>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-parent = <&intr_main_gpio>;
> + interrupts = <57 256>, <57 257>, <57 258>, <57 259>, <57 260>,
> + <57 261>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + ti,ngpio = <96>;
> + ti,davinci-gpio-unbanked = <0>;
> + clocks = <&k3_clks 57 0>;
> + clock-names = "gpio";
> + };
> +
> + main_gpio1: main_gpio1@601000 {
> + compatible = "ti,am654-gpio", "ti,keystone-gpio";
> + reg = <0x0 0x601000 0x0 0x100>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-parent = <&intr_main_gpio>;
> + interrupts = <58 256>, <58 257>, <58 258>, <58 259>, <58 260>,
> + <58 261>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
The above line has an extra tab. Fixed locally and pushed to am654-next.
-Tero
> + ti,ngpio = <90>;
> + ti,davinci-gpio-unbanked = <0>;
> + clocks = <&k3_clks 58 0>;
> + clock-names = "gpio";
> + };
> };
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC RESEND PATCH v2 4/4] arm64: dts: ti: am654-base-board: Add gpio_keys node
2019-06-06 9:56 [RFC RESEND PATCH v2 0/4] arm64: dts: ti: am6: Add gpio nodes Keerthy
` (2 preceding siblings ...)
2019-06-06 9:56 ` [RFC RESEND PATCH v2 3/4] arm64: dts: ti: am6-main: Add gpio nodes Keerthy
@ 2019-06-06 9:56 ` Keerthy
3 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2019-06-06 9:56 UTC (permalink / raw)
To: t-kristo, nm, robh+dt
Cc: devicetree, linux-gpio, lokeshvutla, j-keerthy, linus.walleij,
linux-kernel, bgolaszewski, linux-arm-kernel
There are 2 push buttons: SW5 and SW6 that are basically connected to
WKUP_GPIO0_24 and WKUP_GPIO0_27 respectively. Add the respective
nodes and the pinctrl data to set the mode to GPIO and Input.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index cf1aa276a1ea..ea50b6e36eff 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -6,6 +6,7 @@
/dts-v1/;
#include "k3-am654.dtsi"
+#include <dt-bindings/input/input.h>
/ {
compatible = "ti,am654-evm", "ti,am654";
@@ -33,6 +34,25 @@
no-map;
};
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+ pinctrl-names = "default";
+ pinctrl-0 = <&push_button_pins_default>;
+
+ sw5 {
+ label = "GPIO Key USER1";
+ linux,code = <BTN_0>;
+ gpios = <&wkup_gpio0 24 GPIO_ACTIVE_LOW>;
+ };
+
+ sw6 {
+ label = "GPIO Key USER2";
+ linux,code = <BTN_1>;
+ gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>;
+ };
+ };
};
&wkup_pmx0 {
@@ -42,6 +62,13 @@
AM65X_WKUP_IOPAD(0x00e4, PIN_INPUT, 0) /* (AD6) WKUP_I2C0_SDA */
>;
};
+
+ push_button_pins_default: push_button__pins_default {
+ pinctrl-single,pins = <
+ AM65X_WKUP_IOPAD(0x0030, PIN_INPUT, 7) /* (R5) WKUP_GPIO0_24 */
+ AM65X_WKUP_IOPAD(0x003c, PIN_INPUT, 7) /* (P2) WKUP_GPIO0_27 */
+ >;
+ };
};
&main_pmx0 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread