From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, tengfeif@codeaurora.org,
catalin.marinas@arm.com, will.deacon@arm.com,
james.morse@arm.com, dave.martin@arm.com
Subject: [PATCH 0/3] arm64: stacktrace: improve robustness
Date: Thu, 6 Jun 2019 13:53:59 +0100 [thread overview]
Message-ID: <20190606125402.10229-1-mark.rutland@arm.com> (raw)
The arm64 stacktrace code is careful to only access valid stack
locations, but in the presence of a corrupted stack where frame records
form a loop, it will never terminate.
This series updates the stacktrace code to terminate in finite time even
when a stack is corrupted. A stacktrace will be terminated if the next
record is at a lower (or equal) address on the current stack, or when
the next record is on a stack we've already completed unwinding.
The first couple of patches come from Dave's prior attempt to fix this
[1], with the final patch relying on infrastructure which has been
introduced in the mean time.
I've given this a quick spin with magic-sysrq L in a KVM guest, and
things look fine, but further testing would be appreciated.
This series (based on v5.2-rc1) can also be found in my
arm64/robust-stracktrace branch on kernel.org [2].
Thanks,
Mark.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/572685.html
[2] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/robust-stacktrace
Dave Martin (2):
arm64: stacktrace: Constify stacktrace.h functions
arm64: stacktrace: Factor out backtrace initialisation
Mark Rutland (1):
arm64: stacktrace: better handle corrupted stacks
arch/arm64/include/asm/stacktrace.h | 55 ++++++++++++++++++++++++++++---------
arch/arm64/kernel/process.c | 6 +---
arch/arm64/kernel/stacktrace.c | 16 ++++++++++-
arch/arm64/kernel/time.c | 6 +---
arch/arm64/kernel/traps.c | 13 ++++-----
5 files changed, 65 insertions(+), 31 deletions(-)
--
2.11.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-06-06 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 12:53 Mark Rutland [this message]
2019-06-06 12:54 ` [PATCH 1/3] arm64: stacktrace: Constify stacktrace.h functions Mark Rutland
2019-06-06 12:54 ` [PATCH 2/3] arm64: stacktrace: Factor out backtrace initialisation Mark Rutland
2019-06-21 15:50 ` Dave Martin
2019-06-28 11:27 ` Mark Rutland
2019-06-06 12:54 ` [PATCH 3/3] arm64: stacktrace: better handle corrupted stacks Mark Rutland
2019-06-21 16:37 ` Dave Martin
2019-06-28 11:32 ` Mark Rutland
2019-06-24 11:34 ` James Morse
2019-06-25 10:28 ` James Morse
2019-06-27 16:24 ` James Morse
2019-06-28 11:15 ` Dave Martin
2019-06-28 13:02 ` Mark Rutland
2019-07-01 10:48 ` Dave Martin
2019-07-01 11:22 ` Mark Rutland
2019-06-28 15:35 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606125402.10229-1-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dave.martin@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=tengfeif@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).