From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: coresight@lists.linaro.org, corbet@lwn.net,
linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: coresight: Update the generic device names
Date: Fri, 7 Jun 2019 10:21:36 +0800 [thread overview]
Message-ID: <20190607022136.GE5970@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <99055755-6525-694e-a15d-5de7318a80da@arm.com>
Hi Suzuki,
On Thu, Jun 06, 2019 at 05:21:19PM +0100, Suzuki K Poulose wrote:
> Hi Mathieu,
>
> On 03/06/2019 20:01, Mathieu Poirier wrote:
> > Hi Suzuki,
> >
> > On Thu, May 30, 2019 at 04:11:17PM +0100, Suzuki K Poulose wrote:
> > > Update the documentation to reflect the new naming scheme with
> > > latest changes.
> > >
> > > Reported-by: Leo Yan <leo.yan@linaro.org>
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Cc: Jonathan Corbet <corbet@lwn.net>
> > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > > ---
> > > Documentation/trace/coresight.txt | 34 +++++++++++++++++++---------------
> > > 1 file changed, 19 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/Documentation/trace/coresight.txt b/Documentation/trace/coresight.txt
> > > index efbc832..7b427cf 100644
> > > --- a/Documentation/trace/coresight.txt
> > > +++ b/Documentation/trace/coresight.txt
> > > @@ -326,16 +326,20 @@ amount of processor cores), the "cs_etm" PMU will be listed only once.
> > > A Coresight PMU works the same way as any other PMU, i.e the name of the PMU is
> > > listed along with configuration options within forward slashes '/'. Since a
> > > Coresight system will typically have more than one sink, the name of the sink to
> > > -work with needs to be specified as an event option. Names for sink to choose
> > > -from are listed in sysFS under ($SYSFS)/bus/coresight/devices:
> > > +work with needs to be specified as an event option.
> > > +On newer kernels the available sinks are listed in sysFS under:
> > > +($SYSFS)/bus/event_source/devices/cs_etm/sinks/
> > > - root@linaro-nano:~# ls /sys/bus/coresight/devices/
> > > - 20010000.etf 20040000.funnel 20100000.stm 22040000.etm
> > > - 22140000.etm 230c0000.funnel 23240000.etm 20030000.tpiu
> > > - 20070000.etr 20120000.replicator 220c0000.funnel
> > > - 23040000.etm 23140000.etm 23340000.etm
> > > + root@localhost:/sys/bus/event_source/devices/cs_etm/sinks# ls
> > > + tmc_etf0 tmc_etr0 tpiu0
> > > - root@linaro-nano:~# perf record -e cs_etm/@20070000.etr/u --per-thread program
> > > +On older kernels, this may need to be found from the list of coresight devices,
> > > +available under ($SYSFS)/bus/coresight/devices/:
> > > +
> > > + root@localhost:/sys/bus/coresight/devices# ls
> > > + etm0 etm1 etm2 etm3 etm4 etm5 funnel0 funnel1 funnel2 replicator0 stm0 tmc_etf0 tmc_etr0 tpiu0
> > > +
> > > + root@linaro-nano:~# perf record -e cs_etm/@tmc_etr0/u --per-thread program
> >
> > On the "older" kernels you are referring to one would find the original naming
> > convention. Everything else looks good to me.
>
> True, but do we care what we see there ? All we care about is the location,
> where to find them. I could fix it, if you think thats needed.
IIUC, either the old kernel or newer kernel, both we can find the event
from ($SYSFS)/bus/event_source/devices/cs_etm/sinks/; the only
difference between them is the naming convention.
So the doc can use the same location to find event for both new and
old kernel, and explain the naming convention difference?
Thanks,
Leo Yan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-07 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:11 [PATCH] Documentation: coresight: Update the generic device names Suzuki K Poulose
2019-06-03 19:01 ` Mathieu Poirier
2019-06-06 16:21 ` Suzuki K Poulose
2019-06-07 2:21 ` Leo Yan [this message]
2019-06-07 8:40 ` Suzuki K Poulose
2019-06-07 13:42 ` Leo Yan
2019-06-07 15:58 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607022136.GE5970@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).