From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE6DDC2BCA1 for ; Fri, 7 Jun 2019 15:17:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B551A2089E for ; Fri, 7 Jun 2019 15:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bKz2DwXo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B551A2089E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RMxxQwOKcJy0RqquHicHtA+FcuiyVJqqrNDMmIuDp1M=; b=bKz2DwXokKGMDl DmWy0tnQi6bYi8BxqCtQg5qttmfdetq+82fIiSkOuH70XoN3ffxfpJPrdu/sTfpgVJqpjTuXsUnpS Aye0jljPsIO9wJbt8UOO7NhpAiCQay05y2+azbSfsX4r3SuUHs3dEY0sHoMpNdlI6q7s+NB/S8nXe iSeSnnwfTPJHNGIyjZgMd0s/1hLr3qt0KwKSESR4u29rjk72czvwBBuy2jB1ueq6krYE65JWLX412 7jWPC4yyf7qnKWGQ5rHoD2Em90da+YaCPeZUVBq5W1yQhKaXdcAAwvZLyaakKU5/WTg9QTGfP4jwc pBibsMa749yrFXqMtRIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZGcQ-00023m-29; Fri, 07 Jun 2019 15:17:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZGcM-000238-Vg for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 15:17:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B5A6367; Fri, 7 Jun 2019 08:17:21 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F0F83F718; Fri, 7 Jun 2019 08:17:18 -0700 (PDT) Date: Fri, 7 Jun 2019 16:17:16 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 07/18] drivers: firmware: psci: Prepare to use OS initiated suspend mode Message-ID: <20190607151716.GF15577@e107155-lin> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-8-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190513192300.653-8-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_081723_075803_573434AE X-CRM114-Status: GOOD ( 14.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Geert Uytterhoeven , Tony Lindgren , Viresh Kumar , Bjorn Andersson , Lina Iyer , Lina Iyer , Lorenzo Pieralisi , Kevin Hilman , Daniel Lezcano , "Raju P . L . S . S . S . N" , Souvik Chakravarty , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Amit Kucheria , Sudeep Holla , Niklas Cassel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 13, 2019 at 09:22:49PM +0200, Ulf Hansson wrote: > The per CPU variable psci_power_state, contains an array of fixed values, > which reflects the corresponding arm,psci-suspend-param parsed from DT, for > each of the available CPU idle states. > > This isn't sufficient when using the hierarchical CPU topology in DT in > combination with having PSCI OS initiated (OSI) mode enabled. More > precisely, in OSI mode, Linux is responsible of telling the PSCI FW what > idle state the cluster (a group of CPUs) should enter, while in PSCI > Platform Coordinated (PC) mode, each CPU independently votes for an idle > state of the cluster. > > For this reason, let's introduce an additional per CPU variable called > domain_state and implement two helper functions to read/write its values. > Following patches, which implements PM domain support for PSCI, will use > the domain_state variable and set it to corresponding bits that represents > the selected idle state for the cluster. > > Finally, in psci_cpu_suspend_enter() and psci_suspend_finisher(), let's > take into account the values in the domain_state, as to get the complete > suspend parameter. > I understand it was split to ease review, but this patch also does nothing as domain_state = 0 always. I was trying hard to find where it's set, but I assume it will be done in later patches. Again may be this can be squashed into the first caller of psci_set_domain_state -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel