From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED7DC468BD for ; Fri, 7 Jun 2019 15:57:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6DC92133D for ; Fri, 7 Jun 2019 15:57:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tP+WtRrU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PnGgQlJF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6DC92133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GaCsoo2PxtcpnNUgKCJCLJptOPcudjwmcozYcex9VfM=; b=tP+WtRrUzhL3gd 2CVhGvoI1F0hfE+k9B/tTgKAehJEmzhJo5amdX8TpAbIGYZUO+08I+PSWRtKHo97BR/QDBrwmw/VD VodHPEMACAT8G5ag+WPtK63Zao99TRjsCrqTWKprCVukYKfHqEtYbX2S6IAVa963feoigrOGSLVNm 8L+eGtg0H/A6f73CgxjFRLKQDjHI0EXglAs1KEyEghLtbZl0VxKyXsdoGQc0n2Duo64/3ROWnY6yi DzbArivoE4nvMTXeBfUwRwORi1QaWBywkFMlGDE7P89vtnqAbNhBVtDztnUAF5QKpri3DhR38FIjL Aj3ydefyHE7CGI7qN/wA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZHFK-0004kc-AU; Fri, 07 Jun 2019 15:57:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZHFH-0004kH-Bq for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 15:57:36 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 176DA20657; Fri, 7 Jun 2019 15:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559923054; bh=moVjOQu+0fxwl4+qBFcaT5nSX69Y7SsHo95mn91RMHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PnGgQlJFu52ZBRKJpAN9rhg2ncvxnPs76IhL3/WakJ2O3M2BtbHjQWErDkxeGpUF+ bespNOJSQEEziWFq+cSe6WmQOh5vTwd68C0aNND520a/ipC1JWK6SLnPjqnZ6p0jvL LPAK2XM8gVoPaLkso8Zs9BEZjgYJVqd5LGUtXTrw= Date: Fri, 7 Jun 2019 17:57:31 +0200 From: Greg KH To: Dragan Cvetic Subject: Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl Message-ID: <20190607155731.GB8752@kroah.com> References: <1558784245-108751-1-git-send-email-dragan.cvetic@xilinx.com> <1558784245-108751-5-git-send-email-dragan.cvetic@xilinx.com> <20190606132842.GC7943@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_085735_425204_3044D122 X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 07, 2019 at 10:58:34AM +0000, Dragan Cvetic wrote: > > On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > > > +{ > > > + return 0; > > > +} > > > + > > > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr) > > > +{ > > > + return 0; > > > +} > > > > empty open/close functions are never needed, just drop them. > > > > open() is needed to allocate file descriptor eg. > fd = open(dev_name, O_RDWR); But you do nothing in those open/release callbacks. Remove them and see that the code works just fine :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel