From: Wolfram Sang <wsa@the-dreams.de>
To: Annaliese McDermond <nh6z@nh6z.net>
Cc: stefan.wahren@i2se.com, f.fainelli@gmail.com,
swarren@wwwdotorg.org, team@nwdigitalradio.com, eric@anholt.net,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3] i2c: bcm2835: Model Divider in CCF
Date: Sat, 8 Jun 2019 00:38:23 +0200 [thread overview]
Message-ID: <20190607223822.GG869@kunai> (raw)
In-Reply-To: <20190529042912.12956-1-nh6z@nh6z.net>
[-- Attachment #1.1: Type: text/plain, Size: 170 bytes --]
> + devm_clk_unregister(i2c_dev->dev, bus_clk);
Is there a reason you call this and not rely on devm to unregister?
Other than that, looks good from what I can tell.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-07 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 4:29 [PATCH v3] i2c: bcm2835: Model Divider in CCF Annaliese McDermond
2019-06-02 7:40 ` Stefan Wahren
2019-06-04 19:26 ` Eric Anholt
2019-06-07 22:38 ` Wolfram Sang [this message]
2019-06-08 17:14 ` [PATCH v4] " Annaliese McDermond
2019-06-12 10:41 ` Wolfram Sang
2019-06-13 5:09 ` Annaliese McDermond
2019-06-13 7:50 ` Wolfram Sang
2019-06-19 7:16 ` Stefan Wahren
2019-06-19 7:56 ` Annaliese McDermond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607223822.GG869@kunai \
--to=wsa@the-dreams.de \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nh6z@nh6z.net \
--cc=stefan.wahren@i2se.com \
--cc=swarren@wwwdotorg.org \
--cc=team@nwdigitalradio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).