From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25A4C31E43 for ; Mon, 10 Jun 2019 17:48:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B96C620859 for ; Mon, 10 Jun 2019 17:48:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FVmB7VIZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="ddQy0EE+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B96C620859 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codeweavers.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zSSUy1/iIYH9+zVGNNYIiaCqg0kQw7AtU8Y57ZBqFnQ=; b=FVmB7VIZ1tKjf9 tJ0cRZGmwjdQu+NjJgZXmPSnbiTwVEUCu9QM0s+3u3szRZe2qFVkdkhs3m+WhXBss5Hu/A6NRyVzO apoGrdVl9S6K/jQg6fEe//c26IMjN/GMO+BUeyR1JQ6D0ZM8mJawPAc8yAuBkWQcCOrw5hBjxVi5N gyHwQy8ZBX8PDy0fGNjqC1UtFiMNjoF7z6VsoYAd65Bhor78+qltC5u1jwBFAZbccGsIjulz4BgP7 K5vIFyfOVZOjlOx97vWIS3p0/vG4BPIuxPPsHbTB/UURDzHiGTGM0y3dE09htThFestKXs/BNbPFX dHN++O/KHyQ+PDjwbwQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haOOm-0005DY-NY; Mon, 10 Jun 2019 17:48:01 +0000 Received: from mail.codeweavers.com ([50.203.203.244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haOOj-0005Cp-1L for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 17:47:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B+NQK0qQzwriFdGQRKl3qnBuYxHERXIyxTc267JOpl0=; b=ddQy0EE+r/As82BHbGL2enMiF +xSkrfjkaTQ0AJxemttV6by74YhcQ50DLiLC1sA3I03bUdF2mNxbHrY1p4ORkTzfe/rv/xfMgzol2 SI2MK+71N2dyNCMb6kZwrM5MZdJ8KNTla+ziNnIZzH+w52ZzB0PpDi3xi3X39ShZeK5/E=; Received: from merlot.physics.ox.ac.uk ([163.1.241.98] helo=merlot) by mail.codeweavers.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haOPC-0004C2-Gt; Mon, 10 Jun 2019 12:48:27 -0500 Received: from daviesh by merlot with local (Exim 4.90_1) (envelope-from ) id 1haOOY-0003Rh-VS; Mon, 10 Jun 2019 18:47:47 +0100 Date: Mon, 10 Jun 2019 18:47:46 +0100 From: Huw Davies To: Vincenzo Frascino Subject: Re: [PATCH v6 01/19] kernel: Standardize vdso_datapage Message-ID: <20190610174746.GA13224@merlot.physics.ox.ac.uk> References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-2-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_104757_140727_B71E1319 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Shuah Khan , Arnd Bergmann , Catalin Marinas , Daniel Lezcano , Will Deacon , linux-mips@vger.kernel.org, Ralf Baechle , Linux Kernel Mailing List , Dmitry Safonov <0x7f454c46@gmail.com>, Paul Burton , "open list:KERNEL SELFTEST FRAMEWORK" , Rasmus Villemoes , Russell King , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 04, 2019 at 01:05:40PM +0100, Vincenzo Frascino wrote: > On 31/05/2019 09:16, Arnd Bergmann wrote: > > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino > > wrote: > > > >> + * vdso_data will be accessed by 64 bit and compat code at the same time > >> + * so we should be careful before modifying this structure. > >> + */ > >> +struct vdso_data { > >> + u32 seq; > >> + > >> + s32 clock_mode; > >> + u64 cycle_last; > >> + u64 mask; > >> + u32 mult; > >> + u32 shift; > >> + > >> + struct vdso_timestamp basetime[VDSO_BASES]; > >> + > >> + s32 tz_minuteswest; > >> + s32 tz_dsttime; > >> + u32 hrtimer_res; > >> +}; > > > > The structure contains four padding bytes at the end, which is > > something we try to avoid, at least if this ends up being used as > > an ABI. Maybe add "u32 __unused" at the end? > > > > Agreed, I will fix this in v7. Note that this is also necessary to ensure that CLOCK_MONOTONIC_RAW works in the 32-bit vDSO on x86_64 kernels. Huw. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel