From: Will Deacon <will.deacon@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Qian Cai <cai@lca.pw>,
Nathan Chancellor <natechancellor@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS
Date: Wed, 12 Jun 2019 10:33:31 +0100 [thread overview]
Message-ID: <20190612093331.GB11554@brain-police> (raw)
In-Reply-To: <20190612092519.GP28398@e103592.cambridge.arm.com>
On Wed, Jun 12, 2019 at 10:25:20AM +0100, Dave Martin wrote:
> On Tue, Jun 11, 2019 at 10:19:32AM -0700, Nathan Chancellor wrote:
> > v1 -> v2:
> >
> > * Improve commit message explanation, I wasn't entirely happy with the
> > first one; let me know if there are any issues/questions.
> >
> > * Carry forward Dave's ack and Nick's review (let me know if you
> > disagree with the commit messasge rewording).
> >
> > arch/arm64/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index 8fbd583b18e1..e9d2e578cbe6 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -51,7 +51,7 @@ endif
> >
> > KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst)
> > KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> > -KBUILD_CFLAGS += -Wno-psabi
> > +KBUILD_CFLAGS += $(call cc-disable-warning, psabi)
> > KBUILD_AFLAGS += $(lseinstr) $(brokengasinst)
> >
> > KBUILD_CFLAGS += $(call cc-option,-mabi=lp64)
>
> Looks OK to me. Thanks for the additional explanation.
I'd already queued the previous version, but somehow forgotten to push it
out. I'll push this one out instead later today.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-12 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 16:12 [PATCH] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS Nathan Chancellor
2019-06-07 16:24 ` Dave Martin
2019-06-07 16:27 ` Nick Desaulniers
2019-06-11 17:19 ` [PATCH v2] " Nathan Chancellor
2019-06-12 9:25 ` Dave Martin
2019-06-12 9:33 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612093331.GB11554@brain-police \
--to=will.deacon@arm.com \
--cc=Dave.Martin@arm.com \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).